linux.git/drivers/serial/mpsc.c, branch v2.6.25

serial: fix platform driver hotplug/coldplug

2008-04-16T02:35:40+00:00

Since 43cc71eed1250755986da4c0f9898f9a635cb3bf, the platform modalias is
prefixed with "platform:".  Add MODULE_ALIAS() to the hotpluggable serial
platform drivers, to re-enable auto loading.

NOTE that Kconfig for some of these drivers doesn't allow modular builds, and
thus doesn't match the driver source's unload support.  Presumably their
unload code is buggy and/or weakly tested...

[dbrownell@users.sourceforge.net: more drivers, registration fixes]
Signed-off-by: Kay Sievers 
Signed-off-by: David Brownell 
Acked-by: Peter Korsgaard 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

serial: MPSC: set baudrate when BRG divider is set.

2008-02-05T17:44:10+00:00

The clock to generate the desired baudrate with the MPSC is first divided
by the Baud Rate Generator (BRG) and then by the MPSC itself.  So, when the
BRG divider is changed, the MPSC divider must also be changed to generate
the correct baudrate.  During MPSC initialization, the BRG divider is
changed but the MPSC divider isn't changed until much later.  This results
in some printk's coming out garbled.  To fix that, set the MPSC divider at
the same time that the BRG divider is changed.

Signed-off-by: Mark A. Greer 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

serial: MPSC: Fix coding style and whitespace issues

2007-07-31T22:39:41+00:00

Fix up mpsc.c to be aligned with Documentation/CodingStyle.  Also fix up some
whitespace issues.

Signed-off-by: Mark A. Greer 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

serial: MPSC: Remove duplicate SUPPORT_SYSRQ definition

2007-07-31T22:39:41+00:00

Remove the duplicate definition of SUPPORT_SYSRQ in mpsc driver.

Signed-off-by: Mark A. Greer 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

serial: MPSC: Stop rx engine when CREAD cleared

2007-07-31T22:39:41+00:00

Currently, the MPSC driver doesn't stop recieving characters when the CREAD
flag in termios->c_cflag is cleared.  It should.  Also, only start receiving
if its not already started.

Signed-off-by: Stephane Chazelas 
Signed-off-by: Mark A. Greer 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

serial: MPSC: Remove race between Rx stop & restart

2007-07-31T22:39:41+00:00

The patch in commit ID f7232056bff5fe2d3bfeab35252a66ebaeb5bbde stops (aborts)
the MPSC's receive engine just before restarting it.  Unfortunately, it
doesn't wait for the abort to complete before restarting it which creates a
race between the abort and the restart.  If the restart occurs first, the
in-progress abort stops it again and the rx engine remains stopped.

Instead, do the abort when the SDMA engine is being stopped.  Make sure to
wait for the abort to complete before continuing.

Signed-off-by: Carlos Sanchez 
Signed-off-by: Mark A. Greer 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

serial: clear proper MPSC interrupt cause bits

2007-06-28T18:38:29+00:00

The interrupt clearing code in mpsc_sdma_intr_ack() mistakenly clears the
interrupt for both controllers instead of just the one its supposed to.
This can result in the other controller appearing to hang because its
interrupt was effectively lost.

So, don't clear the interrupt cause bits for both MPSC controllers when
clearing the interrupt for one of them.  Just clear the one that is
supposed to be cleared.

Signed-off-by: Jay Lubomirski 
Acked-by: Mark A. Greer 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

MPSC serial driver tx locking

2007-05-07T19:12:50+00:00

The MPSC serial driver assumes that interrupt is always on to pick up the
DMA transmit ops that aren't submitted while the DMA engine is active.
However when irqs are off for a period of time such as operations under
kernel crash dump console messages do not show up due to additional DMA ops
are being dropped.  This makes console writes to process through all the tx
DMAs queued up before submitting a new request.

Also, the current locking mechanism does not protect the hardware registers
and ring buffer when a printk is done during the serial write operations.
The additional per port transmit lock provides a finer granular locking and
protects registers being clobbered while printks are nested within UART
writes.

Signed-off-by: Dave Jiang 
Signed-off-by: Mark A. Greer 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] tty: switch to ktermios

2006-12-08T16:28:57+00:00

This is the grungy swap all the occurrences in the right places patch that
goes with the updates.  At this point we have the same functionality as
before (except that sgttyb() returns speeds not zero) and are ready to
begin turning new stuff on providing nobody reports lots of bugs

If you are a tty driver author converting an out of tree driver the only
impact should be termios->ktermios name changes for the speed/property
setting functions from your upper layers.

If you are implementing your own TCGETS function before then your driver
was broken already and its about to get a whole lot more painful for you so
please fix it 8)

Also fill in c_ispeed/ospeed on init for most devices, although the current
code will do this for you anyway but I'd like eventually to lose that extra
paranoia

[akpm@osdl.org: bluetooth fix]
[mp3@de.ibm.com: sclp fix]
[mp3@de.ibm.com: warning fix for tty3270]
[hugh@veritas.com: fix tty_ioctl powerpc build]
[jdike@addtoit.com: uml: fix ->set_termios declaration]
Signed-off-by: Alan Cox 
Signed-off-by: Martin Peschke 
Acked-by: Peter Oberparleiter 
Cc: Cornelia Huck 
Signed-off-by: Hugh Dickins 
Signed-off-by: Jeff Dike 
Cc: Paolo 'Blaisorblade' Giarrusso 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] Pass struct dev pointer to dma_cache_sync()

2006-12-07T16:39:41+00:00

Pass struct dev pointer to dma_cache_sync()

dma_cache_sync() is ill-designed in that it does not have a struct device
pointer argument which makes proper support for systems that consist of a
mix of coherent and non-coherent DMA devices hard.  Change dma_cache_sync
to take a struct device pointer as first argument and fix all its callers
to pass it.

Signed-off-by: Ralf Baechle 
Cc: James Bottomley 
Cc: "David S. Miller" 
Cc: Greg KH 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds