linux.git/drivers/scsi, branch v5.1-rc4

scsi: lpfc: Fix missing wakeups on abort threads

2019-04-04T03:35:09+00:00

Abort thread wakeups, on some wqe types, are not happening.  The thread
wakeup logic is dependent upon the LPFC_DRIVER_ABORTED flag. However, on
these wqes, the completion handler running prior to the io completion
routine ends up clearing the flag.

Rework the wakeup logic to look at a non-null waitq element which must be
set if the abort thread is waiting. This is reverting the change in the
indicated patch.

Fixes: c2017260eea2d ("scsi: lpfc: Rework locking on SCSI io completion")
Signed-off-by: Dick Kennedy 
Signed-off-by: James Smart 
Signed-off-by: Martin K. Petersen

scsi: storvsc: Reduce default ring buffer size to 128 Kbytes

2019-04-04T03:31:03+00:00

Reduce the default VMbus channel ring buffer size for storvsc SCSI devices
from 1 Mbyte to 128 Kbytes. Measurements show that ring buffer sizes above
128 Kbytes do not increase performance even at very high IOPS rates, so
don't waste the memory. Also remove the dependence on PAGE_SIZE, since the
ring buffer size should not change on architectures where PAGE_SIZE is not
4 Kbytes.

Signed-off-by: Michael Kelley 
Reviewed-by: Haiyang Zhang 
Signed-off-by: Martin K. Petersen

scsi: storvsc: Fix calculation of sub-channel count

2019-04-04T03:30:08+00:00

When the number of sub-channels offered by Hyper-V is >= the number of CPUs
in the VM, calculate the correct number of sub-channels.  The current code
produces one too many.

This scenario arises only when the number of CPUs is artificially
restricted (for example, with maxcpus= on the kernel boot line), because
Hyper-V normally offers a sub-channel count < number of CPUs.  While the
current code doesn't break, the extra sub-channel is unbalanced across the
CPUs (for example, a total of 5 channels on a VM with 4 CPUs).

Signed-off-by: Michael Kelley 
Reviewed-by: Vitaly Kuznetsov 
Reviewed-by: Long Li 
Signed-off-by: Martin K. Petersen

scsi: core: add new RDAC LENOVO/DE_Series device

2019-04-04T03:27:23+00:00

Blacklist "Universal Xport" LUN. It's used for in-band storage array
management.  Also add model to the rdac dh family.

Cc: Martin Wilck 
Cc: Hannes Reinecke 
Cc: NetApp RDAC team 
Cc: Christophe Varoqui 
Cc: James E.J. Bottomley 
Cc: Martin K. Petersen 
Cc: SCSI ML 
Cc: DM ML 
Signed-off-by: Xose Vazquez Perez 
Reviewed-by: Martin Wilck 
Signed-off-by: Martin K. Petersen

scsi: qedi: remove declaration of nvm_image from stack

2019-03-29T14:02:51+00:00

The nvm_image is a large struct qedi_nvm_iscsi_image object of over 24K so
don't declare it on the stack just for a sizeof requirement; use sizeof on
struct qedi_nvm_iscsi_image instead.

Fixes: c77a2fa3ff8f ("scsi: qedi: Add the CRC size within iSCSI NVM image")
Signed-off-by: Colin Ian King 
Acked-by: Manish Rangankar 
Signed-off-by: Martin K. Petersen

scsi: ibmvfc: Clean up transport events

2019-03-28T01:34:20+00:00

No change to functionality. Simply make transport event messages a little
clearer, and rework CRQ format enums such that we have separate enums for
INIT messages and XPORT events.

[mkp: typo]

Signed-off-by: Tyrel Datwyler 
Signed-off-by: Martin K. Petersen

scsi: ibmvfc: Byte swap status and error codes when logging

2019-03-28T01:34:20+00:00

Status and error codes are returned in big endian from the VIOS. The values
are translated into a human readable format when logged, but the values are
also logged. This patch byte swaps those values so that they are consistent
between BE and LE platforms.

Signed-off-by: Tyrel Datwyler 
Signed-off-by: Martin K. Petersen

scsi: ibmvfc: Add failed PRLI to cmd_status lookup array

2019-03-28T01:34:20+00:00

The VIOS uses the SCSI_ERROR class to report PRLI failures. These errors
are indicated with the combination of a IBMVFC_FC_SCSI_ERROR return status
and 0x8000 error code. Add these codes to cmd_status[] with appropriate
human readable error message.

Signed-off-by: Tyrel Datwyler 
Signed-off-by: Martin K. Petersen

scsi: ibmvfc: Remove "failed" from logged errors

2019-03-28T01:34:20+00:00

The text of messages logged with ibmvfc_log_error() always contain the term
"failed". In the case of cancelled commands during EH they are reported
back by the VIOS using error codes. This can be confusing to somebody
looking at these log messages as to whether a command was successfully
cancelled. The following real log message for example it is unclear if the
transaction was actaully cancelled.

<6>sd 0:0:1:1: Cancelling outstanding commands.
<3>sd 0:0:1:1: [sde] Command (28) failed: transaction cancelled (2:6) flags: 0 fcp_rsp: 0, resid=0, scsi_status: 0

Remove prefixing of "failed" to all error logged messages. The
ibmvfc_log_error() function translates the returned error/status codes to a
human readable message already.

Signed-off-by: Tyrel Datwyler 
Signed-off-by: Martin K. Petersen

scsi: sd: Quiesce warning if device does not report optimal I/O size

2019-03-28T01:21:38+00:00

Commit a83da8a4509d ("scsi: sd: Optimal I/O size should be a multiple
of physical block size") split one conditional into several separate
statements in an effort to provide more accurate warning messages when
a device reports a nonsensical value. However, this reorganization
accidentally dropped the precondition of the reported value being
larger than zero. This lead to a warning getting emitted on devices
that do not report an optimal I/O size at all.

Remain silent if a device does not report an optimal I/O size.

Fixes: a83da8a4509d ("scsi: sd: Optimal I/O size should be a multiple of physical block size")
Cc: Randy Dunlap 
Cc: 
Reported-by: Hussam Al-Tayeb 
Tested-by: Hussam Al-Tayeb 
Reviewed-by: Bart Van Assche 
Signed-off-by: Martin K. Petersen