linux.git/drivers/scsi, branch v4.19-rc4

scsi: qedi: Add the CRC size within iSCSI NVM image

2018-08-30T11:15:22+00:00

The QED driver commit, 1ac4329a1cff ("qed: Add configuration information
to register dump and debug data"), removes the CRC length validation
causing nvm_get_image failure while loading qedi driver:

[qed_mcp_get_nvm_image:2700(host_10-0)]Image [0] is too big - 00006008 bytes
where only 00006004 are available
[qedi_get_boot_info:2253]:10: Could not get NVM image. ret = -12

Hence add and adjust the CRC size to iSCSI NVM image to read boot info at
qedi load time.

Signed-off-by: Nilesh Javali 
Signed-off-by: Martin K. Petersen

scsi: aacraid: fix a signedness bug

2018-08-27T17:17:00+00:00

The problem is that ->reset_state is a u8 but it can be set to -1 or -2 in
aac_tmf_callback() and the error handling in aac_eh_target_reset() relies
on it to be signed.

[mkp: fixed typo]

Fixes: 0d643ff3c353 ("scsi: aacraid: use aac_tmf_callback for reset fib")
Signed-off-by: Dan Carpenter 
Signed-off-by: Martin K. Petersen

Revert "scsi: core: avoid host-wide host_busy counter for scsi_mq"

2018-08-27T17:17:00+00:00

This reverts commit 328728630d9f2bf14b82ca30b5e47489beefe361.

There is fundamental issue in commit 328728630d9f2bf1 (scsi: core: avoid
host-wide host_busy counter for scsi_mq) because SCSI's host busy counter
may not be same with counter of blk-mq's inflight tags, especially in case
of none io scheduler.

We may switch to other approach for addressing this scsi_mq's performance
issue, such as percpu counter or kind of ways, so revert this commit first
for fixing this kind of issue in EH path, as reported by Jens.

Cc: Omar Sandoval ,
Cc: "Martin K. Petersen" ,
Cc: James Bottomley ,
Cc: Christoph Hellwig ,
Cc: Don Brace 
Cc: Kashyap Desai 
Cc: Mike Snitzer 
Cc: Hannes Reinecke 
Cc: Laurence Oberman 
Cc: Bart Van Assche 
Cc: Jens Axboe 
Reported-by: Jens Axboe 
Signed-off-by: Ming Lei 
Signed-off-by: Martin K. Petersen

Revert "scsi: core: fix scsi_host_queue_ready"

2018-08-27T16:59:43+00:00

This reverts commit 265d59aacbce7e50bdc1f5d25033c38dd70b3767.

There is fundamental issue in commit 328728630d9f2bf1 (scsi: core: avoid
host-wide host_busy counter for scsi_mq) because SCSI's host busy counter
may not be same with counter of blk-mq's inflight tags, especially in case
of none io scheduler.

So revert this commit first.

Cc: Omar Sandoval ,
Cc: "Martin K. Petersen" ,
Cc: James Bottomley ,
Cc: Christoph Hellwig ,
Cc: Don Brace 
Cc: Kashyap Desai 
Cc: Mike Snitzer 
Cc: Hannes Reinecke 
Cc: Laurence Oberman 
Cc: Bart Van Assche 
Cc: Guenter Roeck 
Cc: Jens Axboe 
Reported-by: Jens Axboe 
Signed-off-by: Ming Lei 
Signed-off-by: Martin K. Petersen

scsi: hpsa: limit transfer length to 1MB, not 512kB

2018-08-27T16:26:10+00:00

e2c7b43 was supposed to limit transfer length to 1MB, but got the unit of
max_sectors wrong.

Fixes: e2c7b433f729 ("scsi: hpsa: limit transfer length to 1MB")
Signed-off-by: Martin Wilck 
Signed-off-by: Martin K. Petersen

scsi: lpfc: Correct MDS diag and nvmet configuration

2018-08-27T16:26:10+00:00

A recent change added some MDS processing in the lpfc_drain_txq routine
that relies on the fcp_wq being allocated. For nvmet operation the fcp_wq
is not allocated because it can only be an nvme-target.  When the original
MDS support was added LS_MDS_LOOPBACK was defined wrong, (0x16) it should
have been 0x10 (decimal value used for hex setting). This incorrect value
allowed MDS_LOOPBACK to be set simultaneously with LS_NPIV_FAB_SUPPORTED,
causing the driver to crash when it accesses the non-existent fcp_wq.

Correct the bad value setting for LS_MDS_LOOPBACK.

Fixes: 	ae9e28f36a6c  ("lpfc: Add MDS Diagnostic support.")
Cc:  # v4.12+
Signed-off-by: Dick Kennedy 
Signed-off-by: James Smart 
Tested-by: Ewan D. Milne 
Signed-off-by: Martin K. Petersen

scsi: lpfc: Default fdmi_on to on

2018-08-27T16:26:10+00:00

Change default behavior for fdmi registration to on.

[mkp: patch was mangled]

Signed-off-by: Dick Kennedy 
Signed-off-by: James Smart 
Signed-off-by: Martin K. Petersen

scsi: csiostor: fix incorrect port capabilities

2018-08-27T16:26:10+00:00

 - use be32_to_cpu() instead of ntohs() for 32 bit port capabilities.

 - add a new function fwcaps32_to_caps16() to convert 32 bit port
   capabilities to 16 bit port capabilities.

Signed-off-by: Varun Prakash 
Signed-off-by: Martin K. Petersen

scsi: csiostor: add a check for NULL pointer after kmalloc()

2018-08-27T16:26:10+00:00

Reported-by: Colin Ian King 
Signed-off-by: Varun Prakash 
Signed-off-by: Martin K. Petersen

scsi: core: Update SCSI_MQ_DEFAULT help text to match default

2018-08-27T16:26:10+00:00

The default was changed, but the help text was not updated.

Fix grammar (s/the option/this option/) while at it.

[mkp: drop "new" as suggested by John Garry]

Fixes: d5038a13eca72fb2 ("scsi: core: switch to scsi-mq by default")
Signed-off-by: Geert Uytterhoeven 
Reviewed-by: Ming Lei 
Signed-off-by: Martin K. Petersen