linux.git/drivers/scsi/sd.c, branch v5.13

scsi: sd: Call sd_revalidate_disk() for ioctl(BLKRRPART)

2021-06-23T02:02:20+00:00

While the disk state has nothing to do with partitions, BLKRRPART is used
to force a full revalidate after things like a disk format for historical
reasons. Restore that behavior.

Link: https://lore.kernel.org/r/20210617115504.1732350-1-hch@lst.de
Fixes: 471bd0af544b ("sd: use bdev_check_media_change")
Reported-by: Xiang Chen 
Tested-by: Xiang Chen 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Martin K. Petersen

scsi: sd: Introduce a new local variable in sd_check_events()

2021-04-16T02:44:41+00:00

Instead of using 'retval' to represent first a SCSI status and later
whether or not a disk change event occurred, introduce a new variable for
the latter purpose.

Link: https://lore.kernel.org/r/20210415220826.29438-17-bvanassche@acm.org
Cc: Christoph Hellwig 
Cc: Johannes Thumshirn 
Cc: Hannes Reinecke 
Cc: Daniel Wagner 
Signed-off-by: Bart Van Assche 
Signed-off-by: Martin K. Petersen

scsi: sd: Fix function name in header

2021-03-19T03:35:54+00:00

Fixes the following W=1 kernel build warning(s):

 drivers/scsi/sd.c:1537: warning: expecting prototype for sd_ioctl(). Prototype was for sd_ioctl_common() instead

Link: https://lore.kernel.org/r/20210317091230.2912389-7-lee.jones@linaro.org
Cc: "James E.J. Bottomley" 
Cc: "Martin K. Petersen" 
Cc: Drew Eckhardt 
Cc: Eric Youngdale 
Cc: Jirka Hanika 
Cc: Richard Gooch 
Cc: Torben Mathiasen 
Cc: Alex Davis 
Cc: Douglas Gilbert 
Cc: Badari Pulavarty 
Cc: willy@debian.org
Cc: Kurt Garloff 
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones 
Signed-off-by: Martin K. Petersen

scsi: sd: Fix Opal support

2021-02-23T03:39:44+00:00

The SCSI core has been modified recently such that it only processes PM
requests if rpm_status != RPM_ACTIVE. Since some Opal requests are
submitted while rpm_status != RPM_ACTIVE, set flag RQF_PM for Opal
requests.

See also https://bugzilla.kernel.org/show_bug.cgi?id=211227.

[mkp: updated sha for PM patch]

Link: https://lore.kernel.org/r/20210222021042.3534-1-bvanassche@acm.org
Fixes: d80210f25ff0 ("sd: add support for TCG OPAL self encrypting disks")
Fixes: e6044f714b25 ("scsi: core: Only process PM requests if rpm_status != RPM_ACTIVE")
Cc: chriscjsus@yahoo.com
Cc: Jens Axboe 
Cc: Alan Stern 
Cc: stable@vger.kernel.org
Reported-by: chriscjsus@yahoo.com
Tested-by: chriscjsus@yahoo.com
Reviewed-by: Christoph Hellwig 
Signed-off-by: Bart Van Assche 
Signed-off-by: Martin K. Petersen

scsi: sd: Warn if unsupported ZBC device is probed

2021-02-09T02:11:32+00:00

In sd_probe(), print a warning if CONFIG_BLK_DEV_ZONED is disabled and a
TYPE_ZBC device is found. While at it, use IS_ENABLED() to test if
CONFIG_BLK_DEV_ZONED is enabled instead using of a #ifdef.

Link: https://lore.kernel.org/r/20210128055658.530133-1-damien.lemoal@wdc.com
Signed-off-by: Damien Le Moal 
Signed-off-by: Martin K. Petersen

scsi: sd: Remove obsolete variable in sd_remove()

2021-01-06T04:46:33+00:00

Commit 996e509bbc95 ("sd: use __register_blkdev to avoid a modprobe for an
unregistered dev_t") removed blk_register_region(devt, ...) in sd_remove()
and since then, devt is unused in sd_remove().

Hence, make W=1 warns:

  drivers/scsi/sd.c:3516:8:
      warning: variable 'devt' set but not used [-Wunused-but-set-variable]

Simply remove this obsolete variable.

[mkp: fixed commit sha]

Link: https://lore.kernel.org/r/20201214095424.12479-1-lukas.bulwahn@gmail.com
Reviewed-by: Christoph Hellwig 
Reviewed-by: Nathan Chancellor 
Acked-by: Martin K. Petersen 
Signed-off-by: Lukas Bulwahn 
Signed-off-by: Martin K. Petersen

scsi: sd: Suppress spurious errors when WRITE SAME is being disabled

2021-01-06T04:45:51+00:00

The block layer code will split a large zeroout request into multiple bios
and if WRITE SAME is disabled because the storage device reports that it
does not support it (or support the length used), we can get an error
message from the block layer despite the setting of RQF_QUIET on the first
request.  This is because more than one request may have already been
submitted.

Fix this by setting RQF_QUIET when BLK_STS_TARGET is returned to fail the
request early, we don't need to log a message because we did not actually
submit the command to the device, and the block layer code will handle the
error by submitting individual write bios.

Link: https://lore.kernel.org/r/20201207221021.28243-1-emilne@redhat.com
Reviewed-by: Christoph Hellwig 
Signed-off-by: Ewan D. Milne 
Signed-off-by: Martin K. Petersen

block: remove the update_bdev parameter to set_capacity_revalidate_and_notify

2020-11-16T15:34:14+00:00

The update_bdev argument is always set to true, so remove it.  Also
rename the function to the slighly less verbose set_capacity_and_notify,
as propagating the disk size to the block device isn't really
revalidation.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Hannes Reinecke 
Reviewed-by: Petr Vorel 
Signed-off-by: Jens Axboe

sd: update the bdev size in sd_revalidate_disk

2020-11-16T15:34:14+00:00

This avoids the extra call to revalidate_disk_size in sd_rescan and
is otherwise a no-op because the size did not change, or we are in
the probe path.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Hannes Reinecke 
Acked-by: Martin K. Petersen 
Signed-off-by: Jens Axboe

sd: use __register_blkdev to avoid a modprobe for an unregistered dev_t

2020-11-16T15:14:30+00:00

Switch from using blk_register_region to the probe callback passed to
__register_blkdev to disable the request_module call for an unclaimed
dev_t in the SD majors.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Hannes Reinecke 
Acked-by: Martin K. Petersen 
Signed-off-by: Jens Axboe