linux.git/drivers/scsi/sd.c, branch v3.17

sd: fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout

2014-07-25T21:16:42+00:00

Commit ID: 7e660100d85af860e7ad763202fff717adcdaacd added code to derive the
FLUSH_TIMEOUT from the basic I/O timeout. However, this patch did not use the
basic I/O timeout of the device. Fix this bug.

Signed-off-by: K. Y. Srinivasan 
Reviewed-by: James Bottomley 
Signed-off-by: Christoph Hellwig

scsi: add a blacklist flag which enables VPD page inquiries

2014-07-25T21:16:41+00:00

Despite supporting modern SCSI features some storage devices continue to
claim conformance to an older version of the SPC spec. This is done for
compatibility with legacy operating systems.

Linux by default will not attempt to read VPD pages on devices that
claim SPC-2 or older. Introduce a blacklist flag that can be used to
trigger VPD page inquiries on devices that are known to support them.

Reported-by: KY Srinivasan 
Tested-by: KY Srinivasan 
Reviewed-by: KY Srinivasan 
Signed-off-by: Martin K. Petersen 
CC: 
Signed-off-by: Christoph Hellwig

scsi: move the writeable field from struct scsi_device to struct scsi_cd

2014-07-25T21:16:41+00:00

We currently set the field in common code based on the device type,
but then only use it in the cdrom driver which also overrides the
value previously set in the generic code.

Just leave this entirely to the CDROM driver to make everyones life
simpler.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Hannes Reinecke 
Reviewed-by: Martin K. Petersen

sd: split sd_init_command

2014-07-17T20:16:29+00:00

Factor out a function to initialize regular read/write commands and leave
sd_init_command as a simple dispatcher to the different prepare routines.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Martin K. Petersen 
Reviewed-by: Hannes Reinecke

sd: retry discard commands

2014-07-17T20:16:28+00:00

Currently cmd->allowed is initialized from rq->retries for discard
commands, but retries is always 0 for non-BLOCK_PC requests.  Set it
to the standard number of retries instead.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Martin K. Petersen 
Reviewed-by: Hannes Reinecke

sd: retry write same commands

2014-07-17T20:16:27+00:00

Currently cmd->allowed is initialized from rq->retries for write same
commands, but retries is always 0 for non-BLOCK_PC requests.  Set it
to the standard number of retries instead.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Martin K. Petersen 
Reviewed-by: Hannes Reinecke

sd: don't use scsi_setup_blk_pc_cmnd for discard requests

2014-07-17T20:16:26+00:00

Simplify handling of discard requests by setting up the command directly
instead of initializing request fields and then calling
scsi_setup_blk_pc_cmnd to propagate the information into the command.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Martin K. Petersen 
Reviewed-by: Hannes Reinecke

sd: don't use scsi_setup_blk_pc_cmnd for write same requests

2014-07-17T20:12:47+00:00

Simplify handling of write same requests by setting up the command directly
instead of initializing request fields and then calling
scsi_setup_blk_pc_cmnd to propagate the information into the command.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Martin K. Petersen 
Reviewed-by: Webb Scales

sd: don't use scsi_setup_blk_pc_cmnd for flush requests

2014-07-17T20:12:33+00:00

Simplify handling of flush requests by setting up the command directly
instead of initializing request fields and then calling
scsi_setup_blk_pc_cmnd to propagate the information into the command.

Also rename scsi_setup_flush_cmnd to sd_setup_flush_cmnd for consistency.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Martin K. Petersen 
Reviewed-by: Hannes Reinecke

scsi: set sc_data_direction in common code

2014-07-17T20:11:41+00:00

The data direction fiel in the SCSI command is derived only from the block
request structure.  Move setting it up into common code instead of
duplicating it in the ULDs.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Martin K. Petersen 
Reviewed-by: Hannes Reinecke