linux.git/drivers/scsi/libsas, branch v5.19

scsi: libsas: Refactor sas_ata_hard_reset()

2022-05-20T00:16:25+00:00

Create function sas_ata_wait_after_reset() from sas_ata_hard_reset() as
some LLDDs may want to check for a remote ATA phy is up after reset.

Link: https://lore.kernel.org/r/1652354134-171343-2-git-send-email-john.garry@huawei.com
Tested-by: Yihang Li 
Reviewed-by: Xiang Chen 
Signed-off-by: John Garry 
Signed-off-by: Martin K. Petersen

scsi: hisi_sas: Use libsas internal abort support

2022-03-15T03:33:24+00:00

Use the common libsas internal abort functionality.

In addition, this driver has special handling for internal abort timeouts -
specifically whether to reset the controller in that instance, so extend
the API for that.

Timeout is now increased to 20 * Hz from 6 * Hz.

We also retry for failure now, but this should not make a difference.

Link: https://lore.kernel.org/r/1647001432-239276-5-git-send-email-john.garry@huawei.com
Tested-by: Damien Le Moal 
Acked-by: Jack Wang 
Signed-off-by: John Garry 
Signed-off-by: Martin K. Petersen

scsi: libsas: Add sas_execute_internal_abort_dev()

2022-03-15T03:33:23+00:00

Add support for a "device" variant of internal abort, which will abort all
pending I/Os for a specific device.

Link: https://lore.kernel.org/r/1647001432-239276-3-git-send-email-john.garry@huawei.com
Tested-by: Damien Le Moal 
Acked-by: Jack Wang 
Signed-off-by: John Garry 
Signed-off-by: Martin K. Petersen

scsi: libsas: Add sas_execute_internal_abort_single()

2022-03-15T03:33:23+00:00

The internal abort feature is common to hisi_sas and pm8001 HBAs, and the
driver support is similar also, so add a common handler.

Two modes of operation will be supported:

 - single: Abort a single tagged command

 - device: Abort all commands associated with a specific domain device

A new protocol is added, SAS_PROTOCOL_INTERNAL_ABORT, so the common queue
command API may be re-used.

Only add "single" support as a first step.

Link: https://lore.kernel.org/r/1647001432-239276-2-git-send-email-john.garry@huawei.com
Tested-by: Damien Le Moal 
Acked-by: Jack Wang 
Signed-off-by: John Garry 
Signed-off-by: Martin K. Petersen

scsi: libsas: Clean up sas_form_port()

2022-03-02T04:56:27+00:00

Sparse throws a warning about context imbalance ("different lock contexts
for basic block") in sas_form_port() as it gets confused with the fact that
a port is locked within one of the two search loops and unlocked afterward
outside of the search loops once the phy is added to the port. Since this
code is not easy to follow, improve it by factoring out the code adding the
phy to the port once the port is locked into the helper function
sas_form_port_add_phy(). This helper can then be called directly within the
port search loops, avoiding confusion and clearing the sparse warning.

Link: https://lore.kernel.org/r/20220228094857.557329-1-damien.lemoal@opensource.wdc.com
Reviewed-by: John Garry 
Signed-off-by: Damien Le Moal 
Signed-off-by: Martin K. Petersen

scsi: libsas: Use bool for queue_work() return code

2022-02-28T02:48:30+00:00

Function queue_work() returns a bool, so use a bool to hold this value for
the return code from callers, which should make the code a tiny bit more
clear.

Also take this opportunity to condense the code of the those callers, such
as sas_queue_work(), as suggested by Damien.

Link: https://lore.kernel.org/r/1645786656-221630-3-git-send-email-john.garry@huawei.com
Reviewed-by: Damien Le Moal 
Signed-off-by: John Garry 
Signed-off-by: Martin K. Petersen

scsi: libsas: Make sas_notify_{phy,port}_event() return void

2022-02-28T02:48:29+00:00

Nobody checks the return codes, so make them return void. Indeed, if the
LLDD cannot send an event, nothing much can be done in the LLDD about it.

Also remove prototype for sas_notify_phy_event() in sas_internal.h, which
should not be there.

Link: https://lore.kernel.org/r/1645786656-221630-2-git-send-email-john.garry@huawei.com
Reviewed-by: Xiang Chen 
Reviewed-by: Damien Le Moal 
Signed-off-by: John Garry 
Signed-off-by: Martin K. Petersen

scsi: libsas: Simplify sas_ata_qc_issue() detection of NCQ commands

2022-02-23T02:31:20+00:00

To detect if a command is NCQ, there is no need to test all possible NCQ
command codes. Instead, use ata_is_ncq() to test the command protocol.

Link: https://lore.kernel.org/r/20220220031810.738362-24-damien.lemoal@opensource.wdc.com
Reviewed-by: John Garry 
Signed-off-by: Damien Le Moal 
Signed-off-by: Martin K. Petersen

scsi: libsas: Fix sas_ata_qc_issue() handling of NCQ NON DATA commands

2022-02-23T02:31:16+00:00

To detect for the DMA_NONE (no data transfer) DMA direction,
sas_ata_qc_issue() tests if the command protocol is ATA_PROT_NODATA.  This
test does not include the ATA_CMD_NCQ_NON_DATA command as this command
protocol is defined as ATA_PROT_NCQ_NODATA (equal to ATA_PROT_FLAG_NCQ) and
not as ATA_PROT_NODATA.

To include both NCQ and non-NCQ commands when testing for the DMA_NONE DMA
direction, use "!ata_is_data()".

Link: https://lore.kernel.org/r/20220220031810.738362-2-damien.lemoal@opensource.wdc.com
Fixes: 176ddd89171d ("scsi: libsas: Reset num_scatter if libata marks qc as NODATA")
Cc: stable@vger.kernel.org
Reviewed-by: John Garry 
Reviewed-by: Jack Wang 
Signed-off-by: Damien Le Moal 
Signed-off-by: Martin K. Petersen

scsi: libsas: Add sas_execute_ata_cmd()

2022-02-23T02:11:02+00:00

Add a function to execute an ATA command using the TMF code, and use in the
hisi_sas driver. That driver needs to be able to issue the command on a
specific phy, so add an interface for that.

With that, hisi_sas_exec_internal_tmf_task() may be deleted.

Link: https://lore.kernel.org/r/1645534259-27068-19-git-send-email-john.garry@huawei.com
Tested-by: Yihang Li 
Tested-by: Damien Le Moal 
Reviewed-by: Christoph Hellwig 
Signed-off-by: John Garry 
Signed-off-by: Martin K. Petersen