linux.git/drivers/scsi/libfc, branch v2.6.31

[SCSI] libfc: fix a circular locking warning during sending RRQ

2009-07-30T13:50:02+00:00

Currently the fc_exch_rrq is called with fc_exch's ex_lock held.
The fc_exch_rrq allocates new exch and that requires taking
ex_lock again after EM lock. This locking order causes warning,
see more details on this warning at :-

 http://www.open-fcoe.org/pipermail/devel/2009-July/003251.html

This patch fixes this by dropping the ex_lock before calling
fc_exch_rrq().

The fc_exch_rrq needs to grab ex_lock lock again to schedule
RRQ retry and in the meanwhile fc_exch_reset could occur before
ex_lock is grabbed inside fc_exch_rrq. So to handle this case,
this patch adds additional check to detect fc_exch_reset after
ex_lock acquired and in case the fc_exch_reset occurred then
abandons the RRQ retry and releases the exch.

Signed-off-by: Vasu Dev 
Signed-off-by: Robert Love 
Signed-off-by: James Bottomley

libfc: Add runtime debugging with debug_logging module parameter

2009-06-21T16:07:08+00:00

This patch adds the /sys/module/libfc/parameters/debug_logging
file to sysfs as a module parameter. It accepts an integer
bitmask for logging. Currently it supports:

   bit
LSB 0 = general libfc debugging
    1 = lport debugging
    2 = disc debugging
    3 = rport debugging
    4 = fcp debugging
    5 = EM debugging
    6 = exch/seq debugging
    7 = scsi logging (mostly error handling)

the other bits are not used at this time.

The patch converts all of the libfc source files to use
these new macros and removes the old FC_DBG macro.

Signed-off-by: Robert Love 
Signed-off-by: James Bottomley

[SCSI] libfc: Check if exchange is completed when receiving a sequence

2009-06-08T18:29:11+00:00

When a sequence is received in response to an exchange we issued previously,
we should check to see if the exchange has completed. If yes, the sequence
should be discarded. Since the exchange might be still in the completion
process, it should be untouched.

Signed-off-by: Steve Ma 
Signed-off-by: James Bottomley

[SCSI] libfc: use DID_ERROR when we have internall aborted command

2009-06-08T18:29:10+00:00

If we aborted a command, because it timed out we should not use
DID_ABORT. It will fail the command right away back to the upper
layer. We want to use something that indicated that the problem
did not complete normally, but it was not a fatal problem.

Signed-off-by: Mike Christie 
Signed-off-by: James Bottomley

[SCSI] libfc,fcoe,fnic: Separate rport and lport max retry counts

2009-05-23T20:44:18+00:00

This allows fnic to configure number of retries for lport and rport
separately.

Signed-off-by: Abhijeet Joglekar 
Acked-by: Robert Love 
Signed-off-by: James Bottomley

[SCSI] fcoe, libfc: fix function declarations to be ANSI-compliant

2009-05-20T22:21:15+00:00

Fix function declarations:

drivers/scsi/fcoe/fcoe.c:1356:28: warning: non-ANSI function declaration of function 'fcoe_dev_setup'
drivers/scsi/libfc/fc_rport.c:1293:20: warning: non-ANSI function declaration of function 'fc_setup_rport'
drivers/scsi/libfc/fc_rport.c:1302:23: warning: non-ANSI function declaration of function 'fc_destroy_rport'

[jejb: fixed wrong doc in comment noticed during inspection]
Signed-off-by: Randy Dunlap 
Signed-off-by: James Bottomley

[SCSI] libfc: Fix compilation warnings with allmodconfig

2009-04-27T15:19:31+00:00

When building with a .config generated from 'make allmodconfig'
some build warnings are generated. This patch corrects the warnings,
adds a FC_FID_NONE (= 0) enumeration for FC-IDs and cleans up one
variable naming to meet our variable naming conventions. For example,
fc_lport's should be named "lport," not "lp."

Signed-off-by: Robert Love 
Signed-off-by: James Bottomley

[SCSI] libfc: whenever queueing delete ev for rport, set state to NONE

2009-04-27T15:19:03+00:00

When a delete event is queued for an rport, set state to NONE so that no
other processing is done on the rport as it is being removed.

Signed-off-by: Abhijeet Joglekar 
Signed-off-by: Robert Love 
Signed-off-by: James Bottomley

[SCSI] libfc: Change state to NONE in fc_lport_destroy

2009-04-27T15:19:01+00:00

After lport_destroy, the local port should not be used again. Transition
to state NONE, any incoming frames or link up should not transition out
of this state since we are deleting exchange table and cleaning up the
local port. Also, mark link as down.

Signed-off-by: Abhijeet Joglekar 
Signed-off-by: Robert Love 
Signed-off-by: James Bottomley

[SCSI] libfc: During fabric logoff, flush the rport Q after logging off dns port

2009-04-27T15:19:00+00:00

We want to generate the rport queue event (from the logoff)
before flushing the queue otherwise the event may still be
in the queue when we logoff.

Signed-off-by: Abhijeet Joglekar 
Signed-off-by: Robert Love 
Signed-off-by: James Bottomley