linux.git/drivers/scsi/ipr.c, branch v3.19

ipr: wait for aborted command responses

2015-01-19T09:46:20+00:00

Fixes a race condition in abort handling that was injected
when multiple interrupt support was added. When only a single
interrupt is present, the adapter guarantees it will send
responses for aborted commands prior to the response for the
abort command itself. With multiple interrupts, these responses
generally come back on different interrupts, so we need to
ensure the abort thread waits until the aborted command is
complete so we don't perform a double completion. This race
condition was being hit frequently in environments which
were triggering command timeouts, which was resulting in
a double completion causing a kernel oops.

Cc: 
Signed-off-by: Brian King 
Reviewed-by: Wendy Xiong 
Tested-by: Wendy Xiong 
Signed-off-by: Christoph Hellwig

ipr: set scsi_level correctly for disk arrays

2014-12-15T12:34:29+00:00

Set the scsi_level correctly for disk arrays such
that things like the rotational field get set
properly by sd.c.

Signed-off-by: Brian King 
Reviewed-by: Wen Xiong
Signed-off-by: Christoph Hellwig

ipr: add support for async scanning to speed up boot

2014-12-15T12:34:28+00:00

Switch device scanning logic in the ipr driver to use
the async scan API. This speeds up boot times, particularly
on large systems.

Signed-off-by: Brian King 
Reviewed-by: Wen Xiong
Signed-off-by: Christoph Hellwig

scsi: remove scsi_get_tag_type

2014-12-04T08:55:46+00:00

Both remaining users are better of just checking sdev->simple_tags
directly.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Bart Van Assche 
Reviewed-by: Martin K. Petersen

scsi: remove ->change_queue_type method

2014-12-04T08:55:45+00:00

Since we got rid of ordered tag support in 2010 the prime use case of
switching on and off ordered tags has been obsolete.  The other function
of enabling/disabling tagging entirely has only been correctly implemented
by the 53c700 driver and isn't generally useful.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Bart Van Assche 
Reviewed-by: Martin K. Petersen

scsi: drop reason argument from ->change_queue_depth

2014-11-24T13:45:27+00:00

Drop the now unused reason argument from the ->change_queue_depth method.
Also add a return value to scsi_adjust_queue_depth, and rename it to
scsi_change_queue_depth now that it can be used as the default
->change_queue_depth implementation.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Mike Christie 
Reviewed-by: Hannes Reinecke

ipr: set coherent DMA mask

2014-11-12T10:32:00+00:00

Use dma_set_mask_and_coherent() to set both the DMA and coherent
DMA mask.

Signed-off-by: Anton Blanchard 
Signed-off-by: Brian King 
Signed-off-by: Christoph Hellwig

ipr: convert to generic DMA API

2014-11-12T10:32:00+00:00

Even though the ipr driver is only used on PCI, convert it
to use the generic DMA API.

Signed-off-by: Anton Blanchard 
Signed-off-by: Brian King 
Signed-off-by: Christoph Hellwig

scsi: don't set tagging state from scsi_adjust_queue_depth

2014-11-12T10:19:43+00:00

Remove the tagged argument from scsi_adjust_queue_depth, and just let it
handle the queue depth.  For most drivers those two are fairly separate,
given that most modern drivers don't care about the SCSI "tagged" status
of a command at all, and many old drivers allow queuing of multiple
untagged commands in the driver.

Instead we start out with the ->simple_tags flag set before calling
->slave_configure, which is how all drivers actually looking at
->simple_tags except for one worke anyway.  The one other case looks
broken, but I've kept the behavior as-is for now.

Except for that we only change ->simple_tags from the ->change_queue_type,
and when rejecting a tag message in a single driver, so keeping this
churn out of scsi_adjust_queue_depth is a clear win.

Now that the usage of scsi_adjust_queue_depth is more obvious we can
also remove all the trivial instances in ->slave_alloc or ->slave_configure
that just set it to the cmd_per_lun default.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Mike Christie 
Reviewed-by: Hannes Reinecke 
Reviewed-by: Martin K. Petersen

scsi: always assign block layer tags if enabled

2014-11-12T10:19:43+00:00

Allow a driver to ask for block layer tags by setting .use_blk_tags in the
host template, in which case it will always see a valid value in
request->tag, similar to the behavior when using blk-mq.  This means even
SCSI "untagged" commands will now have a tag, which is especially useful
when using a host-wide tag map.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Mike Christie 
Reviewed-by: Martin K. Petersen 
Reviewed-by: Hannes Reinecke