linux.git/drivers/scsi/device_handler, branch v4.5-rc2

scsi_dh_alua: Remove stale variables

2015-12-08T01:11:25+00:00

With commit 83ea0e5e3501 ("scsi_dh_alua: use scsi_vpd_tpg_id()") these
variables became obsolete, but weren't removed.

[mkp: Fixed checkpatch warning]

Signed-off-by: Hannes Reinecke 
Reviewed-by: Johannes Thumshirn 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Martin K. Petersen

scsi_dh_alua: use scsi_vpd_tpg_id()

2015-12-02T21:59:01+00:00

Use the common function 'scsi_vpd_tpg_id()' instead of open-coding
it in scsi_dh_alua.

[mkp: Applied by hand]

Signed-off-by: Hannes Reinecke 
Reviewed-by: Johannes Thumshirn 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Martin K. Petersen

scsi_dh_alua: simplify sense code handling

2015-12-02T21:38:20+00:00

Most sense code is already handled in the generic
code, so we shouldn't be adding special cases here.
However, when doing so we need to check for
unit attention whenever we're sending an internal
command.

Signed-off-by: Hannes Reinecke 
Reviewed-by: Ewan Milne 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

scsi_dh_alua: rework alua_check_tpgs() to return the tpgs mode

2015-12-02T21:37:55+00:00

Instead of returning an error code in alua_check_tpgs() we should
rather return the tpgs mode directly and have a cleaner syntax.

Signed-off-by: Hannes Reinecke 
Reviewed-by: Johannes Thumshirn 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Martin K. Petersen

scsi_dh_alua: use unaligned access macros

2015-12-02T21:37:14+00:00

Use 'get_unaligned_XX' and 'put_unaligned_XX' instead of
open-coding it.

Signed-off-by: Hannes Reinecke 
Reviewed-by: Martin K. Petersen 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

scsi_dh_alua: use flag for RTPG extended header

2015-12-02T21:36:44+00:00

We should be using a flag when RTPG extended header is not
supported, that saves us sending RTPG twice for older arrays.

Signed-off-by: Hannes Reinecke 
Reviewed-by: Bart Van Assche 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Martin K. Petersen 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Martin K. Petersen

scsi_dh_alua: fixup description of stpg_endio()

2015-12-02T21:35:31+00:00

Fixup copy-and-paste error in the description of stpg_endio().

Signed-off-by: Hannes Reinecke 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Johannes Thumshirn 
Reviewed-by: Martin K. Petersen 
Signed-off-by: Martin K. Petersen

scsi_dh_alua: return standard SCSI return codes in submit_rtpg

2015-12-02T21:34:55+00:00

Fixup submit_rtpg() to always return a standard SCSI return code.

Signed-off-by: Hannes Reinecke 
Reviewed-by: Ewan Milne 
Reviewed-by: Johannes Thumshirn 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Martin K. Petersen

scsi_dh_alua: use standard logging functions

2015-12-02T21:34:26+00:00

Use standard logging functions instead of hand-crafted ones.

Signed-off-by: Hannes Reinecke 
Reviewed-by: Ewan Milne 
Reviewed-by: Bart Van Assche 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Martin K. Petersen

scsi_dh_alua: sanitze sense code handling

2015-12-02T21:33:21+00:00

The only check for a valid sense code is calling scsi_normalize_sense()
and check the return value. So drop the pointless checks and rely on
scsi_normalize_sense() to figure out if the sense code is valid.
With that we can also remove the 'senselen' field.

Signed-off-by: Hannes Reinecke 
Reviewed-by: Johannes Thumshirn 
Reviewed-by: Bart van Assche 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Martin K. Petersen