linux.git/drivers/scsi/constants.c, branch v4.9

scsi: fix upper bounds check of sense key in scsi_sense_key_string()

2016-08-16T04:49:32+00:00

Commit 655ee63cf371 ("scsi constants: command, sense key + additional
sense string") added a "Completed" sense string with key 0xF to
snstext[], but failed to updated the upper bounds check of the sense key
in scsi_sense_key_string().

Fixes: 655ee63cf371 ("[SCSI] scsi constants: command, sense key + additional sense strings")
Cc:  # v3.12+
Signed-off-by: Tyrel Datwyler 
Reviewed-by: Bart Van Assche 
Signed-off-by: Martin K. Petersen

scsi: reduce CONFIG_SCSI_CONSTANTS=y impact by 8k

2016-04-11T20:57:09+00:00

On 64 bit, struct error_info has 6 bytes of padding, which amounts to
over 4k of wasted space in the additional[] array. We could easily get
rid of that by instead using separate arrays for the codes and the
pointers. However, we can do even better than that and save an
additional 6 bytes per entry: In the table, just store the sizeof()
the corresponding string literal. The cumulative sum of these is then
the appropriate offset into additional_text, which is built from the
concatenation (with '\0's inbetween) of the strings.

$ scripts/bloat-o-meter /tmp/vmlinux vmlinux
add/remove: 0/0 grow/shrink: 1/1 up/down: 24/-8488 (-8464)
function                                     old     new   delta
scsi_extd_sense_format                       136     160     +24
additional                                 11312    2824   -8488

The Kconfig help text used to say that CONFIG_SCSI_CONSTANTS=y costs
around 75 KB, but that was a little exaggerated. The actual number was
closer to 44K, and 36K with this patch.

Signed-off-by: Rasmus Villemoes 
Reviewed-by: Hannes Reinecke 
Tested-by: Douglas Gilbert 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Martin K. Petersen

scsi: move Additional Sense Codes to separate file

2016-04-11T20:57:09+00:00

This is a purely mechanical move of the list of additional sense codes
to a separate file, in preparation for reducing the impact of choosing
CONFIG_SCSI_CONSTANTS=y by about 8k.

Signed-off-by: Rasmus Villemoes 
Reviewed-by: Hannes Reinecke 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Martin K. Petersen

scsi: make some Additional Sense strings more grep'able

2016-04-11T20:57:09+00:00

There's little point in breaking these strings over multiple lines.

Signed-off-by: Rasmus Villemoes 
Reviewed-by: Hannes Reinecke 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Martin K. Petersen

scsi: Conditionally compile in constants.c

2015-01-09T14:44:31+00:00

Instead of having constants.c littered with ifdef statements we should
be moving dummy functions into the header and condintionally compile in
constants.c if selected. And update the Kconfig description to reflect
the actual size difference.

Suggested-by: Christoph Hellwig 
Tested-by: Robert Elliott 
Reviewed-by: Robert Elliott 
Signed-off-by: Hannes Reinecke 
Signed-off-by: Christoph Hellwig

scsi: use per-cpu buffer for formatting scsi_print_result()

2015-01-09T14:44:31+00:00

Convert scsi_print_result() to use the per-cpu buffer for decoding the
command result and disposition.

Tested-by: Robert Elliott 
Reviewed-by: Robert Elliott 
Signed-off-by: Hannes Reinecke 
Signed-off-by: Christoph Hellwig

scsi: use per-cpu buffer for formatting sense

2015-01-09T14:44:30+00:00

Convert sense buffer logging to use the per-cpu buffer to avoid line
breakup.

Tested-by: Robert Elliott 
Reviewed-by: Robert Elliott 
Signed-off-by: Hannes Reinecke 
Signed-off-by: Christoph Hellwig

scsi: use external buffer for command logging

2015-01-09T14:44:29+00:00

Use an external buffer for __scsi_print_command() and move command
logging over to use the per-cpu logging buffer.  With that we can
guarantee the command always will always be formatted in one line.
So we can even print out a variable length command correctly across
several lines. Finally rename __scsi_print_command() to
__scsi_format_comment() to better reflect the functionality.

Tested-by: Robert Elliott 
Reviewed-by: Robert Elliott 
Signed-off-by: Hannes Reinecke 
Signed-off-by: Christoph Hellwig

scsi: asc/ascq codes, sync to T10 2014/12/21

2015-01-09T14:44:14+00:00

The last time these SCSI asc/ascq codes were synced with T10 was
2013/06/05.  Sync the SCSI ASC/ASCQ number to string tables with those
found at http://www.t10.org/lists/asc-num.txt dated 2014/12/21.

Signed-off-by: Douglas Gilbert 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Christoph Hellwig

scsi: set fmt to NULL scsi_extd_sense_format() by default

2014-12-02T17:26:52+00:00

One of the two callers passes an unintialized pointer as "fmt" and
expects it to be set to NULL if there is no format string.  Let's make
this function work as expected.

Fixes: d811b848ebb7 ('scsi: use sdev as argument for sense code printing')
Signed-off-by: Dan Carpenter 
Reviewed-by: James Bottomley 
Signed-off-by: Christoph Hellwig