linux.git/drivers/scsi/constants.c, branch v3.19

scsi: set fmt to NULL scsi_extd_sense_format() by default

2014-12-02T17:26:52+00:00

One of the two callers passes an unintialized pointer as "fmt" and
expects it to be set to NULL if there is no format string.  Let's make
this function work as expected.

Fixes: d811b848ebb7 ('scsi: use sdev as argument for sense code printing')
Signed-off-by: Dan Carpenter 
Reviewed-by: James Bottomley 
Signed-off-by: Christoph Hellwig

scsi: add SPC-3 command definitions

2014-11-24T19:01:44+00:00

SPC-3 defines SERVICE ACTION IN(12), SERVICE_ACTION OUT(12),
SERVICE ACTION OUT(16), and SERVICE ACTION BIDIRECTIONAL.
And READ MEDIA SERIAL NUMBER has long since been deprecated.
So update callers to refer to the new cdb name.

Signed-off-by: Hannes Reinecke 
Tested-by: Robert Elliott 
Reviewed-by: Robert Elliott 
Signed-off-by: Christoph Hellwig

scsi: rename SERVICE_ACTION_IN to SERVICE_ACTION_IN_16

2014-11-24T19:01:40+00:00

SPC-3 defines SERVICE ACTION IN(12) and SERVICE ACTION IN(16).
So rename SERVICE_ACTION_IN to SERVICE_ACTION_IN_16 to be
consistent with SPC and to allow for better distinction.

Signed-off-by: Hannes Reinecke 
Tested-by: Robert Elliott 
Reviewed-by: Robert Elliott 
Signed-off-by: Christoph Hellwig

scsi: simplify scsi_log_(send|completion)

2014-11-12T10:16:05+00:00

Simplify scsi_log_(send|completion) by externalizing
scsi_mlreturn_string() and always print the command address.

Signed-off-by: Hannes Reinecke 
Reviewed-by: Robert Elliott 
Signed-off-by: Christoph Hellwig

scsi: remove scsi_show_result()

2014-11-12T10:16:05+00:00

Open-code scsi_print_result in sd.c, and cleanup logging to
not print duplicate informations.
Also remove the call to scsi_show_result() in ufshcd.c
to be consistent with other callers of scsi_execute().

With that we can remove scsi_show_result in constants.c

Signed-off-by: Hannes Reinecke 
Reviewed-by: Robert Elliott 
Signed-off-by: Christoph Hellwig

scsi: separate out scsi_(host|driver)byte_string()

2014-11-12T10:16:04+00:00

Export functions for later use.

Signed-off-by: Hannes Reinecke 
Reviewed-by: Robert Elliott 
Signed-off-by: Christoph Hellwig

scsi: repurpose the last argument from print_opcode_name()

2014-11-12T10:16:03+00:00

print_opcode_name() was only ever called with a '0' argument
from LLDDs and ULDs which were _not_ supporting variable length
CDBs, so the 'if' clause was never triggered.
Instead we should be using the last argument to specify
the cdb length to avoid accidental overflow when reading
the cdb buffer.

Signed-off-by: Hannes Reinecke 
Reviewed-by: Robert Elliott 
Signed-off-by: Christoph Hellwig

scsi: consolidate opcode lookup in scsi_opcode_sa_name()

2014-11-12T10:16:03+00:00

Consolidate the CDB opcode lookup in scsi_opcode_sa_name(),
so that we don't have to call several functions to figure
out the CDB opcode string.

Signed-off-by: Hannes Reinecke 
Reviewed-by: Robert Elliott 
Signed-off-by: Christoph Hellwig

scsi: merge print_opcode_name()

2014-11-12T10:16:03+00:00

Instead of having two versions of print_opcode_name() we
should be consolidating them into one version.

Signed-off-by: Hannes Reinecke 
Reviewed-by: Robert Elliott 
Signed-off-by: Christoph Hellwig

scsi: implement scsi_opcode_sa_name

2014-11-12T10:16:02+00:00

Implement a lookup array for SERVICE ACTION commands instead
of hardcoding it in a large switch statement.

Signed-off-by: Hannes Reinecke 
Reviewed-by: Robert Elliott 
Signed-off-by: Christoph Hellwig