linux.git/drivers/scsi/aacraid, branch v4.14

scsi: aacraid: Fix controller initialization failure

2017-10-17T03:17:52+00:00

This is a fix to an issue where the driver sends its periodic WELLNESS
command to the controller after the driver shut it down.This causes the
controller to crash. The window where this can happen is small, but it
can be hit at around 4 hours of constant resets.

Cc: 
Fixes: fbd185986eba (aacraid: Fix AIF triggered IOP_RESET)
Signed-off-by: Raghava Aditya Renukunta 
Reviewed-by: Dave Carroll 
Signed-off-by: Martin K. Petersen

scsi: aacraid: Add a small delay after IOP reset

2017-09-28T01:42:14+00:00

Commit 0e9973ed3382 ("scsi: aacraid: Add periodic checks to see IOP reset
status") changed the way driver checks if a reset succeeded. Now, after an
IOP reset, aacraid immediately start polling a register to verify the reset
is complete.

This behavior cause regressions on the reset path in PowerPC (at least).
Since the delay after the IOP reset was removed by the aforementioned patch,
the fact driver just starts to read a register instantly after the reset
was issued (by writing in another register) "corrupts" the reset procedure,
which ends up failing all the time.

The issue highly impacted kdump on PowerPC, since on kdump path we
proactively issue a reset in adapter (through the reset_devices kernel
parameter).

This patch (re-)adds a delay right after IOP reset is issued. Empirically
we measured that 3 seconds is enough, but for safety reasons we delay
for 5s (and since it was 30s before, 5s is still a small amount).

For reference, without this patch we observe the following messages
on kdump kernel boot process:

  [ 76.294] aacraid 0003:01:00.0: IOP reset failed
  [ 76.294] aacraid 0003:01:00.0: ARC Reset attempt failed
  [ 86.524] aacraid 0003:01:00.0: adapter kernel panic'd ff.
  [ 86.524] aacraid 0003:01:00.0: Controller reset type is 3
  [ 86.524] aacraid 0003:01:00.0: Issuing IOP reset
  [146.534] aacraid 0003:01:00.0: IOP reset failed
  [146.534] aacraid 0003:01:00.0: ARC Reset attempt failed

Fixes: 0e9973ed3382 ("scsi: aacraid: Add periodic checks to see IOP reset status")
Cc: stable@vger.kernel.org # v4.13+
Signed-off-by: Guilherme G. Piccoli 
Acked-by: Dave Carroll 
Signed-off-by: Martin K. Petersen

scsi: aacraid: error: testing array offset 'bus' after use

2017-09-16T01:46:07+00:00

Fix possible indexing array of bound for &aac->hba_map[bus][cid], where
bus and cid boundary check happens later.

Fixes: 0d643ff3c353 ("scsi: aacraid: use aac_tmf_callback for reset fib")
Signed-off-by: Nikola Pajkovsky 
Reviewed-by: Dave Carroll 
Signed-off-by: Martin K. Petersen

scsi: aacraid: Fix 2T+ drives on SmartIOC-2000

2017-09-15T19:49:43+00:00

The logic for supporting large drives was previously tied to 4Kn support
for SmartIOC-2000. As SmartIOC-2000 does not support volumes using 4Kn
drives, use the intended option flag AAC_OPT_NEW_COMM_64 to determine
support for volumes greater than 2T.

Cc: 
Signed-off-by: Dave Carroll 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Raghava Aditya Renukunta 
Signed-off-by: Martin K. Petersen

Merge branch 'fixes' into misc

2017-09-07T19:12:43+00:00

scsi: aacraid: report -ENOMEM to upper layer from aac_convert_sgraw2()

2017-08-31T02:02:23+00:00

aac_convert_sgraw2() kmalloc memory and return -1 on error, which should
be -ENOMEM. However, nobody is checking return value, so with this
change, -ENOMEM is propagated to upper layer.

Signed-off-by: Nikola Pajkovsky 
Reviewed-by: Raghava Aditya Renukunta 
Signed-off-by: Martin K. Petersen

scsi: aacraid: get rid of one level of indentation

2017-08-31T02:01:29+00:00

  unsigned long byte_count = 0;
  nseg = scsi_dma_map(scsicmd);
  if (nseg < 0)
     return nseg;
  if (nseg) {
     ...
  }
  return byte_count;

is equal to

  unsigned long byte_count = 0;
  nseg = scsi_dma_map(scsicmd);
  if (nseg <= 0)
     return nseg;
  ...
  return byte_count;

No other code has changed.

[mkp: fix checkpatch complaints]

Signed-off-by: Nikola Pajkovsky 
Reviewed-by: Raghava Aditya Renukunta 
Signed-off-by: Martin K. Petersen

scsi: aacraid: fix indentation errors

2017-08-31T01:56:00+00:00

fix stupid indent error, no rocket science here.

Signed-off-by: Nikola Pajkovsky 
Reviewed-by: Raghava Aditya Renukunta 
Signed-off-by: Martin K. Petersen

scsi: aacraid: Fix command send race condition

2017-08-30T01:34:04+00:00

This fixes a potential race condition observed on Power systems.

Several places throughout the aacraid driver call aac_fib_send or
similar to send a command to the aacraid adapter, then check the return
code to determine if the command was actually sent to the adapter, then
update the phase field in the scsi command scratch pad area to track
that the firmware now owns this command.  However, there is nothing that
ensures that by the time the aac_fib_send function returns and we go to
write to the scsi command, that the command hasn't already completed and
the scsi command has been freed.  This was causing random crashes in the
TCP stack which was tracked down to be caused by memory that had been a
struct request + scsi_cmnd being now used for an skbuff. Memory
poisoning was enabled in the kernel to debug this which showed that the
last owner of the memory that had been freed was aacraid and that it was
a struct request.  The memory that was corrupted was the exact data
pattern of AAC_OWNER_FIRMWARE and it was at the same offset that aacraid
writes, which is scsicmd->SCp.phase. The patch below resolves this
issue.

Cc: 
Signed-off-by: Brian King 
Tested-by: Wen Xiong 
Reviewed-by: Dave Carroll 
Signed-off-by: Martin K. Petersen

scsi: aacraid: Fix out of bounds in aac_get_name_resp

2017-08-17T00:01:31+00:00

We terminate the aac_get_name_resp on a byte that is outside the bounds
of the structure. Extend the return response by one byte to remove the
out of bounds reference.

Fixes: b836439faf04 ("aacraid: 4KB sector support")
Reported-by: Dan Carpenter 
Signed-off-by: David Carroll 
Signed-off-by: Raghava Aditya Renukunta 
Reviewed-by: Bart Van Assche 
Signed-off-by: Martin K. Petersen