linux.git/drivers/scsi/aacraid/commctrl.c, branch v2.6.31

[SCSI] Clean up my email address and use a single standard address for everything

2008-12-29T17:24:12+00:00

Signed-off-by: Alan Cox 
Signed-off-by: James Bottomley

[SCSI] aacraid: check pci_alloc_consistent errors

2008-12-29T17:24:11+00:00

We need to check the address that pci_alloc_consistent() returns since
it might fail.

When pci_alloc_consistent() fails, some IOMMUs set the dma_handle
argument to zero. So we can't use fibptr->hw_fib_pa directly here.

Signed-off-by: FUJITA Tomonori 
Cc: Aacraid List 
Signed-off-by: James Bottomley

[SCSI] aacraid: prevent copy_from_user() BUG!

2008-07-12T13:22:24+00:00

Seen:

	kernel BUG at arch/i386/lib/usercopy.c:872

under a 2.6.18-8.el5 kernel. Traced it to a garbage-in/garbage-out
ioctl condition in the aacraid driver.

Adaptec's special ioctl scb passthrough needs to check the validity of
the individual scatter gather count fields to the maximum the adapter
supports. Doing so will have the side effect of preventing
copy_from_user() from bugging out while populating the dma buffers.
This is a hardening effort, issue was triggered by an errant version
of the management tools and thus the BUG should not be seen in the
field.

[jejb: fixed up compile failure]
Signed-off-by: Mark Salyzyn 
Signed-off-by: James Bottomley

Convert asm/semaphore.h users to linux/semaphore.h

2008-04-19T02:22:54+00:00

Signed-off-by: Matthew Wilcox

[SCSI] aacraid: fib context lock for management ioctls (take 2)

2008-02-08T00:02:33+00:00

The first patch (a119ee8ee3045bf559d4cf02d72b112f3de2a15b) was a bit
too aggressive and nested the locks (!) unit testing was in
error. This patch was reverted by
203a512f0976e8ba85df36d76b40af6c80239121.

This new patch should fix the locks correctly.

Signed-off-by: Mark Salyzyn 
Signed-off-by: James Bottomley

[SCSI] Revert "[SCSI] aacraid: fib context lock for management ioctls"

2008-01-30T19:14:26+00:00

This reverts commit a119ee8ee3045bf559d4cf02d72b112f3de2a15b.

Adaptec found this was causing system lockups.

Signed-off-by: James Bottomley

[SCSI] aacraid: fib context lock for management ioctls

2008-01-25T15:25:22+00:00

Alan noticed the lack of locking surrounding the driver's dealings
with the fib context managed by the trio of ioctls that are used by
the RAID management applications to retrieve Adapter Initiated FIBs. I
merely expanded the fib lock to include the fib context. There have
been no field reports of any issues generally because the applications
are relatively static and do not come and go often enough to stress
this area. I bloated this patch a little with some space junk.

Signed-off-by: Mark Salyzyn 
Signed-off-by: James Bottomley

[SCSI] aacraid: remove pigs in space

2008-01-23T17:29:28+00:00

I was amazed at how much embedded space was present in the aacraid
driver source files. Just selected five files from the set to clean up
for now and the attached patch swelled to 73K in size!

- Removed trailing space or tabs
- Removed spaces embedded within tabs
- Replaced leading 8 spaces with tabs
- Removed spaces before )
- Removed ClusterCommand as it was unused (noticed it as one triggered by above)
- Replaced scsi_status comparison with 0x02, to compare against SAM_STATUS_CHECK_CONDITION.
- Replaced a long series of spaces with tabs
- Replaced some simple if...defined() with ifdef/ifndef

Signed-off-by: Mark Salyzyn 
Signed-off-by: James Bottomley

[SCSI] aacraid: fix multiple definition of automatic variable warning.

2008-01-23T17:29:20+00:00

The 'entry' automatic variable was defined at the top and within a
block that uses it, removed the definition from the block that uses
it. Some cosmetic changes were made while in the same file. This patch
should be inert.

Signed-off-by: Mark Salyzyn 
Signed-off-by: James Bottomley

fix abuses of ptrdiff_t

2007-10-29T14:41:33+00:00

Use of ptrdiff_t in places like

-                       if (!access_ok(VERIFY_WRITE, u_tmp->rx_buf, u_tmp->len))
+                       if (!access_ok(VERIFY_WRITE, (u8 __user *)
+                                               (ptrdiff_t) u_tmp->rx_buf,
+                                               u_tmp->len))

is wrong; for one thing, it's a bad C (it's what uintptr_t is for; in general
we are not even promised that ptrdiff_t is large enough to hold a pointer,
just enough to hold a difference between two pointers within the same object).
For another, it confuses the fsck out of sparse.

Use unsigned long or uintptr_t instead.  There are several places misusing
ptrdiff_t; fixed.

Signed-off-by: Al Viro 
Signed-off-by: Linus Torvalds