linux.git/drivers/s390/virtio, branch vsnprintf

s390/virtio_ccw: Fix dma_parm pointer not set up

2024-10-10T13:32:43+00:00

At least since commit 334304ac2bac ("dma-mapping: don't return errors
from dma_set_max_seg_size") setting up device.dma_parms is basically
mandated by the DMA API. As of now Channel (CCW) I/O in general does not
utilize the DMA API, except for virtio. For virtio-ccw however the
common virtio DMA infrastructure is such that most of the DMA stuff
hinges on the virtio parent device, which is a CCW device.

So lets set up the dma_parms pointer for the CCW parent device and hope
for the best!

Fixes: 334304ac2bac ("dma-mapping: don't return errors from dma_set_max_seg_size")
Reported-by: Marc Hartmayer 
Reviewed-by: Eric Farman 
Reviewed-by: Cornelia Huck 
Tested-by: Marc Hartmayer 
Link: https://lore.kernel.org/r/20241007201030.204028-1-pasic@linux.ibm.com
Signed-off-by: Halil Pasic 
Signed-off-by: Heiko Carstens

virtio: rename find_vqs_info() op to find_vqs()

2024-07-17T09:20:57+00:00

Since the original find_vqs() is no longer present, rename
find_vqs_info() back to find_vqs().

Signed-off-by: Jiri Pirko 
Message-Id: <20240708074814.1739223-10-jiri@resnulli.us>
Signed-off-by: Michael S. Tsirkin

virtio: convert find_vqs() op implementations to find_vqs_info()

2024-07-17T09:20:57+00:00

Convert existing find_vqs() transport implementations
to use find_vqs_info() config op.

Signed-off-by: Jiri Pirko 
Message-Id: <20240708074814.1739223-7-jiri@resnulli.us>
Signed-off-by: Michael S. Tsirkin

s390/virtio_ccw: Fix config change notifications

2024-06-17T19:49:01+00:00

Commit e3e9bda38e6d ("s390/virtio_ccw: use DMA handle from DMA API")
broke configuration change notifications for virtio-ccw by putting the
DMA address of *indicatorp directly into ccw->cda disregarding the fact
that if !!(vcdev->is_thinint) then the function
virtio_ccw_register_adapter_ind() will overwrite that ccw->cda value
with the address of the virtio_thinint_area so it can actually set up
the adapter interrupts via CCW_CMD_SET_IND_ADAPTER.  Thus we end up
pointing to the wrong object for both CCW_CMD_SET_IND if setting up the
adapter interrupts fails, and for CCW_CMD_SET_CONF_IND regardless
whether it succeeds or fails.

To fix this, let us save away the dma address of *indicatorp in a local
variable, and copy it to ccw->cda after the "vcdev->is_thinint" branch.

Fixes: e3e9bda38e6d ("s390/virtio_ccw: use DMA handle from DMA API")
Reported-by: Boqiao Fu 
Reported-by: Sebastian Mitterle 
Closes: https://issues.redhat.com/browse/RHEL-39983
Tested-by: Thomas Huth 
Reviewed-by: Eric Farman 
Signed-off-by: Halil Pasic 
Link: https://lore.kernel.org/r/20240611214716.1002781-1-pasic@linux.ibm.com
Signed-off-by: Vasily Gorbik

s390/virtio_ccw: avoid converting dma addresses / handles

2024-03-13T08:23:46+00:00

Instead of converting virtual to physical addresses with the virt_to_dma*()
functions, use dma addresses as provided by DMA API and only add offsets to
these addresses. This makes sure that address conversion is only done by
the DMA API.

Signed-off-by: Halil Pasic 
Reviewed-by: Eric Farman 
Signed-off-by: Heiko Carstens

s390/virtio_ccw: use DMA handle from DMA API

2024-03-13T08:23:46+00:00

Change and use ccw_device_dma_zalloc() so it returns a virtual address like
before, which can be used to access data. However also pass a new dma32_t
pointer type handle, which correlates to the returned virtual address.
This pointer is used to directly pass/set the DMA handle as returned by the
DMA API.

Signed-off-by: Halil Pasic 
Reviewed-by: Eric Farman 
Signed-off-by: Heiko Carstens

s390/virtio_ccw: fix virtual vs physical address confusion

2024-03-13T08:23:46+00:00

Fix virtual vs physical address confusion and use new dma types and helper
functions to allow for type checking. This does not fix a bug since virtual
and physical address spaces are currently the same.

Signed-off-by: Halil Pasic 
Reviewed-by: Eric Farman 
Signed-off-by: Heiko Carstens

s390/airq: remove lsi_mask from airq_struct

2023-08-30T09:03:28+00:00

Remove the field `lsi_mask` from `struct airq_struct` as it is not
utilized for any adapter interrupt, other than setting it to the default
value of 0xff.

Because nobody is using this functionality, all it does is cost a little
bit of time with each delivered adapter interrupt.

Reviewed-by: Michael Mueller 
Tested-by: Michael Mueller 
Acked-by: Peter Oberparleiter 
Signed-off-by: Benjamin Block 
Signed-off-by: Heiko Carstens

virtio: add VIRTIO_F_NOTIFICATION_DATA feature support

2023-04-21T07:02:35+00:00

According to VirtIO spec v1.2, VIRTIO_F_NOTIFICATION_DATA feature
indicates that the driver passes extra data along with the queue
notifications.

In a split queue case, the extra data is 16-bit available index. In a
packed queue case, the extra data is 1-bit wrap counter and 15-bit
available index.

Add support for this feature for MMIO, channel I/O and modern PCI
transports.

Signed-off-by: Viktor Prutyanov 
Acked-by: Jason Wang 
Reviewed-by: Xuan Zhuo 
Message-Id: <20230413081855.36643-2-alvaro.karsz@solid-run.com>
Signed-off-by: Michael S. Tsirkin

s390/virtio: sort out physical vs virtual pointers usage

2023-02-08T08:59:46+00:00

This does not fix a real bug, since virtual addresses
are currently indentical to physical ones.

Reviewed-by: Nico Boehr 
Signed-off-by: Alexander Gordeev 
Signed-off-by: Janosch Frank