linux.git/drivers/s390/char, branch v3.13

s390/3270: fix allocation of tty3270_screen structure

2013-12-18T16:35:30+00:00

The tty3270_alloc_screen function is called from tty3270_install with
swapped arguments, the number of columns instead of rows and vice versa.
The number of rows is typically smaller than the number of columns which
makes the screen array too big but the individual cell arrays for the
lines too small. Creating lines longer than the number of rows will
clobber the memory after the end of the cell array.
The fix is simple, call tty3270_alloc_screen with the correct argument
order.

Signed-off-by: Martin Schwidefsky

s390/sclp: replace uninitialized early_event_mask_sccb variable with sccb_early

2013-12-02T14:31:07+00:00

Commit "s390/sclp: Consolidate early sclp init calls to sclp_early_detect()"
(7b50da53f6ad2048241bef232bfc22a132a40283) replaced the sclp_event_mask_early()
with sclp_set_event_mask().  The early_event_mask_sccb variable is no longer
initialized but is still used in sclp_has_linemode() and sclp_has_vt220().

Replace early_event_mask_sccb with the sccb_early variable in both
functions.

Signed-off-by: Hendrik Brueckner 
Signed-off-by: Martin Schwidefsky

s390/sclp: Consolidate early sclp init calls to sclp_early_detect()

2013-11-15T13:08:41+00:00

The new function calls the old ones. The sclp_event_mask_early() is removed
and replaced by one invocation of sclp_set_event_mask(0, 0).

Reviewed-by: Heiko Carstens 
Signed-off-by: Michael Holzheu 
Signed-off-by: Martin Schwidefsky

s390/sclp: Move early code from sclp_cmd.c to sclp_early.c

2013-11-15T13:08:41+00:00

The early SCLP driver code in sclp_cmd.c belongs to sclp_early.c
because it is independent from the 'normal' SCLP driver. So move
it to sclp_early.c

Reviewed-by: Heiko Carstens 
Signed-off-by: Michael Holzheu 
Signed-off-by: Martin Schwidefsky

s390/sclp: Determine HSA size dynamically for zfcpdump

2013-11-15T13:08:40+00:00

Currently we have hardcoded the HSA size to 32 MiB. With this patch the
HSA size is determined dynamically via SCLP in early.c.

Reviewed-by: Heiko Carstens 
Signed-off-by: Michael Holzheu 
Signed-off-by: Martin Schwidefsky

s390/sclp: Move declarations for sclp_sdias into separate header file

2013-11-15T13:08:39+00:00

Reviewed-by: Heiko Carstens 
Signed-off-by: Michael Holzheu 
Signed-off-by: Martin Schwidefsky

s390/3270: fix missing device_destroy() call

2013-11-15T13:08:37+00:00

Unloading the fs3270 kernel module does not remove the created
"3270/tub" device.  Reloading the module then causes a sysfs warning:
"sysfs: cannot create duplicate filename '/devices/virtual/3270/3270!tub'".

Call device_destroy() in the module exit function to solve this issue.

Signed-off-by: Hendrik Brueckner 
Signed-off-by: Martin Schwidefsky

s390/3270: use diagnose 0x210 for device sensing under z/VM

2013-10-24T15:17:10+00:00

There is a debugging leftover from git commit 4d334fd155b53adf
"s390/3270: asynchronous size sensing" in raw3270_reset_device_cb.
Under z/VM the diagnose 0x210 can be used to find the correct
size of the 3270 terminal.

Signed-off-by: Martin Schwidefsky

s390/3270: remove unnecessary pointer check

2013-10-24T15:17:09+00:00

Make smatch happy and remove this warning:

drivers/s390/char/raw3270.c:347 raw3270_irq() error: we previously
 assumed 'rq' could be null (see line 342)

Signed-off-by: Martin Schwidefsky

s390/monwriter: fix smatch warning for strcpy()

2013-10-24T15:17:08+00:00

This patch fixes the following smatch warning:
monwrite_diag() error: strcpy() '"LNXAPPL"' too large for 'id.prod_nr'
(8 vs 7)
Using strcpy() is wrong, because it also copies the terminating null
byte, but in this case the extra copied null byte will be overwritten
right after the strcpy(), so there is no real problem here.
Use strncpy() to fix the warning.

Signed-off-by: Gerald Schaefer 
Signed-off-by: Martin Schwidefsky