linux.git/drivers/rtc, branch v4.20-rc4

rtc: pcf2127: fix a kmemleak caused in pcf2127_i2c_gather_write

2018-11-07T16:13:56+00:00

pcf2127_i2c_gather_write() allocates memory as local variable
for i2c_master_send(), after finishing the master transfer,
the allocated memory should be freed. The kmemleak is reported:

unreferenced object 0xffff80231e7dba80 (size 64):
  comm "hwclock", pid 27762, jiffies 4296880075 (age 356.944s)
  hex dump (first 32 bytes):
    03 00 12 03 19 02 11 13 00 80 98 18 00 00 ff ff ................
    00 50 00 00 00 00 00 00 02 00 00 00 00 00 00 00 .P..............
  backtrace:
    [] create_object+0xf8/0x278
    [] kmemleak_alloc+0x74/0xa0
    [] __kmalloc+0x1ac/0x348
    [] pcf2127_i2c_gather_write+0x54/0xf8
    [] _regmap_raw_write+0x464/0x850
    [] regmap_bulk_write+0x1a4/0x348
    [] pcf2127_rtc_set_time+0xac/0xe8
    [] rtc_set_time+0x80/0x138
    [] rtc_dev_ioctl+0x398/0x610
    [] do_vfs_ioctl+0xb0/0x848
    [] SyS_ioctl+0x8c/0xa8
    [] el0_svc_naked+0x34/0x38
    [] 0xffffffffffffffff

Signed-off-by: Xulin Sun 
Signed-off-by: Alexandre Belloni

rtc: hctosys: Add missing range error reporting

2018-11-07T16:13:55+00:00

Fix an issue with the 32-bit range error path in `rtc_hctosys' where no
error code is set and consequently the successful preceding call result
from `rtc_read_time' is propagated to `rtc_hctosys_ret'.  This in turn
makes any subsequent call to `hctosys_show' incorrectly report in sysfs
that the system time has been set from this RTC while it has not.

Set the error to ERANGE then if we can't express the result due to an
overflow.

Signed-off-by: Maciej W. Rozycki 
Fixes: b3a5ac42ab18 ("rtc: hctosys: Ensure system time doesn't overflow time_t")
Cc: stable@vger.kernel.org # 4.17+
Signed-off-by: Alexandre Belloni

rtc: cmos: Do not export alarm rtc_ops when we do not support alarms

2018-11-07T16:13:55+00:00

When there is no IRQ configured for the RTC, the rtc-cmos code does not
support alarms, all alarm rtc_ops fail with -EIO / -EINVAL.

The rtc-core expects a rtc driver which does not support rtc alarms to
not have alarm ops at all. Otherwise the wakealarm sysfs attr will read
as empty rather then returning an error, making it impossible for
userspace to find out beforehand if alarms are supported.

A system without an IRQ for the RTC before this patch:
[root@localhost ~]# cat /sys/class/rtc/rtc0/wakealarm
[root@localhost ~]#

After this patch:
[root@localhost ~]# cat /sys/class/rtc/rtc0/wakealarm
cat: /sys/class/rtc/rtc0/wakealarm: No such file or directory
[root@localhost ~]#

This fixes gnome-session + systemd trying to use suspend-then-hibernate,
which causes systemd to abort the suspend when writing the RTC alarm fails.

BugLink: https://github.com/systemd/systemd/issues/9988
Signed-off-by: Hans de Goede 
Signed-off-by: Alexandre Belloni

rtc: sc27xx: Always read normal alarm when registering RTC device

2018-10-25T00:35:42+00:00

When registering one RTC device, it will check to see if there is an
alarm already set in RTC hardware by reading RTC alarm, at this time
we should always read the normal alarm put in always-on region by
checking the rtc->registered flag.

Signed-off-by: Baolin Wang 
Signed-off-by: Alexandre Belloni

rtc: sc27xx: Add check to see if need to enable the alarm interrupt

2018-10-25T00:35:40+00:00

The RTC interrupt enable register is not put in always-power-on region
supplied by VDDRTC, so we should check if we need enable the alarm
interrupt when system booting.

Signed-off-by: Baolin Wang 
Signed-off-by: Alexandre Belloni

rtc: sc27xx: Remove interrupts disable and clear in probe()

2018-10-25T00:35:39+00:00

When registering one rtc device, it will check to see if there is an
alarm already set in rtc hardware by issuing __rtc_read_alarm(). So
we should not disable the RTC interrupts and clear the interrupts
status in probe() function.

Signed-off-by: Baolin Wang 
Signed-off-by: Alexandre Belloni

rtc: sc27xx: Clear SPG value update interrupt status

2018-10-25T00:35:38+00:00

We should clear the SPG value update interrupt status once the SPG value
is updated successfully, in case incorrect status validation for next time.

Signed-off-by: Baolin Wang 
Signed-off-by: Alexandre Belloni

rtc: sc27xx: Set wakeup capability before registering rtc device

2018-10-25T00:35:36+00:00

Set wakeup capability before registering rtc device, in case the alarmtimer
can find one available rtc device.

Signed-off-by: Baolin Wang 
Signed-off-by: Alexandre Belloni

rtc: s35390a: Change buf's type to u8 in s35390a_init

2018-10-22T17:29:43+00:00

Clang warns:

drivers/rtc/rtc-s35390a.c:124:27: warning: implicit conversion from
'int' to 'char' changes value from 192 to -64 [-Wconstant-conversion]
        buf = S35390A_FLAG_RESET | S35390A_FLAG_24H;
            ~ ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
1 warning generated.

Update buf to be an unsigned 8-bit integer, which matches the buf member
in struct i2c_msg.

https://github.com/ClangBuiltLinux/linux/issues/145
Signed-off-by: Nathan Chancellor 
Signed-off-by: Alexandre Belloni

rtc: ds1307: fix ds1339 wakealarm support

2018-10-22T15:53:14+00:00

Commit 51ed73eb998a1c79a2b0e9bed68f75a8a2c93b9b ("rtc: ds1340: Add support
for trickle charger.") breaks ds1339 wakealarm support by limiting
accessible registers. Fix this.

Fixes: 51ed73eb998a ("rtc: ds1340: Add support for trickle charger.")
Cc: stable@vger.kernel.org
Signed-off-by: Soeren Moch 
Signed-off-by: Alexandre Belloni