linux.git/drivers/rtc/rtc-s3c.c, branch v2.6.38

drivers/rtc/rtc-s3c.c: fix prototype for s3c_rtc_setaie()

2011-03-05T01:53:38+00:00

Fix s3c_rtc_setaie() prototype to eliminate the following compile
warning:

  drivers/rtc/rtc-s3c.c:383: warning: initialization from incompatible pointer type

(akpm: the rtc_class_ops.alarm_irq_enable() handler is being passed two
arguments where it expects just one, presumably with undesired effects)

Signed-off-by: Axel Lin 
Cc: Alessandro Zummo 
Cc: Ben Dooks 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: rtc-s3c: add rtc_valid_tm in s3c_rtc_gettime()

2010-10-28T01:03:06+00:00

Add "rtc_valid_tm" in s3c_rtc_gettime() as per Wan ZongShun's suggestion.

Suggested-by: Wan ZongShun 
Signed-off-by: Kukjin Kim 
Cc: Ben Dooks 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: rtc-s3c: fix RTC initialization method

2010-10-28T01:03:06+00:00

Change RTC initialization method in probe().  The 'rtc_valid_tm(tm)' can
check whether RTC BCD is valid or not.  And change the method of checking
because the previous method cannot validate RTC BCD registers properly.

Signed-off-by: Changhwan Youn 
Signed-off-by: Kukjin Kim 
Cc: Ben Dooks 
Cc: Wan ZongShun 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: rtc-s3c: Fix debug message format on RTC

2010-10-28T01:03:06+00:00

Fix debug message format.

Signed-off-by: Kukjin Kim 
Acked-by: Ben Dooks 
Cc: Wan ZongShun 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: rtc-s3c: fix on support RTC Alarm

2010-10-28T01:03:06+00:00

The alarm_irq_enable function should be implemented to support RTC alarm.
And fix tabs instead of white space around the proc field.

Signed-off-by: Changhwan Youn 
Signed-off-by: Kukjin Kim 
Acked-by: Ben Dooks 
Cc: Wan ZongShun 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: rtc-s3c: fix setting missing field of getalarm

2010-10-28T01:03:06+00:00

Current s3c_rtc_getalarm() sets missing field of alarm time with 0xff.
But this value should be -1 according to drivers/rtc/interface.c.

Signed-off-by: Changhwan Youn 
Signed-off-by: Kukjin Kim 
Acked-by: Ben Dooks 
Cc: Wan ZongShun 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: rtc-s3c: fix access unit from byte to word on RTCCON

2010-10-28T01:03:06+00:00

S3C2410_RTCCON of TYPE_S3C64XX RTC should be read/written by readw and
writew, because TYPE_S3C64XX RTC uses bit 8 and 9.  And TYPE_S3C2410 RTC
also can access it by readw and writew.

[atul.dahiya@samsung.com: tested on smdk2416]
[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Changhwan Youn 
Signed-off-by: Kukjin Kim 
Tested-by: Atul Dahiya 
Cc: Ben Dooks 
Cc: Wan ZongShun 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: s3c: balance state changes of wakeup flag

2010-09-23T00:22:40+00:00

This change resolves a problem about unbalanced calls of
enable_irq_wakeup() and disable_irq_wakeup() for alarm interrupt.

Bug reproduction:

root@eb600:~# echo 0 > /sys/class/rtc/rtc0/wakealarm

WARNING: at kernel/irq/manage.c:361 set_irq_wake+0x7c/0xe4()
 Unbalanced IRQ 46 wake disable
Modules linked in:
[] (unwind_backtrace+0x0/0xd8) from [] (warn_slowpath_common+0x44/0x5c)
[] (warn_slowpath_common+0x44/0x5c) from [] (warn_slowpath_fmt+0x24/0x30)
[] (warn_slowpath_fmt+0x24/0x30) from [] (set_irq_wake+0x7c/0xe4)
[] (set_irq_wake+0x7c/0xe4) from [] (s3c_rtc_setalarm+0xa8/0xb8)
[] (s3c_rtc_setalarm+0xa8/0xb8) from [] (rtc_set_alarm+0x60/0x74)
[] (rtc_set_alarm+0x60/0x74) from [] (rtc_sysfs_set_wakealarm+0xc8/0xd8)
[] (rtc_sysfs_set_wakealarm+0xc8/0xd8) from [] (dev_attr_store+0x20/0x24)
[] (dev_attr_store+0x20/0x24) from [] (sysfs_write_file+0x104/0x13c)
[] (sysfs_write_file+0x104/0x13c) from [] (vfs_write+0xb0/0x158)
[] (vfs_write+0xb0/0x158) from [] (sys_write+0x3c/0x68)
[] (sys_write+0x3c/0x68) from [] (ret_fast_syscall+0x0/0x28)

Signed-off-by: Vladimir Zapolskiy 
Cc: Alessandro Zummo 
Cc: Ben Dooks 
Cc: Atul Dahiya 
Cc: Taekgyun Ko 
Cc: Kukjin Kim 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: rtc-s3c: Add BCD register initialization codes

2010-08-05T09:32:51+00:00

RTC needs to be initialized when BCD registers have invalid value.

Signed-off-by: Taekgyun Ko 
Signed-off-by: Kukjin Kim 
Cc: Ben Dooks 
Acked-by: Alessandro Zummo

rtc: rtc-s3c: Updates driver for S3C64XX and newer SoCs

2010-08-05T09:32:51+00:00

This Patch does followings.
1) Enables support for alarm and time tick pending register
   for periodic interrupt generation.
2) Changes writeb to writew beacuse the macro S3C64XX_RTCCON_TICEN
   (Tick Timer Enable) is 9th bit of register.
3) Changes writeb to writel as max_user_freq used in s3c64xx is 32768 and
   requires 15 bits to update the Tick Count Register.

Signed-off-by: Atul Dahiya 
Signed-off-by: Taekgyun Ko 
Signed-off-by: Kukjin Kim 
Cc: Ben Dooks