linux.git/drivers/rtc/rtc-cmos.c, branch v2.6.38

rtc-cmos: fix suspend/resume

2011-01-13T16:03:12+00:00

rtc-cmos was setting suspend/resume hooks at the device_driver level.
However, the platform bus code (drivers/base/platform.c) only looks for
resume hooks at the dev_pm_ops level, or within the platform_driver.

Switch rtc_cmos to use dev_pm_ops so that suspend/resume code is executed
again.

Paul said:

: The user visible symptom in our (XO laptop) case was that rtcwake would
: fail to wake the laptop.  The RTC alarm would expire, but the wakeup
: wasn't unmasked.
:
: As for severity, the impact may have been reduced because if I recall
: correctly, the bug only affected platforms with CONFIG_PNP disabled.

Signed-off-by: Paul Fox 
Signed-off-by: Daniel Drake 
Acked-by: Rafael J. Wysocki 
Cc: 		[2.6.37.x]
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc-cmos.c : Fix warning on PowerPC

2010-11-29T04:48:19+00:00

The following warning is seen while compilation of PowerPC kernel:

 CC      drivers/rtc/rtc-cmos.o
drivers/rtc/rtc-cmos.c:697:2: warning: #warning Assuming 128 bytes
of RTC+NVRAM address space, not 64 bytes.

Fix it by adding defined(__powerpc__).

Signed-off-by: Srikanth Krishnakar 
Signed-off-by: Benjamin Herrenschmidt

drivers/rtc: remove unneeded ifdef CONFIG_PM

2010-08-11T15:59:08+00:00

Because CONFIG_PM is a precondition to CONFIG_ACPI, the ifdef CONFIG_PM
within ifdef CONFIG_ACPI is redundant.

Signed-off-by: Christian Dietrich 
Acked-by: Wan ZongShun 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc-cmos: do dev_set_drvdata() earlier in the initialization

2010-05-25T15:07:08+00:00

The bug is an oops when dev_get_drvdata() returned null in
cmos_update_irq_enable().  The call tree looks like this:
  rtc_dev_ioctl()
    => rtc_update_irq_enable()
      => cmos_update_irq_enable()

It's caused by a race condition in the module initialization.  It is
rtc_device_register() which makes the ioctl operations live so I moved
the call to dev_set_drvdata() before the call to rtc_device_register().

Addresses https://bugzilla.kernel.org/show_bug.cgi?id=15963

Reported-by: Randy Dunlap 
Signed-off-by: Dan Carpenter 
Tested-by: Randy Dunlap 
Cc: Alessandro Zummo 
Cc: Paul Gortmaker 
Cc: Malte Schroder 
Cc: Ralf Baechle 
Cc: Herton Ronaldo Krzesinski 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

RTC: rtc-cmos: Fix binary mode support

2010-05-21T20:31:19+00:00

As a follow-up to the thread about RTC support for some Loongson 2E/2F
boards, this patch tries to address the "REVISIT"/"FIXME" comments about
rtc binary mode handling and allow rtc to work with rtc in binary mode.
I've also raised the message about 24-h mode not supported to warning
otherwise, one may end up with no rtc without any message in the kernel
log.

Signed-off-by: Arnaud Patard 
To: linux-mips@linux-mips.org
To: rtc-linux@googlegroups.com
Cc: david-b@pacbell.net
Cc: a.zummo@towertech.it
Cc: akpm@linux-foundation.org
Patchwork: http://patchwork.linux-mips.org/patch/1158/
Signed-off-by: Ralf Baechle

sysfs: add struct file* to bin_attr callbacks

2010-05-21T16:37:31+00:00

This allows bin_attr->read,write,mmap callbacks to check file specific data
(such as inode owner) as part of any privilege validation.

Signed-off-by: Chris Wright 
Signed-off-by: Greg Kroah-Hartman

rtc_cmos: convert shutdown to new pnp_driver->shutdown

2010-01-11T17:34:07+00:00

commit abd6633c67925f90775bb74755f9c547e30f1f20 ("pnp: add a shutdown
method to pnp drivers") adds shutdown method to bus driver blindly.  With
it, driver->shutdown is no longer valid.

Use pnp_driver->shutdown instead.

Addresses http://bugzilla.kernel.org/show_bug.cgi?id=14889

Signed-off-by: OGAWA Hirofumi 
Reported-by: Malte Schröder 
Cc: "Rafael J. Wysocki" 
Cc: Bjorn Helgaas 
Cc: David Hardeman 
Cc: Dmitry Torokhov 
Cc: Alessandro Zummo 
Cc: Paul Gortmaker 
Cc: 		[2.6.32.x]
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

RTC: rtc-cmos.c: Fix warning on MIPS

2009-12-17T01:57:37+00:00

This patch fixes the following warning with RTC_LIB on MIPS:

drivers/rtc/rtc-cmos.c:697:2: warning: #warning Assuming 128 bytes of
RTC+NVRAM address space, not 64 bytes.

Signed-off-by: Wu Zhangjin 
Cc: Arnaud Patard 
Cc: linux-mips@linux-mips.org
Cc: rtc-linux@googlegroups.com
Cc: Paul Gortmaker 
Cc: Alessandro Zummo 
Patchwork: http://patchwork.linux-mips.org/patch/570/
Acked-by: Alessandro Zummo 
Signed-off-by: Ralf Baechle

rtc-cmos: convert RTC_AIE/RTC_UIE to rtc irq API

2009-12-16T15:19:58+00:00

Drop ioctl function that handles RTC_AIE/RTC_UIE, and use instead the
rtc subsystem API (alarm_irq_enable/update_irq_enable callbacks).

Signed-off-by: Herton Ronaldo Krzesinski 
Cc: Alessandro Zummo 
Cc: David Brownell 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: disable hpet emulation on suspend

2009-12-16T15:19:58+00:00

I noticed that rtc wont generate interrupts after a resume from disk.
Here hpet rtc emulation is used.

Problem is that rtc hpet comparator, isn't reinitialized after resume.
Easiest way to solve this, is always mask all hpet interrupts on suspend
This is triggered, when suspending with alarm set.

Otherwise, hpet driver will think it doesn't need to reinitialize
the rtc comparator, thus rtc interrupts won't work.

This emulation isn't need for wakealarm.

Signed-off-by: Maxim Levitsky 
Cc: David Brownell 
Cc: "H. Peter Anvin" 
Cc: Thomas Gleixner 
Cc: Ingo Molnar 
Cc: "Rafael J. Wysocki" 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds