linux.git/drivers/rtc/rtc-bfin.c, branch v2.6.31

bfin: delay IRQ registration until driver is ready

2009-07-01T01:56:01+00:00

Make sure we do not actually request the RTC IRQ until the device driver
is fully ready to handle and process any interrupt.  This way a spurious
interrupt won't crash the system (which may happen if the bootloader was
poking the RTC right before booting Linux).

Signed-off-by: Mike Frysinger 
Signed-off-by: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc: correct an error test

2009-01-06T23:59:25+00:00

rtc is clearly does not satisfy IS_ERR at the point where it is tested, so
I have changed the test to consider the just initialized rtc->rtc_dev.

The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// 
@match exists@
expression x, E;
identifier fld;
position p1,p2;
@@

(
x = E;
|
x = E
|
x@p1->fld
... when != x = E
IS_ERR(x@p2)
... when any
)

@other_match exists@
expression match.x, E1, E2;
position match.p1,match.p2;
@@

x = E1
... when != x = E2
    when != x@p1
x@p2

@ script:python depends on !other_match@
p1 << match.p1;
p2 << match.p2;
@@

print "* file %s dereference %s test %s" % (p1[0].file,p1[0].line,p2[0].line)
// 

Signed-off-by: Julia Lawall 
Acked-by: Alessandro Zummo 
Cc: David Brownell 
Cc: Bryan Wu 
Cc: Mike Frysinger 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Blackfin RTC Driver: dont let RTC programming in bootloaders randomly cause ~5 second boot delays

2008-08-20T22:40:30+00:00

Signed-off-by: Mike Frysinger 
Signed-off-by: Bryan Wu 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Blackfin RTC Driver: do all initialization before we register the rtc and make it available

2008-08-20T22:40:30+00:00

Signed-off-by: Mike Frysinger 
Signed-off-by: Bryan Wu 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Blackfin RTC Driver: move irq request/free out of open/release and into probe/remove so that the non-dev interfaces (like sysfs) work as expected

2008-08-20T22:40:30+00:00

Signed-off-by: Mike Frysinger 
Signed-off-by: Bryan Wu 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

blackfin RTC driver: drop PIE/stopwatch code since the hardware can only do a max of 1HZ and this same functionality is provided by UIE

2008-08-05T21:33:48+00:00

Signed-off-by: Mike Frysinger 
Signed-off-by: Bryan Wu 
Cc: David Brownell 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

blackfin RTC driver: convert PIE handling to irq_set_state() as pointed out by David Brownell

2008-08-05T21:33:48+00:00

Signed-off-by: Mike Frysinger 
Signed-off-by: Bryan Wu 
Cc: David Brownell 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

blackfin RTC driver: wait for the write complete interrupt complete before sleeping

2008-08-05T21:33:48+00:00

Since we use the write complete interrupt, wait for it
to complete before sleeping so we don't wake right back up due to it

Signed-off-by: Mike Frysinger 
Signed-off-by: Bryan Wu 
Cc: David Brownell 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

blackfin RTC driver: disable the write complete irq upon close

2008-08-05T21:33:47+00:00

Signed-off-by: Mike Frysinger 
Signed-off-by: Bryan Wu 
Cc: David Brownell 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

blackfin RTC driver: don't bother passing the rtc struct down to bfin_rtc_int_{set,clear} since it isnt needed (shaves off ~100bytes)

2008-08-05T21:33:47+00:00

Signed-off-by: Mike Frysinger 
Signed-off-by: Bryan Wu 
Signed-off-by: Bryan Wu 
Cc: David Brownell 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds