linux.git/drivers/pwm/core.c, branch v6.7

pwm: Drop pwm_[sg]et_chip_data()

2023-10-13T08:07:17+00:00

The semantic of chip_data is a bit surprising as it's cleared when
pwm_put() is called. Also there is a big overlap with the standard driver
data.

All drivers were adapted to not make use of chip_data any more, so it can
go away.

Link: https://lore.kernel.org/r/20230705080650.2353391-9-u.kleine-koenig@pengutronix.de
Signed-off-by: Uwe Kleine-König 
Signed-off-by: Thierry Reding

pwm: Manage owner assignment implicitly for drivers

2023-10-13T08:07:17+00:00

Instead of requiring each driver to care for assigning the owner member
of struct pwm_ops, handle that implicitly using a macro. Note that the
owner member has to be moved to struct pwm_chip, as the ops structure
usually lives in read-only memory and so cannot be modified.

The upside is that new low level drivers cannot forget the assignment and
save one line each. The pwm-crc driver didn't assign .owner, that's not
a problem in practice though as the driver cannot be compiled as a
module.

Acked-by: Andy Shevchenko  # Intel LPSS
Reviewed-by: Florian Fainelli  # pwm-{bcm,brcm}*.c
Acked-by: Jernej Skrabec  # sun4i
Acked-by: Andi Shyti 
Acked-by: Nobuhiro Iwamatsu  # pwm-visconti
Acked-by: Heiko Stuebner  # pwm-rockchip
Acked-by: Michael Walle  # pwm-sl28cpld
Acked-by: Neil Armstrong  # pwm-meson
Reviewed-by: Linus Walleij 
Link: https://lore.kernel.org/r/20230804142707.412137-2-u.kleine-koenig@pengutronix.de
Signed-off-by: Uwe Kleine-König 
Signed-off-by: Thierry Reding

pwm: Fix order of freeing resources in pwmchip_remove()

2023-07-28T07:42:37+00:00

pwmchip_add() calls of_pwmchip_add() only after adding the chip to
pwm_chips and releasing pwm_lock. So the proper order in
pwmchip_remove() is to call of_pwmchip_remove() before taking the mutex
and removing the chip from pwm_chips. This way pwmchip_remove() releases
the resources in reverse order compared to pwmchip_add() requesting
them.

Signed-off-by: Uwe Kleine-König 
Signed-off-by: Thierry Reding

pwm: Drop unused #include

2023-07-28T07:30:47+00:00

core.c doens't use any of the symbols provided by linux/radix-tree.h
and compiles just fine without this include. So drop the #include.

Signed-off-by: Uwe Kleine-König 
Signed-off-by: Thierry Reding

pwm: Remove outdated documentation for pwmchip_remove()

2023-07-28T07:24:29+00:00

pwmchip_remove() returns void since some time but the documentation still
mentions the situations where it used to return an error code. Just remove
this old and now wrong text.

Fixes: 8083f58d08fd ("pwm: Make pwmchip_remove() return void")
Signed-off-by: Uwe Kleine-König 
Signed-off-by: Thierry Reding

pwm: Explicitly include correct DT includes

2023-07-24T11:28:05+00:00

The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result, there's a pretty much random mix of those include
files used throughout the tree. In order to detangle these headers and
replace the implicit includes with struct declarations, users need to
explicitly include the correct includes.

Signed-off-by: Rob Herring 
Reviewed-by: Nobuhiro Iwamatsu 
Acked-by: Uwe Kleine-König 
Reviewed-by: Tzung-Bi Shih 
Signed-off-by: Thierry Reding

pwm: Use a consistent name for pwm_chip pointers in the core

2023-07-20T06:50:55+00:00

Most variables of type struct pwm_chip * are named "chip", there are
only three outliers called "pc". Change these three to "chip", too, for
consistency.

Signed-off-by: Uwe Kleine-König 
Signed-off-by: Thierry Reding

pwm: Remove unused radix tree

2023-04-14T09:35:52+00:00

The radix tree's only use was to map PWM channels to the global number
space. With that number space gone, the radix tree is now unused, so it
can simply be removed.

Acked-by: Uwe Kleine-König 
Signed-off-by: Thierry Reding

pwm: Delete deprecated functions pwm_request() and pwm_free()

2023-04-13T12:27:53+00:00

Since commit 5a7fbe452ad9 ("backlight: pwm_bl: Drop support for legacy PWM
probing") the last user of pwm_request() and pwm_free() is gone. So remove
these functions that were deprecated over 10 years ago in commit
8138d2ddbcca ("pwm: Add table-based lookup for static mappings").

Signed-off-by: Uwe Kleine-König 
[thierry.reding@gmail.com: clean up a bit after removal]
Signed-off-by: Thierry Reding

pwm: Zero-initialize the pwm_state passed to driver's .get_state()

2023-03-23T13:44:43+00:00

This is just to ensure that .usage_power is properly initialized and
doesn't contain random stack data. The other members of struct pwm_state
should get a value assigned in a successful call to .get_state(). So in
the absence of bugs in driver implementations, this is only a safe-guard
and no fix.

Reported-by: Munehisa Kamata 
Link: https://lore.kernel.org/r/20230310214004.2619480-1-u.kleine-koenig@pengutronix.de
Signed-off-by: Uwe Kleine-König 
Signed-off-by: Thierry Reding