linux.git/drivers/platform, branch v6.2-rc5

platform/x86: thinkpad_acpi: Fix profile mode display in AMT mode

2023-01-13T10:40:30+00:00

Recently AMT mode was enabled (somewhat unexpectedly) on the Lenovo
Z13 platform. The FW is advertising it is available and the driver tries
to use it - unfortunately it reports the profile mode incorrectly.

Note, there is also some extra work needed to enable the dynamic aspect
of AMT support that I will be following up with; but more testing is
needed first. This patch just fixes things so the profiles are reported
correctly.

Link: https://gitlab.freedesktop.org/hadess/power-profiles-daemon/-/issues/115
Fixes: 46dcbc61b739 ("platform/x86: thinkpad-acpi: Add support for automatic mode transitions")

Reviewed-by: Mario Limonciello 
Signed-off-by: Mark Pearson 
Link: https://lore.kernel.org/r/20230112221228.490946-1-mpearson-lenovo@squebb.ca
Reviewed-by: Hans de Goede 
Signed-off-by: Hans de Goede

platform/x86: int3472/discrete: Ensure the clk/power enable pins are in output mode

2023-01-12T19:10:31+00:00

acpi_get_and_request_gpiod() does not take a gpio_lookup_flags argument
specifying that the pins direction should be initialized to a specific
value.

This means that in some cases the pins might be left in input mode, causing
the gpiod_set() calls made to enable the clk / regulator to not work.

One example of this problem is the clk-enable GPIO for the ov01a1s sensor
on a Dell Latitude 9420 being left in input mode causing the clk to
never get enabled.

Explicitly set the direction of the pins to output to fix this.

Fixes: 5de691bffe57 ("platform/x86: Add intel_skl_int3472 driver")
Signed-off-by: Hans de Goede 
Reviewed-by: Andy Shevchenko 
Reviewed-by: Daniel Scally 
Reviewed-by: Sakari Ailus 
Link: https://lore.kernel.org/r/20230111201426.947853-1-hdegoede@redhat.com

platform/x86/amd: Fix refcount leak in amd_pmc_probe

2023-01-12T19:04:38+00:00

pci_get_domain_bus_and_slot() takes reference, the caller should release
the reference by calling pci_dev_put() after use. Call pci_dev_put() in
the error path to fix this.

Fixes: 3d7d407dfb05 ("platform/x86: amd-pmc: Add support for AMD Spill to DRAM STB feature")
Signed-off-by: Miaoqian Lin 
Reviewed-by: Mario Limonciello 
Link: https://lore.kernel.org/r/20221229072534.1381432-1-linmq006@gmail.com
Reviewed-by: Hans de Goede 
Signed-off-by: Hans de Goede

platform/x86: intel/pmc/core: Add Meteor Lake mobile support

2023-01-12T18:44:30+00:00

Add Meteor Lake mobile support to pmc core driver. Meteor Lake mobile
parts reuse all the Meteor Lake PCH IPs.

Cc: David E Box 
Signed-off-by: Gayatri Kammela 
Link: https://lore.kernel.org/r/20221228230553.2497183-1-gayatri.kammela@linux.intel.com
Signed-off-by: Hans de Goede

platform/x86: simatic-ipc: add another model

2023-01-12T18:42:53+00:00

Add IPC PX-39A support.

Signed-off-by: Henning Schild 
Link: https://lore.kernel.org/r/20221222103720.8546-3-henning.schild@siemens.com
Reviewed-by: Hans de Goede 
Signed-off-by: Hans de Goede

platform/x86: simatic-ipc: correct name of a model

2023-01-12T18:42:41+00:00

What we called IPC427G should be renamed to BX-39A to be more in line
with the actual product name.

Signed-off-by: Henning Schild 
Link: https://lore.kernel.org/r/20221222103720.8546-2-henning.schild@siemens.com
Reviewed-by: Hans de Goede 
Signed-off-by: Hans de Goede

platform/x86: dell-privacy: Only register SW_CAMERA_LENS_COVER if present

2023-01-12T18:40:19+00:00

Unlike keys where userspace only reacts to keypresses, userspace may act
on switches in both (0 and 1) of their positions.

For example if a SW_TABLET_MODE switch is registered then GNOME will not
automatically show the onscreen keyboard when a text field gets focus on
touchscreen devices when SW_TABLET_MODE reports 0 and when SW_TABLET_MODE
reports 1 libinput will block (filter out) builtin keyboard and touchpad
events.

So to avoid unwanted side-effects EV_SW type inputs should only be
registered if they are actually present, only register SW_CAMERA_LENS_COVER
if it is actually there.

Fixes: 8af9fa37b8a3 ("platform/x86: dell-privacy: Add support for Dell hardware privacy")
Signed-off-by: Hans de Goede 
Link: https://lore.kernel.org/r/20221221220724.119594-2-hdegoede@redhat.com

platform/x86: dell-privacy: Fix SW_CAMERA_LENS_COVER reporting

2023-01-12T18:40:19+00:00

Use KE_VSW instead of KE_SW for the SW_CAMERA_LENS_COVER key_entry
and get the value of the switch from the status field when handling
SW_CAMERA_LENS_COVER events, instead of always reporting 0.

Also correctly set the initial SW_CAMERA_LENS_COVER value.

Fixes: 8af9fa37b8a3 ("platform/x86: dell-privacy: Add support for Dell hardware privacy")
Signed-off-by: Hans de Goede 
Link: https://lore.kernel.org/r/20221221220724.119594-1-hdegoede@redhat.com

platform/x86: asus-wmi: Don't load fan curves without fan

2023-01-12T18:36:06+00:00

If we do not have a fan it does not make sense to load curves for it.
This removes the following warnings from the kernel log:

asus_wmi: fan_curve_get_factory_default (0x00110024) failed: -19
asus_wmi: fan_curve_get_factory_default (0x00110025) failed: -19

Fixes: a2bdf10ce96e ("platform/x86: asus-wmi: Increase FAN_CURVE_BUF_LEN to 32")
Signed-off-by: Thomas Weißschuh 
Link: https://lore.kernel.org/r/20221221-asus-fan-v1-3-e07f3949725b@weissschuh.net
Reviewed-by: Hans de Goede 
Signed-off-by: Hans de Goede

platform/x86: asus-wmi: Ignore fan on E410MA

2023-01-12T18:36:03+00:00

The ASUS VivoBook has a fan device described in its ACPI tables but does
not actually contain any physical fan.
Use the quirk to inhibit fan handling.

Signed-off-by: Thomas Weißschuh 
Link: https://lore.kernel.org/r/20221221-asus-fan-v1-2-e07f3949725b@weissschuh.net
Reviewed-by: Hans de Goede 
Signed-off-by: Hans de Goede