linux.git/drivers/platform/chrome/cros_ec_dev.c, branch v4.12

platform/chrome: cros_ec_dev - utilize new cdev_device_add helper function

2017-03-21T05:44:33+00:00

Replace the open coded registration of the cdev and dev with the
new device_add_cdev() helper. The helper replaces a common pattern by
taking the proper reference against the parent device and adding both
the cdev and the device.

At the same time we cleanup the error path through device_probe
function: we use put_device instead of kfree directly as recommended
by the device_initialize documentation.

Signed-off-by: Logan Gunthorpe 
Signed-off-by: Greg Kroah-Hartman

iio: cros_ec: Add cros_ec barometer driver

2017-01-28T15:07:46+00:00

Handle the barometer sensor presented by the ChromeOS EC Sensor hub.

Signed-off-by: Gwendal Grignou 
Signed-off-by: Enric Balletbo Serra 
Signed-off-by: Jonathan Cameron

platform/chrome: cros_ec_dev - Register cros-ec sensors

2016-10-25T17:20:32+00:00

Check whether the ChromeOS Embedded Controller is a sensor hub and in
such case issue a command to get the number of sensors and register them
all.

Signed-off-by: Gwendal Grignou 
Signed-off-by: Enric Balletbo i Serra 
Reviewed-by: Guenter Roeck 
Acked-by: Olof Johansson 
Signed-off-by: Jonathan Cameron

platform/chrome: Introduce a new function to check EC features.

2016-10-25T17:20:29+00:00

Use the EC_CMD_GET_FEATURES message to check the supported features for
each MCU.

Signed-off-by: Vincent Palatin 
[tomeu: adapted to changes in mainline]
Signed-off-by: Tomeu Vizoso 
[enric: remove references to USB PD feature and do it more generic]
Signed-off-by: Enric Balletbo i Serra 
Reviewed-by: Guenter Roeck 
For the MFD changes:
  Acked-by: Lee Jones 
Signed-off-by: Jonathan Cameron

platform/chrome: cros_ec_dev - double fetch bug in ioctl

2016-07-05T21:01:52+00:00

We verify "u_cmd.outsize" and "u_cmd.insize" but we need to make sure
that those values have not changed between the two copy_from_user()
calls.  Otherwise it could lead to a buffer overflow.

Additionally, cros_ec_cmd_xfer() can set s_cmd->insize to a lower value.
We should use the new smaller value so we don't copy too much data to
the user.

Reported-by: Pengfei Wang 
Fixes: a841178445bb ('mfd: cros_ec: Use a zero-length array for command data')
Signed-off-by: Dan Carpenter 
Reviewed-by: Kees Cook 
Tested-by: Gwendal Grignou 
Cc:  # v4.2+
Signed-off-by: Olof Johansson

platform/chrome: cros_ec_dev - Populate compat_ioctl

2016-05-11T18:55:48+00:00

compat_ioctl has to be populated for 32 bit userspace applications to work
with 64 bit kernels.

Signed-off-by: Guenter Roeck 
Tested-by: Brian Norris 
Signed-off-by: Olof Johansson

platform/chrome: cros_ec_dev - Fix security issue

2016-05-11T18:55:47+00:00

Prevent memory scribble by checking that ioctl buffer size parameters
are sane.
Without this check, on 32 bits system, if .insize = 0xffffffff - 20 and
.outsize the amount to scribble, we would overflow, allocate a small
amounts and be able to write outside of the malloc'ed area.
Adding a hard limit allows argument checking of the ioctl. With the
current EC, it is expected .insize and .outsize to be at around 512 bytes
or less.

Signed-off-by: Gwendal Grignou 
Signed-off-by: Olof Johansson

platform/chrome: Support reading/writing the vboot context

2015-10-07T22:05:53+00:00

Some EC implementations include a small nvram space used to store
verified boot context data. This patch offers a way to expose this
data to userspace.

Reviewed-by: Javier Martinez Canillas 
Signed-off-by: Emilio López 
Signed-off-by: Olof Johansson

platform/chrome: cros_ec_dev - Add a platform device ID table

2015-10-07T21:34:26+00:00

If the cros_ec_dev driver is built as a module, modalias information is
not filled so the module is not autoloaded. Add a platform device table
and use the MODULE_DEVICE_TABLE() macro to export that information in
the module so user-space can match the modalias uevent and autoload it.

Signed-off-by: Javier Martinez Canillas 
Signed-off-by: Olof Johansson

mfd: cros_ec: Support multiple EC in a system

2015-06-15T12:18:23+00:00

Chromebooks can have more than one Embedded Controller so the
cros_ec device id has to be incremented for each EC registered.

Add a new structure to represent multiple EC as different char
devices (e.g: /dev/cros_ec, /dev/cros_pd). It connects to
cros_ec_device and allows sysfs inferface for cros_pd.

Also reduce number of allocated objects, make chromeos sysfs
class object a static and add refcounting to prevent object
deletion while command is in progress.

Signed-off-by: Gwendal Grignou 
Reviewed-by: Dmitry Torokhov 
Signed-off-by: Javier Martinez Canillas 
Tested-by: Heiko Stuebner 
Acked-by: Lee Jones 
Acked-by: Olof Johansson 
Signed-off-by: Lee Jones