linux.git/drivers/platform/chrome/cros_ec_debugfs.c, branch v6.11

platform/chrome: cros_ec_debugfs: fix wrong EC message version

2024-06-12T02:28:39+00:00

ec_read_version_supported() uses ec_params_get_cmd_versions_v1 but it
wrongly uses message version 0.

Fix it.

Fixes: e86264595225 ("mfd: cros_ec: add debugfs, console log file")
Reviewed-by: Guenter Roeck 
Link: https://lore.kernel.org/r/20240611113110.16955-1-tzungbi@kernel.org
Signed-off-by: Tzung-Bi Shih

platform/chrome: cros_ec_debugfs: Make log polling period a parameter

2024-05-29T05:09:28+00:00

Make EC log polling period a module parameter. This allows the polling
period to be set via the kernel command line. Keeping the default at
the current 10 second period. The optimal polling period will differ by
board.

Signed-off-by: Rob Barnes 
Link: https://lore.kernel.org/r/20240507155809.525701-1-robbarnes@google.com
Signed-off-by: Tzung-Bi Shih

platform/chrome: cros_ec_debugfs: provide ID table for avoiding fallback match

2024-04-24T08:45:57+00:00

Instead of using fallback driver name match, provide ID table[1] for the
primary match.

[1]: https://elixir.bootlin.com/linux/v6.8/source/drivers/base/platform.c#L1353

Reviewed-by: Krzysztof Kozlowski 
Reviewed-by: Benson Leung 
Link: https://lore.kernel.org/r/20240329075630.2069474-10-tzungbi@kernel.org
Signed-off-by: Tzung-Bi Shih

platform/chrome: cros_ec_debugfs: Fix permissions for panicinfo

2023-11-21T20:10:44+00:00

The debugfs_create_blob() function has been used to create read-only binary
blobs in debugfs. The function filters out permissions, other than S_IRUSR,
S_IRGRP and S_IROTH, provided while creating the blobs.

The very behavior though is being changed through previous patch in the
series (fs: debugfs: Add write functionality to debugfs blobs) which makes
the binary blobs writable by owners. Thus, all permissions provided while
creating the blobs, except S_IRUSR,S_IWUSR, S_IRGRP, S_IROTH, will be
filtered by debugfs_create_blob().

As such, rectify the permissions of panicinfo file since the S_IFREG flag
was anyways being filtered out by debugfs_create_blob(). Moreover, the
very flag will always be set be set for the panicinfo file through
__debugfs_create_file().

Signed-off-by: Avadhut Naik 
Reviewed-by: Greg Kroah-Hartman 
Reviewed-by: Tony Luck 
Signed-off-by: Rafael J. Wysocki

platform/chrome: cros_ec_debugfs: Convert to platform remove callback returning void

2023-09-28T05:18:06+00:00

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König 
Link: https://lore.kernel.org/r/20230927081040.2198742-3-u.kleine-koenig@pengutronix.de
Signed-off-by: Tzung-Bi Shih

platform/chrome: cros_ec_debugfs: fix kernel-doc warning

2023-04-24T05:35:12+00:00

Fix the following kernel-doc warning:

$ ./scripts/kernel-doc -none drivers/platform/chrome/*
[...]
warning: This comment starts with '/**', but isn't a kernel-doc comment.

Fixes: 14bb09b32f43 ("platform/chrome: cros_ec: Separate logic for getting panic info")
Reported-by: kernel test robot 
Signed-off-by: Tzung-Bi Shih 
Reviewed-by: Benson Leung 
Link: https://lore.kernel.org/r/20230411053308.1572493-1-tzungbi@kernel.org

platform/chrome: cros_ec: Separate logic for getting panic info

2023-04-24T05:35:12+00:00

Create a separate function called cros_ec_get_panicinfo for getting
panic info from EC.

Currently cros_ec_create_panicinfo is the only caller.

Signed-off-by: Rob Barnes 
Signed-off-by: Tzung-Bi Shih 
Link: https://lore.kernel.org/r/20230410165817.932449-1-robbarnes@google.com

platform/chrome: fix kernel-doc warnings for panic notifier

2023-01-13T01:30:49+00:00

Fix the following kernel-doc warnings:

$ ./scripts/kernel-doc -none drivers/platform/chrome/*
drivers/platform/chrome/cros_ec_debugfs.c:54: warning: Function
parameter or member 'notifier_panic' not described in 'cros_ec_debugfs'

$ ./scripts/kernel-doc -none include/linux/platform_data/cros_ec_proto.h
include/linux/platform_data/cros_ec_proto.h:187: warning: Function
parameter or member 'panic_notifier' not described in 'cros_ec_device'

Cc: Rob Barnes 
Fixes: d90fa2c64d59 ("platform/chrome: cros_ec: Poll EC log on EC panic")
Signed-off-by: Tzung-Bi Shih 
Reviewed-by: Guenter Roeck 
Link: https://lore.kernel.org/r/20230111055728.708990-2-tzungbi@kernel.org

platform/chrome: cros_ec: Poll EC log on EC panic

2023-01-06T03:48:06+00:00

Add handler for CrOS EC panic events. When a panic is reported,
immediately poll for EC log.

This should result in the log leading to the EC panic being
preserved.

ACPI_NOTIFY_CROS_EC_PANIC is defined in coreboot at
https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src/ec/google/chromeec/acpi/ec.asl

Signed-off-by: Rob Barnes 
Reviewed-by: Prashant Malani 
Signed-off-by: Tzung-Bi Shih 
Link: https://lore.kernel.org/r/20230104011524.369764-2-robbarnes@google.com

platform/chrome: cros_ec_debugfs: Set PROBE_PREFER_ASYNCHRONOUS

2022-11-02T04:28:47+00:00

This driver takes on the order of 40ms to start on some systems. It
shouldn't have many cross-device dependencies to race with, nor racy
access to shared state with other drivers, so this should be a
relatively low risk change.

This driver was pinpointed as part of a survey of top slowest initcalls
(i.e., are built in, and probing synchronously) on a lab of ChromeOS
systems.

Signed-off-by: Brian Norris 
Signed-off-by: Tzung-Bi Shih 
Link: https://lore.kernel.org/r/20221101152132.v2.3.Ic9a4f378f73319da323cd55940012fa6b1de24f4@changeid