linux.git/drivers/pinctrl/sirf, branch v4.14

pinctrl: sirf: constify pinconf_ops, pinctrl_ops, and pinmux_ops structures

2017-08-22T12:39:08+00:00

These structures are only stored in fields of a pinctrl_desc
structure (pctlops and pmxops) that are const. Make the
structures const as well.

Done with the help of Coccinelle.

Signed-off-by: Julia Lawall 
Signed-off-by: Linus Walleij

pinctrl: sirf: atlas7: constify pinconf_ops, pinctrl_ops, and pinmux_ops structures

2017-08-22T12:38:46+00:00

This pinmux_ops structure is only stored in the const pmxops field
of a pinctrl_desc structure. Make the pinmux_ops structure const as
well.

Done with the help of Coccinelle.

Signed-off-by: Julia Lawall 
Signed-off-by: Linus Walleij

pinctrl: sirf: add static to local data

2017-08-14T13:01:59+00:00

Detected by sparse.

Signed-off-by: Masahiro Yamada 
Signed-off-by: Linus Walleij

pinctrl: sirf: atlas7: fix of_irq_get() error check

2017-08-14T13:01:02+00:00

of_irq_get() may return  any negative error number as well as 0 on failure,
while the driver only checks for -EPROBE_DEFER, blithely continuing with
the call to gpiochip_set_chained_irqchip() -- that function expects the
parent IRQ as *unsigned int*, so would probably do nothing  when a large
IRQ number resulting from a conversion of a negative error number is passed
to it, however passing 0 would probably work but the driver won't receive
valid GPIO bank interrupts.

Check for 'ret <= 0' instead and return -ENXIO from the driver's probe iff
of_irq_get() returned 0.

Fixes: f9367793293d ("pinctrl: sirf: add sirf atlas7 pinctrl and gpio support")
Signed-off-by: Sergei Shtylyov 
Signed-off-by: Linus Walleij

pinctrl: sirf: atlas7: Initialize GPIO offset

2017-08-14T13:01:02+00:00

The GPIO offset is never initialized, which means that it will end up
being zero as per the devm_kzalloc() of the parent structure.

Signed-off-by: Thierry Reding 
Signed-off-by: Linus Walleij

pinctrl: Convert to using %pOF instead of full_name

2017-08-14T13:01:02+00:00

Now that we have a custom printf format specifier, convert users of
full_name to use %pOF instead. This is preparation to remove storing
of the full path string for each node.

Signed-off-by: Rob Herring 
Cc: Linus Walleij 
Cc: Lee Jones 
Cc: Stefan Wahren 
Cc: Florian Fainelli 
Cc: Ray Jui 
Cc: Scott Branden 
Cc: bcm-kernel-feedback-list@broadcom.com
Cc: Tomasz Figa 
Cc: Sylwester Nawrocki 
Cc: Laurent Pinchart 
Cc: Barry Song 
Cc: linux-gpio@vger.kernel.org
Cc: linux-rpi-kernel@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: kernel@stlinux.com
Cc: linux-samsung-soc@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org
Acked-by: Krzysztof Kozlowski 
Acked-by: Ludovic Desroches 
Acked-by: Patrice Chotard 
Reviewed-by: Geert Uytterhoeven 
Acked-by: Geert Uytterhoeven 
Acked-by: Eric Anholt 
Signed-off-by: Linus Walleij

pinctrl: sirf: atlas7: make use of raw_spinlock variants

2017-03-16T15:39:15+00:00

The sirf atlas7 pinctrl drivers currently implement an irq_chip for
handling interrupts; due to how irq_chip handling is done, it's
necessary for the irq_chip methods to be invoked from hardirq context,
even on a a real-time kernel.  Because the spinlock_t type becomes a
"sleeping" spinlock w/ RT kernels, it is not suitable to be used with
irq_chips.

A quick audit of the operations under the lock reveal that they do only
minimal, bounded work, and are therefore safe to do under a raw spinlock.

Signed-off-by: Julia Cartwright 
Signed-off-by: Linus Walleij

Merge branch 'ib-pinctrl-genprops' into devel

2017-01-26T14:27:54+00:00

pinctrl: Widen the generic pinconf argument from 16 to 24 bits

2017-01-26T14:22:32+00:00

The current pinconf packed format allows only 16-bit argument limiting
the maximum value 65535. For most types this is enough. However,
debounce time can be in range of hundreths of milliseconds in case of
mechanical switches so we cannot represent the worst case using the
current format.

In order to support larger values change the packed format so that the
lower 8 bits are used as type which leaves 24 bits for the argument.
This allows representing values up to 16777215 and debounce times up to
16 seconds.

We also convert the existing users to use 32-bit integer when extracting
argument from the packed configuration value.

Signed-off-by: Mika Westerberg 
Reviewed-by: Andy Shevchenko 
Signed-off-by: Linus Walleij

pinctrl: sirf: atlas7: Improve code layout

2016-12-30T08:14:55+00:00

Add some tab in order to improve indentation.

Signed-off-by: Christophe JAILLET 
Signed-off-by: Linus Walleij