linux.git/drivers/pinctrl/ralink, branch v5.13

pinctrl: ralink: rt2880: avoid to error in calls is pin is already enabled

2021-06-07T07:08:53+00:00

In 'rt2880_pmx_group_enable' driver is printing an error and returning
-EBUSY if a pin has been already enabled. This begets anoying messages
in the caller when this happens like the following:

rt2880-pinmux pinctrl: pcie is already enabled
mt7621-pci 1e140000.pcie: Error applying setting, reverse things back

To avoid this just print the already enabled message in the pinctrl
driver and return 0 instead to not confuse the user with a real
bad problem.

Signed-off-by: Sergio Paracuellos 
Link: https://lore.kernel.org/r/20210604055337.20407-1-sergio.paracuellos@gmail.com
Signed-off-by: Linus Walleij

pinctrl: ralink: rt2880: fix '-Wmissing-prototypes' in init function

2021-01-04T14:40:02+00:00

Kernel test robot reported the following warning:
'warning: no previous prototype for 'rt2880_pinmux_init''.
This function is the entry point for the platform driver and
it is private to this driver. Hence declare it 'static' which is
the correct thing to do fixing also this warning.

Reported-by: kernel test robot 
Signed-off-by: Sergio Paracuellos 
Link: https://lore.kernel.org/r/20201228064727.30098-1-sergio.paracuellos@gmail.com
Signed-off-by: Linus Walleij

pinctrl: ralink: rt2880: use 'PTR_ERR_OR_ZERO'

2021-01-04T14:38:35+00:00

 Avoid some boilerplate code using 'PTR_ERR_OR_ZERO'
 in probe function.

Signed-off-by: Sergio Paracuellos 
Reviewed-by: Linus Walleij 
Link: https://lore.kernel.org/r/20201213161721.6514-8-sergio.paracuellos@gmail.com
Signed-off-by: Linus Walleij

pinctrl: ralink: rt2880: preserve error codes

2021-01-04T14:38:34+00:00

Some paths in probe function are returning '-EINVAL'
instead of preserve original code from called functions.
Change them to preserve all of them.

Reported-by: Dan Carpenter 
Signed-off-by: Sergio Paracuellos 
Reviewed-by: Linus Walleij 
Link: https://lore.kernel.org/r/20201213161721.6514-7-sergio.paracuellos@gmail.com
Signed-off-by: Linus Walleij

pinctrl: ralink: rt2880: delete not needed error message

2021-01-04T14:38:34+00:00

When '-ENOMEM' is returned there is not need at all to
add custom error messages. Hence delete it.

Reported-by: Dan Carpenter 
Signed-off-by: Sergio Paracuellos 
Reviewed-by: Linus Walleij 
Link: https://lore.kernel.org/r/20201213161721.6514-6-sergio.paracuellos@gmail.com
Signed-off-by: Linus Walleij

pinctrl: ralink: rt2880: add missing NULL check

2021-01-04T14:38:34+00:00

Memory is being requested to the kernel but there is
a missing check for NULL. Hence, add it.

Reported-by: Dan Carpenter 
Signed-off-by: Sergio Paracuellos 
Reviewed-by: Linus Walleij 
Link: https://lore.kernel.org/r/20201213161721.6514-5-sergio.paracuellos@gmail.com
Signed-off-by: Linus Walleij

pinctrl: ralink: rt2880: return proper error code

2021-01-04T14:38:34+00:00

Check for NULL shall return '-ENOMEM' instead of '-1'.

Reported-by: Dan Carpenter 

Signed-off-by: Sergio Paracuellos 
Reviewed-by: Linus Walleij 
Link: https://lore.kernel.org/r/20201213161721.6514-4-sergio.paracuellos@gmail.com
Signed-off-by: Linus Walleij

pinctrl: ralink: rt2880: avoid double pointer to simplify code

2021-01-04T14:38:34+00:00

Double pointer is being used and assigned in a bit dirty way to
assign functions in pinctrl. Instead of doing this just avoid it
and use directly 'p->func' instead.

Reported-by: Dan Carpenter 
Signed-off-by: Sergio Paracuellos 
Reviewed-by: Linus Walleij 
Link: https://lore.kernel.org/r/20201213161721.6514-3-sergio.paracuellos@gmail.com
Signed-off-by: Linus Walleij

pinctrl: ralink: add a pinctrl driver for the rt2880 family

2020-12-08T08:58:01+00:00

These Socs have 1-3 banks of 8-32 gpios. Rather then setting the muxing of each
pin individually, these socs have mux groups that when set will effect 1-N pins.
Pin groups have a 2, 4 or 8 different muxes.

Acked-by: Linus Walleij 
Signed-off-by: Sergio Paracuellos 
Link: https://lore.kernel.org/r/20201208075523.7060-3-sergio.paracuellos@gmail.com
Signed-off-by: Greg Kroah-Hartman