linux.git/drivers/pinctrl/pinctrl-single.c, branch v4.13

pinctrl: single: use of_device_get_match_data() to get soc data

2017-05-29T08:18:46+00:00

Use of_device_get_match_data() instead of of_match_device().
It allows us to remove the forward declaration of pcs_of_match.

Signed-off-by: Masahiro Yamada 
Acked-by: Tony Lindgren 
Signed-off-by: Linus Walleij

pinctrl: core: Fix pinctrl_register_and_init() with pinctrl_enable()

2017-04-06T23:08:08+00:00

Recent pinctrl changes to allow dynamic allocation of pins exposed one
more issue with the pinctrl pins claimed early by the controller itself.
This caused a regression for IMX6 pinctrl hogs.

Before enabling the pin controller driver we need to wait until it has
been properly initialized, then claim the hogs, and only then enable it.

To fix the regression, split the code into pinctrl_claim_hogs() and
pinctrl_enable(). And then let's require that pinctrl_enable() is always
called by the pin controller driver when ready after calling
pinctrl_register_and_init().

Depends-on: 950b0d91dc10 ("pinctrl: core: Fix regression caused by delayed
work for hogs")
Fixes: df61b366af26 ("pinctrl: core: Use delayed work for hogs")
Fixes: e566fc11ea76 ("pinctrl: imx: use generic pinctrl helpers for
managing groups")
Cc: Haojian Zhuang 
Cc: Masahiro Yamada 
Cc: Mika Penttilä 
Cc: Mika Westerberg 
Cc: Nishanth Menon 
Cc: Shawn Guo 
Cc: Stefan Agner 
Tested-by: Geert Uytterhoeven 
Tested-by: Gary Bisson 
Tested-by: Fabio Estevam 
Signed-off-by: Tony Lindgren 
Signed-off-by: Linus Walleij

Merge branch 'ib-pinctrl-genprops' into devel

2017-01-26T14:27:54+00:00

pinctrl: Widen the generic pinconf argument from 16 to 24 bits

2017-01-26T14:22:32+00:00

The current pinconf packed format allows only 16-bit argument limiting
the maximum value 65535. For most types this is enough. However,
debounce time can be in range of hundreths of milliseconds in case of
mechanical switches so we cannot represent the worst case using the
current format.

In order to support larger values change the packed format so that the
lower 8 bits are used as type which leaves 24 bits for the argument.
This allows representing values up to 16777215 and debounce times up to
16 seconds.

We also convert the existing users to use 32-bit integer when extracting
argument from the packed configuration value.

Signed-off-by: Mika Westerberg 
Reviewed-by: Andy Shevchenko 
Signed-off-by: Linus Walleij

pinctrl: core: Fix regression caused by delayed work for hogs

2017-01-13T15:25:17+00:00

Commit df61b366af26 ("pinctrl: core: Use delayed work for hogs") caused a
regression at least with sh-pfc that is also a GPIO controller as
noted by Geert Uytterhoeven .

As the original pinctrl_register() has issues calling pin controller
driver functions early before the controller has finished registering,
we can't just revert commit df61b366af26. That would break the drivers
using GENERIC_PINCTRL_GROUPS or GENERIC_PINMUX_FUNCTIONS.

So let's fix the issue with the following steps as a single patch:

1. Revert the late_init parts of commit df61b366af26.

   The late_init clearly won't work and we have to just give up
   on fixing pinctrl_register() for GENERIC_PINCTRL_GROUPS and
   GENERIC_PINMUX_FUNCTIONS.

2. Split pinctrl_register() into two parts

   By splitting pinctrl_register() into pinctrl_init_controller()
   and pinctrl_create_and_start() we have better control over when
   it's safe to call pinctrl_create().

3. Introduce a new pinctrl_register_and_init() function

   As suggested by Linus Walleij , we
   can just introduce a new function for the controllers that need
   pinctrl_create() called later.

4. Convert the four known problem cases to use new function

   Let's convert pinctrl-imx, pinctrl-single, sh-pfc and ti-iodelay
   to use the new function to fix the issues. The rest of the drivers
   can be converted later. Let's also update Documentation/pinctrl.txt
   accordingly because of the known issues with pinctrl_register().

Fixes: df61b366af26 ("pinctrl: core: Use delayed work for hogs")
Reported-by: Geert Uytterhoeven 
Cc: Gary Bisson 
Signed-off-by: Tony Lindgren 
Tested-by: Geert Uytterhoeven 
Signed-off-by: Linus Walleij

pinctrl: single: Use generic pinmux helpers for managing functions

2017-01-03T08:26:19+00:00

We can now drop the driver specific code for managing functions.

Signed-off-by: Tony Lindgren 
[Replaces GENERIC_PINMUX with GENERIC_PINMUX_FUNCTIONS]
Signed-off-by: Linus Walleij

pinctrl: single: Use generic pinctrl helpers for managing groups

2017-01-03T08:26:19+00:00

We can now drop the driver specific code for managing groups.

Signed-off-by: Tony Lindgren 
Signed-off-by: Linus Walleij

pinctrl: single: fix spelling mistakes on "Ivalid"

2016-12-30T13:00:29+00:00

Trivial fixe to spelling mistake "Ivalid" to "Invalid" in
dev_err  error message.

Signed-off-by: Colin Ian King 
Acked-by: Tony Lindgren 
Signed-off-by: Linus Walleij

pinctrl: single: Fix a couple error codes

2016-11-16T19:56:19+00:00

We should return -ENOMEM instead of success if pcs_add_function() fails.

Signed-off-by: Dan Carpenter 
Acked-by: Tony Lindgren 
Signed-off-by: Linus Walleij

pinctrl: single: search for the bits property when parsing bits

2016-11-11T20:29:37+00:00

The pcs_parse_bits_in_pinctrl_entry function should search
for the "pinctrl-single,bits" and not "pinctrl-single,pins"

Signed-off-by: Axel Haslam 
Acked-by: Tony Lindgren 
Signed-off-by: Linus Walleij