linux.git/drivers/pinctrl/intel, branch v5.9-rc2

pinctrl: intel: Add Intel Emmitsburg pin controller support

2020-07-21T08:44:21+00:00

This driver adds pinctrl/GPIO support for Intel Emmitsburg PCH. The
GPIO controller is based on the next generation GPIO hardware but still
compatible with the one supported by the Intel core pinctrl/GPIO driver.

Signed-off-by: Andy Shevchenko 
Reviewed-by: Linus Walleij 
Acked-by: Mika Westerberg

pinctrl: baytrail: Use fallthrough pseudo-keyword

2020-07-19T10:01:56+00:00

Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1].

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Signed-off-by: Gustavo A. R. Silva 
Signed-off-by: Andy Shevchenko

pinctrl: tigerlake: Add support for Tiger Lake-H

2020-06-29T14:39:06+00:00

Intel Tiger Lake-H has different pin layout than the -LP variant
so add support for this to the existing Tiger Lake driver.

Signed-off-by: Mika Westerberg 
Signed-off-by: Andy Shevchenko

pinctrl: merrifield: Add I²S bus 2 pins to groups and functions

2020-06-29T14:39:06+00:00

It is useful to control I²S bus 2 pins if we would like to connect
an audio codec.

Reported-by: mouse 
Reported-by: Pierre-Louis Bossart 
Signed-off-by: Andy Shevchenko 
Acked-by: Mika Westerberg

pinctrl: merrifield: Update pin names in accordance with official list

2020-06-22T16:04:38+00:00

Some of the pin names were provided officially to the customers
in different spelling. We update pin names in accordance with
the official list.

Signed-off-by: Andy Shevchenko

pinctrl: baytrail: Fix pin being driven low for a while on gpiod_get(..., GPIOD_OUT_HIGH)

2020-06-22T10:55:36+00:00

The pins on the Bay Trail SoC have separate input-buffer and output-buffer
enable bits and a read of the level bit of the value register will always
return the value from the input-buffer.

The BIOS of a device may configure a pin in output-only mode, only enabling
the output buffer, and write 1 to the level bit to drive the pin high.
This 1 written to the level bit will be stored inside the data-latch of the
output buffer.

But a subsequent read of the value register will return 0 for the level bit
because the input-buffer is disabled. This causes a read-modify-write as
done by byt_gpio_set_direction() to write 0 to the level bit, driving the
pin low!

Before this commit byt_gpio_direction_output() relied on
pinctrl_gpio_direction_output() to set the direction, followed by a call
to byt_gpio_set() to apply the selected value. This causes the pin to
go low between the pinctrl_gpio_direction_output() and byt_gpio_set()
calls.

Change byt_gpio_direction_output() to directly make the register
modifications itself instead. Replacing the 2 subsequent writes to the
value register with a single write.

Note that the pinctrl code does not keep track internally of the direction,
so not going through pinctrl_gpio_direction_output() is not an issue.

This issue was noticed on a Trekstor SurfTab Twin 10.1. When the panel is
already on at boot (no external monitor connected), then the i915 driver
does a gpiod_get(..., GPIOD_OUT_HIGH) for the panel-enable GPIO. The
temporarily going low of that GPIO was causing the panel to reset itself
after which it would not show an image until it was turned off and back on
again (until a full modeset was done on it). This commit fixes this.

This commit also updates the byt_gpio_direction_input() to use direct
register accesses instead of going through pinctrl_gpio_direction_input(),
to keep it consistent with byt_gpio_direction_output().

Note for backporting, this commit depends on:
commit e2b74419e5cc ("pinctrl: baytrail: Replace WARN with dev_info_once
when setting direct-irq pin to output")

Cc: stable@vger.kernel.org
Fixes: 86e3ef812fe3 ("pinctrl: baytrail: Update gpio chip operations")
Signed-off-by: Hans de Goede 
Acked-by: Mika Westerberg 
Signed-off-by: Andy Shevchenko

pinctrl: baytrail: Drop no-op ACPI_PTR() call

2020-06-22T10:55:36+00:00

Since we dependent on ACPI, there is no need to use ACPI_PTR()
which is a no-op in this case.

Signed-off-by: Andy Shevchenko 
Acked-by: Mika Westerberg

pinctrl: lynxpoint: Drop no-op ACPI_PTR() call

2020-06-22T10:55:36+00:00

Since we dependent on ACPI, there is no need to use ACPI_PTR()
which is a no-op in this case.

Signed-off-by: Andy Shevchenko 
Acked-by: Mika Westerberg

pinctrl: lynxpoint: Introduce helpers to enable or disable input

2020-06-22T08:01:59+00:00

Introduce couple of helpers to enable or disable input. i.e.
lp_gpio_enable_input() and lp_gpio_disable_input().

Signed-off-by: Andy Shevchenko 
Acked-by: Mika Westerberg

pinctrl: lynxpoint: Make use of for_each_requested_gpio()

2020-06-22T08:01:59+00:00

Make use of for_each_requested_gpio() instead of home grown analogue.

Signed-off-by: Andy Shevchenko 
Acked-by: Mika Westerberg