linux.git/drivers/pinctrl/freescale, branch v4.2

Subject: pinctrl: imx1-core: Fix debug output in .pin_config_set callback

2015-07-20T09:01:53+00:00

imx1_pinconf_set assumes that the array of pins in struct
imx1_pinctrl_soc_info can be indexed by pin id to get the
pinctrl_pin_desc for a pin. This used to be correct up to commit
607af165c047 which removed some entries from the array and so made it
wrong to access the array by pin id.

The result of this bug is a wrong pin name in the output for small pin
ids and an oops for the bigger ones.

This patch is the result of a discussion that includes patches by Markus
Pargmann and Chris Ruehl.

Fixes: 607af165c047 ("pinctrl: i.MX27: Remove nonexistent pad definitions")
Cc: stable@vger.kernel.org
Reported-by: Chris Ruehl 
Signed-off-by: Uwe Kleine-König 
Reviewed-by: Markus Pargmann 
Signed-off-by: Linus Walleij

pinctrl: make pinctrl_register() return proper error code

2015-06-10T12:49:52+00:00

Currently, pinctrl_register() just returns NULL on error, so the
callers can not know the exact reason of the failure.

Some of the pinctrl drivers return -EINVAL, some -ENODEV, and some
-ENOMEM on error of pinctrl_register(), although the error code
might be different from the real cause of the error.

This commit reworks pinctrl_register() to return the appropriate
error code and modifies all of the pinctrl drivers to use IS_ERR()
for the error checking and PTR_ERR() for getting the error code.

Signed-off-by: Masahiro Yamada 
Acked-by: Patrice Chotard 
Acked-by: Thierry Reding 
Acked-by: Heiko Stuebner 
Tested-by: Mika Westerberg 
Acked-by: Mika Westerberg 
Acked-by: Lee Jones 
Acked-by: Sören Brinkmann 
Acked-by: Laurent Pinchart 
Acked-by: Ray Jui 
Acked-by: Antoine Tenart 
Acked-by: Hongzhou Yang 
Acked-by: Wei Chen 
Signed-off-by: Linus Walleij

pinctrl: Remove .owner field

2015-06-04T08:12:42+00:00

platform_driver does not need to set the owner field, as it will be
populated by the driver core, so just remove it.

The semantic patch that makes this change is available
in scripts/coccinelle/api/platform_no_drv_owner.cocci.

Signed-off-by: Fabio Estevam 
Signed-off-by: Linus Walleij

pinctrl: imx: Allow parsing DT without function nodes

2015-05-06T13:30:24+00:00

The old format to define pinctrl settings for imx in DT has two
hierarchy levels. The first level are function device nodes. The second
level are pingroups which contain a property fsl,pins. The original
intention was to define all pin functions in a single dtsi file and just
reference the correct ones in the board files.
This idea was rejected some time ago leading to the current design to
have all the pinfunctions defined in the board files. So we don't need
the function device nodes anymore.

This patch changes the pinctrl driver to accept devicetrees which do not
have the first hierarchy level, function device nodes. For example
karo-tx25 already has such a devicetree. Old devicetrees are still
parsed and supported.

Signed-off-by: Markus Pargmann 
Acked-by: Uwe Kleine-König 
Acked-by: Shawn Guo 
Signed-off-by: Linus Walleij

pinctrl: add imx7d support

2015-05-06T12:45:19+00:00

Add i.MX7D pinctrl driver support

Signed-off-by: Frank Li 
Signed-off-by: Anson Huang 
Signed-off-by: Linus Walleij

pinctrl: fsl: imx: Check for 0 config register

2015-04-07T13:11:00+00:00

0 is used in all pinfunction definitions when a config register is not
available, for example imx25-pinfunc.h. If a configuration value is used
for such a pinfunction the driver will always write it to the
configuration register if it is not -1. For a 0 configuration register
the configuration value is written to offset 0x0. This can lead to a
crashing/hanging system without any warning message.

This patch checks for 0 config register and sets the internal value to
-1. If the configuration value is not NO_PADCTL this leads to an error
message that applying the configuration failed.

Signed-off-by: Markus Pargmann 
Acked-by: Uwe Kleine-König 
Tested-by: Stefan Agner 
Acked-by: Stefan Agner 
Signed-off-by: Linus Walleij

pinctrl: imx: do not implicitly set pin regs to -1

2015-03-18T01:02:11+00:00

Commit 3dac1918a491 ("pinctrl: imx: detect uninitialized pins") needs
the values in struct imx_pin_reg to be -1. This has been done in a
rather unorthodox way by setting the memory to 0xff using memset...
Use a proper for loop to initialize the whole array with -1.

Signed-off-by: Stefan Agner 
Acked-by: Uwe Kleine-König 
Acked-by: Shawn Guo 
Signed-off-by: Linus Walleij

pinctrl: freescale: make of_device_id array const

2015-03-09T17:10:56+00:00

Make of_device_id array const.

Signed-off-by: Sanjeev Sharma 
Signed-off-by: Linus Walleij

pinctrl: imx25: fix numbering for pins

2015-02-03T13:02:55+00:00

The pin id for a given tuple listed in a fsl,pins property is calculated
by dividing the first entry (which is also a register offset) by 4.
As the first available register is at offset 0x8 and configures the pad
MX25_PAD_A10 the right id for this pin is 2. All other pins are off by
one, too.

This patch drops the definition MX25_PAD_RESERVE1 (together with its
only use) and decrements all following values by 1.

Fixes: b4a87c9b966f ("pinctrl: pinctrl-imx: add imx25 pinctrl driver")
Signed-off-by: Uwe Kleine-KÃ¶nig 
Tested-by: Fabio Estevam 
Signed-off-by: Linus Walleij

pinctrl: pinctrl-imx: don't use invalid value of conf_reg

2015-02-03T12:57:52+00:00

The right check for conf_reg to be invalid it testing against -1 not 0
as is done in the rest of the driver.

This fixes an oops that can be triggered by:

	cat /sys/kernel/debug/pinctrl/43fac000.iomuxc/*

Fixes: ae75ff814538 ("pinctrl: pinctrl-imx: add imx pinctrl core driver")
Signed-off-by: Uwe Kleine-KÃ¶nig 
Signed-off-by: Linus Walleij