linux.git/drivers/phy, branch v4.9-rc2

phy-twl4030-usb: initialize charging-related stuff via pm_runtime

2016-09-14T05:29:12+00:00

twl4030_phy_power_on() initializes some bits which are required for
charging. As they are not set in twl4030_usb_runtime_resume()
a call to pm_runtime_get_sync() is not sufficient to enable charging.

This patch moves the initialization to twl4030_usb_runtime_resume()
so everything needed for charging is initialized upon
pm_runtime_get_sync().

That also gives improved possibilities to debug problems in that area
because the relevant parts can be checked separately. Charging can be
enabled without having the musb subsystem active.

As a side effect this hides some bugs in musb which causes
unbalanced calls to phy_power_off()/phy_power_on() so that
phy->power_count becomes -1.

The result is that e.g. the GTA04 phone (dm3730 + twl4030) works
finally as a usb gadget again and charging is working.

Signed-off-by: Andreas Kemnade 
Acked-by: Tony Lindgren 
Signed-off-by: Kishon Vijay Abraham I

phy-twl4030-usb: better handle musb_mailbox() failure

2016-09-14T05:29:11+00:00

setting twl->linkstat = MUSB_UNKNOWN upon error in musb_mailbox as
introduced in
commit 12b7db2bf8b8 ("usb: musb: Return error value from musb_mailbox")
causes twl4030_usb_irq() to not detect a state change form cable connected
to cable disconnected after such an error so that
pm_runtime_put_autosuspend() will not be called and the usage counter
gets unbalanced. Such errors happen e.g. if the omap2430 module is not
(yet) loaded during plug/unplug events.

This patch introduces a flag instead that indicates whether there is
information for the musb_mailbox pending and calls musb_mailbox() if
that flag is set.

Signed-off-by: Andreas Kemnade 
Tested-by: Tony Lindgren 
Signed-off-by: Kishon Vijay Abraham I

phy: sun4i-usb: Use spinlock to guard phyctl register access

2016-09-10T12:13:38+00:00

The musb driver calls into this phy driver to disable/enable squelch
detection. This function was introduced in 24fe86a617c5 ("phy: sun4i-usb:
Add a sunxi specific function for setting squelch-detect"). This
function in turn calls sun4i_usb_phy_write, which uses a mutex to
guard the common access register. Unfortunately musb does this
in atomic context, which results in the following warning with lock
debugging enabled:

BUG: sleeping function called from invalid context at kernel/locking/mutex.c:97
in_atomic(): 1, irqs_disabled(): 128, pid: 96, name: kworker/0:2
CPU: 0 PID: 96 Comm: kworker/0:2 Not tainted 4.8.0-rc4-00181-gd502f8ad1c3e #13
Hardware name: Allwinner sun8i Family
Workqueue: events musb_deassert_reset
[] (unwind_backtrace) from [] (show_stack+0xb/0xc)
[] (show_stack) from [] (dump_stack+0x67/0x74)
[] (dump_stack) from [] (mutex_lock+0x15/0x2c)
[] (mutex_lock) from [] (sun4i_usb_phy_write+0x39/0xec)
[] (sun4i_usb_phy_write) from [] (musb_port_reset+0xfb/0x184)
[] (musb_port_reset) from [] (musb_deassert_reset+0x1f/0x2c)
[] (musb_deassert_reset) from [] (process_one_work+0x129/0x2b8)
[] (process_one_work) from [] (worker_thread+0xf3/0x424)
[] (worker_thread) from [] (kthread+0xa1/0xb8)
[] (kthread) from [] (ret_from_fork+0x11/0x20)

Since the register access is mmio, we can use a spinlock to guard this
specific access, rather than the mutex that guards the entire phy.

Fixes: ba4bdc9e1dc0 ("PHY: sunxi: Add driver for sunxi usb phy")
Cc: Hans de Goede 
Cc: stable@vger.kernel.org
Signed-off-by: Chen-Yu Tsai 
Reviewed-by: Hans de Goede 
Signed-off-by: Kishon Vijay Abraham I

phy: rockchip-usb: use rockchip_usb_phy_reset to reset phy during wakeup

2016-09-10T12:01:40+00:00

It is a hardware bug in RK3288, the only way to solve it is to
reset the phy.

Signed-off-by: Randy Li 
Signed-off-by: Kishon Vijay Abraham I

phy: Add reset callback

2016-09-10T12:01:39+00:00

The only use for this is for solving a hardware design problem in
usb of Rockchip RK3288.

Signed-off-by: Randy Li 
Reviewed-by: Heiko Stuebner 
Signed-off-by: Kishon Vijay Abraham I

phy-sun4i-usb: Warn when external vbus is detected

2016-09-10T11:45:19+00:00

Warn when external vbus is detected when we're trying to enable our
own vbus.

Signed-off-by: Hans de Goede 
Signed-off-by: Kishon Vijay Abraham I

phy-sun4i-usb: Add support for phy_set_mode

2016-09-10T11:45:19+00:00

Together with some musb sunxi glue changes this allows run-time dr_mode
switching support via the "mode" musb sysfs attribute.

Signed-off-by: Hans de Goede 
Signed-off-by: Kishon Vijay Abraham I

phy-sun4i-usb: Simplify missing dr_mode handling

2016-09-10T11:45:19+00:00

If we cannot get dr_mode or no id gpio is specified simply assume
peripheral mode, as this is always safe.

Signed-off-by: Hans de Goede 
Signed-off-by: Kishon Vijay Abraham I

phy-sun4i-usb: Refactor forced session ending

2016-09-10T11:45:19+00:00

The phy-sun4i-usb code supports forced ending a session on systems
which lack Vbus detection, to allow switching between host and peripheral
mode on such systems.

Role switching via the musb driver "mode" sysfs attribute requires force
ending the session too. This commit refactors the code to allow other
parts of the phy-sun4i-usb code to request a forced session end.

Signed-off-by: Hans de Goede 
Signed-off-by: Kishon Vijay Abraham I

phy-sun4i-usb: Use bool where appropriate

2016-09-10T11:45:19+00:00

We're using bool as true/false type in most places in phy-sun4i-usb.c
for consistency fixup the remaining uses of ints which are ever only
0 or 1 to be bools too.

Signed-off-by: Hans de Goede 
Signed-off-by: Kishon Vijay Abraham I