linux.git/drivers/pci/hotplug/shpchp_ctrl.c, branch v2.6.17

[PATCH] shpchp: cleanup bus speed handling

2006-03-23T22:35:16+00:00

The code related to handling bus speed in SHPCHP driver is
unnecessarily complex. This patch cleans up and simplify that.

Signed-off-by: Kenji Kaneshige 
Signed-off-by: Greg Kroah-Hartman

[PATCH] shpchp: Fix slot state handling

2006-03-23T22:35:13+00:00

Current SHPCHP driver doesn't care about the confliction between
hotplug operation via sysfs and hotplug operation via attention
button. So if those ware conflicted, slot could be an unexpected
state.

This patch changes SHPCHP driver to handle slot state properly. With
this patch, slot events are handled according to the current slot
state as shown at the Table below.

		Table. Slot States and Event Handling
=========================================================================
Slot State		Event and Action
=========================================================================
STATIC			- Go to POWERON state if user initiates
(Slot enabled,		  insertion request via sysfs
 Slot disabled)		- Go to POWEROFF state if user initiates removal
			  request via sysfs
			- Go to BLINKINGON state if user presses
			  attention button when the slot is disabled
			- Go to BLINKINGOFF state if user presses
			  attention button when the slot is enabled

[PATCH] shpchp: event handling rework

2006-03-23T22:35:13+00:00

The event handler of SHPCHP driver is unnecessarily very complex. In
addition, current event handler can only a fixed number of events at
the same time, and some of events would be lost if several number of
events happened at the same time.

This patch simplify the event handler by using 'work queue', and it
also fix the above-mentioned issue.

Signed-off-by: Kenji Kaneshige 
Signed-off-by: Kristen Carlson Accardi 
Signed-off-by: Greg Kroah-Hartman

[PATCH] shpchp: Remove unused wait_for_ctrl_irq

2006-03-23T22:35:13+00:00

The wait_for_ctrl_irq() function in SHPCHP driver is no longer needed.
This patch removes that. This patch has no functional change.

Signed-off-by: Kenji Kaneshige 
Signed-off-by: Kristen Carlson Accardi 
Signed-off-by: Greg Kroah-Hartman

[PATCH] shpchp - bugfix: add missing serialization

2006-03-23T22:35:11+00:00

Current shpchp driver might cause system panic because of lack of
serialization. It can be reproduced very easily by the following
operation.

	# cd /sys/bus/pci/slots/
	# while true; do echo 0 > power ; echo 1 > power ; done &
	# while true; do echo 0 > power ; echo 1 > power ; done &

This patch fixes this issue by changing shpchp to get appropreate
semaphore for hot-plug operation.

Signed-off-by: Kenji Kaneshige 
Signed-off-by: Greg Kroah-Hartman

[PATCH] shpchp - cleanup check command status

2006-03-23T22:35:11+00:00

This patch cleanups codes that check the command status. For this, it
introduces a new semaphore "cmd_sem" for each controller.

Signed-off-by: Kenji Kaneshige 
Signed-off-by: Greg Kroah-Hartman

[PATCH] shpchp - cleanup controller list

2006-03-23T22:35:11+00:00

This patch changes SHPCHP driver to use list_head structure for
managing controller list.

Signed-off-by: Kenji Kaneshige 
Signed-off-by: Greg Kroah-Hartman

[PATCH] PCI hotplug: convert semaphores to mutex

2006-03-23T22:35:10+00:00

semaphore to mutex conversion.

the conversion was generated via scripts, and the result was validated
automatically via a script as well.

build tested with allyesconfig.

Signed-off-by: Ingo Molnar 
Signed-off-by: Greg Kroah-Hartman

[PATCH] PCI Hotplug: shpchp: AMD POGO errata fix

2006-02-01T02:00:12+00:00

This patch fixes the AMD POGO errata on the hotplug controller where the
platform will lock up or reboot if PERR/SERR generation is enabled and a
slot is sent an enable command.  This fix disables PERR/SERR generation
before a slot is sent the enable command by first saving related
registers, turning off SERR/PERR generation, enabling the slot, then
restoring the registers.

Signed-off-by: David Keck 
Cc: Kristen Accardi 
Signed-off-by: Greg Kroah-Hartman

[PATCH] shpchp: fix improper wait for command completion

2006-01-09T20:13:17+00:00

Current SHPCHP driver uses msleep_interruptible() function to wait for
a command completion event. But I think this would cause an unnecessary
long wait until timeout, if command completion interrupt came before
task state was changed to TASK_INTERRUPTIBLE. This patch fixes this
issue. With this patch, command completion becomes faster as follows:

o Without this patch

	# time echo 1 > power

	real    0m4.708s
	user    0m0.000s
	sys     0m0.524s

o With this patch

	# time echo 1 > power

	real    0m2.221s
	user    0m0.000s
	sys     0m0.532s

Signed-off-by: Kenji Kaneshige 
Signed-off-by: Greg Kroah-Hartman