linux.git/drivers/pci/hotplug/pciehp_ctrl.c, branch v2.6.27

pciehp: move msleep after power off

2008-05-27T22:43:33+00:00

According to the PCI Express specification, we must wait for at least
1 second after turning power off before taking any action that relies
on power having been removed from the slot/adapter. For this, current
pciehp wait for 1 second after issuing the power off command in
hpc_power_off_slot() function. But waiting for 1 second in
hpc_power_off_slot() can make pciehp probing slow-down because pciehp
probe code calls hpc_power_off_slot() if the slot is not occupied just
in case. We don't need to wait for 1 second at the pciehp probe time
because there is no action on that empty slot. So move 1 second wait
from hpc_power_off_slot() to the caller of hpc_power_off_slot().

Signed-off-by: Kenji Kaneshige 
Signed-off-by: Kristen Carlson Accardi 
Signed-off-by: Jesse Barnes

pciehp: fix NULL dereference in interrupt handler

2008-05-27T22:43:08+00:00

Fix the following NULL dereference problem reported from Pierre Ossman
and Ingo Molnar.

pciehp: HPC vendor_id 8086 device_id 27d0 ss_vid 0 ss_did 0
pciehp: pciehp_find_slot: slot (device=0x0) not found
BUG: unable to handle kernel NULL pointer dereference at 0000000000000070
IP: [] pciehp_handle_presence_change+0x7e/0x113
PGD 0
Oops: 0000 [1]
CPU 0
Modules linked in:
Pid: 1, comm: swapper Tainted: G        W 2.6.26-rc3-sched-devel.git-00001-g2b99b26-dirty #170
RIP: 0010:[]  [] pciehp_handle_presence_change+0x7e/0x113
RSP: 0000:ffff81003f83fbb0  EFLAGS: 00010046
RAX: 0000000000000039 RBX: 0000000000000000 RCX: 0000000000000000
RDX: 0000000000000000 RSI: 0000000000000001 RDI: 0000000000000046
RBP: ffff81003f83fbd0 R08: 0000000000000001 R09: ffffffff80245103
R10: 0000000000000020 R11: 0000000000000000 R12: ffff81003ea53a30
R13: 0000000000000000 R14: 0000000000000011 R15: ffffffff80495926
FS:  0000000000000000(0000) GS:ffffffff80be7400(0000) knlGS:0000000000000000
CS:  0010 DS: 0018 ES: 0018 CR0: 000000008005003b
CR2: 0000000000000070 CR3: 0000000000201000 CR4: 00000000000006a0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
Process swapper (pid: 1, threadinfo ffff81003f83e000, task ffff81003f840000)
Stack:  0000000000000008 ffff81003f83fbf6 ffff81003ea53a30 0000000000000008
 ffff81003f83fc10 ffffffff80495ab4 0000000000000011 0000000000000002
 0000000000000202 0000000000000202 00000000fffffff4 ffff81003ea53a30
Call Trace:
 [] pcie_isr+0x18e/0x1bc
 [] request_irq+0x106/0x12f
 [] pcie_init+0x15e/0x6cc
 [] pciehp_probe+0x64/0x541
 [] pcie_port_probe_service+0x4c/0x76
 [] driver_probe_device+0xd4/0x1f0
 [] __driver_attach+0x7c/0x7e
 [] ? __driver_attach+0x0/0x7e
 [] bus_for_each_dev+0x53/0x7d
 [] driver_attach+0x1c/0x1e
 [] bus_add_driver+0xdd/0x25b
 [] ? pcied_init+0x0/0x8b
 [] driver_register+0x5f/0x13e
 [] ? pcied_init+0x0/0x8b
 [] pcie_port_service_register+0x47/0x49
 [] pcied_init+0x15/0x8b
 [] kernel_init+0x75/0x243
 [] ? _spin_unlock_irq+0x2b/0x3a
 [] ? finish_task_switch+0x57/0x9a
 [] child_rip+0xa/0x12
 [] ? restore_args+0x0/0x30
 [] ? kernel_init+0x0/0x243
 [] ? child_rip+0x0/0x12

Code: 83 80 00 00 00 48 39 f0 75 e1 0f b6 c9 48 c7 c2 00 0e 8d 80 48 c7 c6 8a 60 a6 80 48 c7 c7 10 db a8 80 31 c0 e8 3f 8d d9 ff 31 db <48> 8b 43 70 48 8d 75 ef 48 89 df ff 50 30 80 7d ef 00 74 37 48
RIP  [] pciehp_handle_presence_change+0x7e/0x113
 RSP 
CR2: 0000000000000070
Kernel panic - not syncing: Fatal exception

The situation under which it occurs is hw and timing related: it appears
to happen on a system that has PCI hotplug hardware but with no active
hotplug cards, and another interrupt in the same (shared) IRQ line
arrives too early, before the hotplug-slot entry has been set up - as
triggered by CONFIG_DEBUG_SHIRQ=y:

This patch contains the following two fixes.

(1) Clear all events bits in Slot Status register to prevent the pciehp
    driver from detecting the spurious events that would have been occur
    before pciehp loading.

(2) Add check whether slot initialization had been already done.

This is short term fix. We need more structural fixes to install
interrupt handler after slot initialization is done.

Signed-off-by: Ingo Molnar 
Signed-off-by: Kenji Kaneshige 
Signed-off-by: Kristen Carlson Accardi 
Signed-off-by: Jesse Barnes

pciehp: Fix wrong slot capability check

2008-04-25T21:39:06+00:00

Current pciehp saves only 8bits of Slot Capability registers in
ctrl->ctrlcap. But it refers more than 8bit for checking EMI capability.
It is clearly a bug and EMI would never work. To fix this problem,
this patch saves full Slot Capability contens in ctrl->slot_cap. It also
reduce the redundant reads of Slot Capability register. And this pach
also cleans up the macros to check the slot capabilitys (e.g. MRL_SENS(),
and so on).

Signed-off-by: Kenji Kaneshige 
Signed-off-by:  Kristen Carlson Accardi 
Signed-off-by: Jesse Barnes

PCI: replace remaining FUNCTION occurrences

2008-04-21T04:47:09+00:00

__FUNCTION__ is gcc-specific, use __func__

Signed-off-by: Harvey Harrison 
Signed-off-by: Greg Kroah-Hartman

pciehp: wait for 1000ms before LED operation after power off

2008-02-01T23:04:28+00:00

After turning power off, we must wait for at least 1 second *before*
LED operation.

Signed-off-by: Kenji Kaneshige 
Signed-off-by: Kristen Carlson Accardi 
Signed-off-by: Greg Kroah-Hartman

PCI Hotplug: pciehp: remove needless hp_slot calculation

2008-02-01T23:04:24+00:00

Remove needless hp_slot calculation. This has no functional changes.

Signed-off-by: Kenji Kaneshige 
Signed-off-by: Kristen Carlson Accardi 
Signed-off-by: Greg Kroah-Hartman

PCIE: Make use of the previously split out pcie_init_enable_events() function

2008-02-01T23:04:23+00:00

Make use of the previously split out pcie_init_enable_events() function
to reinitialize the hotplug hardware on resume from suspend, but only
when pciehp_force==1.  Otherwise behaviour is unmodified.

Signed-off-by: Mark Lord 
Signed-off-by: Kristen Carlson Accardi 
Cc: Andrew Morton 
Cc: Theodore Ts'o 
Signed-off-by: Greg Kroah-Hartman

PCIE: fix PCIe Hotplug so that it works with ExpressCard slots on Dell notebooks (and others?) in conjunction with modparam of pciehp_force=1.

2008-02-01T23:04:22+00:00

Fix pciehp_probe() to deal with ExpressCard cards
that were inserted prior to the driver being loaded.

Signed-off-by: Mark Lord 
Signed-off-by: Kristen Carlson Accardi 
Cc: Andrew Morton 
Cc: Theodore Ts'o 
Signed-off-by: Greg Kroah-Hartman

pci hotplug: kernel-doc fixes

2007-11-28T22:35:26+00:00

acpiphp.h: not using kernel-doc, so change /** to /*
acpiphp_core.c: lots of kernel-doc cleanups
acpiphp_glue.c: lots of kernel-doc cleanups
acpiphp_ibm.c: lots of kernel-doc cleanups
cpqphp_core.c: lots of kernel-doc cleanups
cpqphp_ctrl.c: lots of kernel-doc cleanups
fakephp.c:  correct kernel-doc notation
pciehp_ctrl.c: correct kernel-doc notation
rpadlpar_core.c: correct function names & kernel-doc notation
rpaphp_core.c: correct kernel-doc notation
shpchp_ctrl.c: correct kernel-doc notation

Signed-off-by: Randy Dunlap 
Cc: Kristen Accardi 
Signed-off-by: Greg Kroah-Hartman

pciehp: remove trailing whitespace from pciehp_ctrl.c

2007-10-12T22:03:14+00:00

Remove trailing whitespaces from pciehp_ctrl.c.

Signed-off-by: Kenji Kaneshige 
Signed-off-by: Kristen Carlson Accardi 
Signed-off-by: Greg Kroah-Hartman