linux.git/drivers/nvme, branch v4.14-rc4

nvme-pci: Use PCI bus address for data/queues in CMB

2017-10-04T09:42:53+00:00

Currently, NVMe PCI host driver is programming CMB dma address as
I/O SQs addresses. This results in failures on systems where 1:1
outbound mapping is not used (example Broadcom iProc SOCs) because
CMB BAR will be progammed with PCI bus address but NVMe PCI EP will
try to access CMB using dma address.

To have CMB working on systems without 1:1 outbound mapping, we
program PCI bus address for I/O SQs instead of dma address. This
approach will work on systems with/without 1:1 outbound mapping.

Based on a report and previous patch from Abhishek Shah.

Fixes: 8ffaadf7 ("NVMe: Use CMB for the IO SQes if available")
Cc: stable@vger.kernel.org
Reported-by: Abhishek Shah 
Tested-by: Abhishek Shah 
Reviewed-by: Keith Busch 
Signed-off-by: Christoph Hellwig

nvme: fix visibility of "uuid" ns attribute

2017-10-01T07:58:04+00:00

"uuid" must be invisible if both ns->uuid and ns->nguid are unset,
not if either one is.

Fixes: d934f9848a77 "nvme: provide UUID value to userspace"
Signed-off-by: Martin Wilck 
Signed-off-by: Christoph Hellwig

nvme-fcloop: fix port deletes and callbacks

2017-09-25T18:42:11+00:00

Now that there are potentially long delays between when a remoteport or
targetport delete calls is made and when the callback occurs (dev_loss_tmo
timeout), no longer block in the delete routines and move the final nport
puts to the callbacks.

Moved the fcloop_nport_get/put/free routines to avoid forward declarations.

Ensure port_info structs used in registrations are nulled in case fields
are not set (ex: devloss_tmo values).

Signed-off-by: James Smart 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

nvmet-fc: ensure target queue id within range.

2017-09-25T18:42:11+00:00

When searching for queue id's ensure they are within the expected range.

Signed-off-by: James Smart 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

nvmet-fc: on port remove call put outside lock

2017-09-25T18:42:11+00:00

Avoid calling the put routine, as it may traverse to free routines while
holding the target lock.

Signed-off-by: James Smart 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

nvme-rdma: don't fully stop the controller in error recovery

2017-09-25T18:42:11+00:00

By calling nvme_stop_ctrl on a already failed controller will wait for the
scan work to complete (only by identify timeout expiration which is 60
seconds). This is unnecessary when we already know that the controller has
failed.

Reported-by: Yi Zhang 
Signed-off-by: Sagi Grimberg 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

nvme-rdma: give up reconnect if state change fails

2017-09-25T18:42:11+00:00

If we failed to transition to state LIVE after a successful reconnect,
then controller deletion already started. In this case there is no
point moving forward with reconnect.

Reviewed-by: Johannes Thumshirn 
Signed-off-by: Sagi Grimberg 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

nvme-core: Use nvme_wq to queue async events and fw activation

2017-09-25T18:42:11+00:00

async_event_work might race as it is executed from two different
workqueues at the moment.

Reviewed-by: Johannes Thumshirn 
Signed-off-by: Sagi Grimberg 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

nvme: fix sqhd reference when admin queue connect fails

2017-09-25T18:42:11+00:00

Fix bug in sqhd patch.

It wasn't the sq that was at risk. In the case where the admin queue
connect command fails, the sq->size field is not set. Therefore, this
becomes a divide by zero error.

Add a quick check to bypass under this failure condition.

Signed-off-by: James Smart 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

nvmet: implement valid sqhd values in completions

2017-09-25T14:56:05+00:00

To support sqhd, for initiators that are following the spec and
paying attention to sqhd vs their sqtail values:

- add sqhd to struct nvmet_sq
- initialize sqhd to 0 in nvmet_sq_setup
- rather than propagate the 0's-based qsize value from the connect message
  which requires a +1 in every sqhd update, and as nothing else references
  it, convert to 1's-based value in nvmt_sq/cq_setup() calls.
- validate connect message sqsize being non-zero per spec.
- updated assign sqhd for every completion that goes back.

Also remove handling the NULL sq case in __nvmet_req_complete, as it can't
happen with the current code.

Signed-off-by: James Smart 
Reviewed-by: Sagi Grimberg 
Reviewed-by: Max Gurtovoy 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe