linux.git/drivers/nvme, branch v4.13-rc7

nvme-pci: set cqe_seen on polled completions

2017-08-18T07:19:39+00:00

Fixes: 920d13a884 ("nvme-pci: factor out the cqe reading mechanics from __nvme_process_cq")
Reported-by: Jens Axboe 
Signed-off-by: Keith Busch 
Signed-off-by: Christoph Hellwig

nvme-fabrics: fix reporting of unrecognized options

2017-08-17T16:48:54+00:00

Only print the specified options that are not recognized, instead
of the whole list of options.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Max Gurtovoy

nvmet-fc: eliminate incorrect static markers on local variables

2017-08-17T07:35:08+00:00

There were 2 statics introduced that were bogus. Removed the static
designations.

Signed-off-by: James Smart 
Signed-off-by: Christoph Hellwig

nvmet-fc: correct use after free on list teardown

2017-08-16T08:06:18+00:00

Use list_for_each_entry_safe to prevent list handling from referencing
next pointers directly after list_del's

Signed-off-by: James Smart 
Signed-off-by: Christoph Hellwig

nvmet: don't overwrite identify sn/fr with 0-bytes

2017-08-16T08:06:10+00:00

The merged version of my patch "nvmet: don't report 0-bytes in serial
number" fails to remove two lines which should have been replaced,
so that the space-padded strings are overwritten again with 0-bytes.
Fix it.

Fixes: 42de82a8b544 nvmet: don't report 0-bytes in serial number
Signed-off-by: Martin Wilck 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Christoph Hellwig

nvme: fix directive command numd calculation

2017-08-10T17:53:44+00:00

The numd field of directive receive command takes number of dwords to
transfer. This fix has the correct calculation for numd.

Signed-off-by: Kwan (Hingkwan) Huen-SSI 
Reviewed-by: Jens Axboe 
Signed-off-by: Christoph Hellwig

nvme: fix nvme reset command timeout handling

2017-08-10T17:53:38+00:00

We need to return an error if a timeout occurs on any NVMe command during
initialization. Without this, the nvme reset work will be stuck. A timeout
will have a negative error code, meaning we need to stop initializing
the controller. All postitive returns mean the controller is still usable.

bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=196325

Signed-off-by: Keith Busch 
Cc: Martin Peres 
[jth consolidated cleanup path ]
Signed-off-by: Johannes Thumshirn 
Signed-off-by: Christoph Hellwig

nvme-pci: fix CMB sysfs file removal in reset path

2017-08-10T09:19:06+00:00

Currently we create the sysfs entry even if we fail mapping
it. In that case, the unmapping will not remove the sysfs created
file. There is no good reason to create a sysfs entry for a non
working CMB and show his characteristics.

Fixes: f63572dff ("nvme: unmap CMB and remove sysfs file in reset path")
Signed-off-by: Max Gurtovoy 
Reviewed-by: Stephen Bates 
Signed-off-by: Christoph Hellwig

nvmet_fc: add defer_req callback for deferment of cmd buffer return

2017-08-10T09:06:38+00:00

At queue creation, the transport allocates a local job struct
(struct nvmet_fc_fcp_iod) for each possible element of the queue.
When a new CMD is received from the wire, a jobs struct is allocated
from the queue and then used for the duration of the command.
The job struct contains buffer space for the wire command iu. Thus,
upon allocation of the job struct, the cmd iu buffer is copied to
the job struct and the LLDD may immediately free/reuse the CMD IU
buffer passed in the call.

However, in some circumstances, due to the packetized nature of FC
and the api of the FC LLDD which may issue a hw command to send the
wire response, but the LLDD may not get the hw completion for the
command and upcall the nvmet_fc layer before a new command may be
asynchronously received on the wire. In other words, its possible
for the initiator to get the response from the wire, thus believe a
command slot free, and send a new command iu. The new command iu
may be received by the LLDD and passed to the transport before the
LLDD had serviced the hw completion and made the teardown calls for
the original job struct. As such, there is no available job struct
available for the new io. E.g. it appears like the host sent more
queue elements than the queue size. It didn't based on it's
understanding.

Rather than treat this as a hard connection failure queue the new
request until the job struct does free up. As the buffer isn't
copied as there's no job struct, a special return value must be
returned to the LLDD to signify to hold off on recycling the cmd
iu buffer.  And later, when a job struct is allocated and the
buffer copied, a new LLDD callback is introduced to notify the
LLDD and allow it to recycle it's command iu buffer.

Signed-off-by: James Smart 
Reviewed-by: Johannes Thumshirn 
Signed-off-by: Christoph Hellwig

nvme: strip trailing 0-bytes in wwid_show

2017-08-10T08:43:31+00:00

Some broken controllers (such as earlier Linux targets) pad model or
serial fields with 0-bytes rather than spaces. The NVMe spec disallows
0 bytes in "ASCII" fields.  Thus strip trailing 0-bytes, too. Also make
sure that we get no underflow for pathological input.

Signed-off-by: Martin Wilck 
Reviewed-by: Hannes Reinecke 
Reviewed-by: Keith Busch 
Signed-off-by: Christoph Hellwig