linux.git/drivers/nvme/target/admin-cmd.c, branch v5.5

nvmet: fix per feat data len for get_feature

2020-01-10T15:55:50+00:00

The existing implementation for the get_feature admin-cmd does not
use per-feature data len. This patch introduces a new helper function
nvmet_feat_data_len(), which is used to calculate per feature data len.
Right now we only set data len for fid 0x81 (NVME_FEAT_HOST_ID).

Fixes: commit e9061c397839 ("nvmet: Remove the data_len field from the nvmet_req struct")

Reviewed-by: Christoph Hellwig 
Signed-off-by: Amit Engel 
[endiness, naming, and kernel style fixes]
Signed-off-by: Chaitanya Kulkarni 
Signed-off-by: Keith Busch 
Signed-off-by: Jens Axboe

nvmet: clean up command parsing a bit

2019-11-04T17:56:42+00:00

Move the special cases for fabrics commands and the discovery controller
to nvmet_parse_admin_cmd in preparation for adding passthrough support.

Reviewed-by: Sagi Grimberg 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Keith Busch 
Signed-off-by: Jens Axboe

nvmet: Remove the data_len field from the nvmet_req struct

2019-11-04T17:56:42+00:00

Instead of storing the expected length and checking it when it's
executed, just check the length inside the command themselves.

A new helper, nvmet_check_data_len() is created to help with this
check.

Signed-off-by: Christoph Hellwig 
[split patch, udpate changelog]
Signed-off-by: Logan Gunthorpe 
Signed-off-by: Keith Busch 
Signed-off-by: Jens Axboe

nvmet: Introduce common execute function for get_log_page and identify

2019-11-04T17:56:41+00:00

Instead of picking the sub-command handler to execute in a nested
switch statement introduce a landing functions that calls out
to the appropriate sub-command handler.

This will allow us to have a common place in the handler to check
the transfer length in a future patch.

Reviewed-by: Chaitanya Kulkarni 
Signed-off-by: Christoph Hellwig 
[split patch, update change log]
Signed-off-by: Logan Gunthorpe 
Signed-off-by: Keith Busch 
Signed-off-by: Jens Axboe

nvmet: fix a wrong error status returned in error log page

2019-09-12T15:50:46+00:00

When the command data_len cannot hold all the controller errors,
we should simply return as much errors as we can fit
instead of failing the command.

Signed-off-by: Amit Engel 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Sagi Grimberg

nvmet: fix data units read and written counters in SMART log

2019-08-29T19:55:01+00:00

In nvme spec 1.3 there is a definition for data write/read counters
from SMART log, (See section 5.14.1.2):
	This value is reported in thousands (i.e., a value of 1
	corresponds to 1000 units of 512 bytes read) and is rounded up.

However, in nvme target where value is reported with actual units,
but not thousands of units as the spec requires.

Signed-off-by: Tom Wu 
Reviewed-by: Israel Rukshin 
Reviewed-by: Max Gurtovoy 
Reviewed-by: Chaitanya Kulkarni 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Sagi Grimberg

nvmet: export I/O characteristics attributes in Identify

2019-07-09T21:15:37+00:00

Make the NVMe NAWUN, NAWUPF, NACWU, NPWG, NPWA, NPDG and NOWS attributes
available to initator systems for the block backend.

Signed-off-by: Bart Van Assche 
Reviewed-by: Martin K. Petersen 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Christoph Hellwig

nvmet: fix discover log page when offsets are used

2019-04-11T15:28:30+00:00

The nvme target hadn't been taking the Get Log Page offset parameter
into consideration, and so has been returning corrupted log pages when
offsets are used. Since many tools, including nvme-cli, split the log
request to 4k, we've been breaking discovery log responses when more
than 3 subsystems exist.

Fix the returned data by internally generating the entire discovery
log page and copying only the requested bytes into the user buffer. The
command log page offset type has been modified to a native __le64 to
make it easier to extract the value from a command.

Signed-off-by: Keith Busch 
Tested-by: Minwoo Im 
Reviewed-by: Chaitanya Kulkarni 
Reviewed-by: Hannes Reinecke 
Reviewed-by: James Smart 
Signed-off-by: Christoph Hellwig

nvmet: convert to SPDX identifiers

2019-02-20T14:22:42+00:00

Update license to use SPDX-License-Identifier instead of verbose license
text.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Sagi Grimberg

nvmet: update smart log with num err log entries

2018-12-13T08:59:07+00:00

Now that we have error log page implementation update smart log command
handler to provide number of error log entries in the lifetime of the
controller field.

Signed-off-by: Chaitanya Kulkarni 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Christoph Hellwig