linux.git/drivers/nvme/target/admin-cmd.c, branch v4.16

nvmet: remove redundant local variable

2017-11-11T02:53:25+00:00

the status is either success or some status id and
we don't need a local variable for it.

Signed-off-by: Sagi Grimberg 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

nvmet: remove redundant memset if failed to get_smart_log failed

2017-11-11T02:53:25+00:00

We already allocated the buffer with kzalloc.

Signed-off-by: Sagi Grimberg 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

nvmet: fix comment typos in admin-cmd.c

2017-11-11T02:53:25+00:00

small typos fixed in admin-cmd.c

Signed-off-by: Minwoo Im 
Reviewed-by: Max Gurtovoy 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

nvmet: add support for reporting the host identifier

2017-08-30T13:05:18+00:00

And fix the Get/Set Log Page implementation to take all 8 bits of the
feature identifier into account.

Signed-off-by: Omri Mann 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Christoph Hellwig 
[hch: used the UUID API, updated changelog]

nvmet: use memcpy_and_pad for identify sn/fr

2017-08-28T20:00:42+00:00

This changes the earlier patch "nvmet: don't report 0-bytes
in serial number" to use the memcpy_and_pad() helper introduced
in a previous patch.

Signed-off-by: Martin Wilck 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Christoph Hellwig

nvmet: use NVME_NSID_ALL

2017-08-28T19:38:19+00:00

Signed-off-by: Christoph Hellwig 
Reviewed-by: Keith Busch 
Reviewed-by: Max Gurtovoy

nvmet: don't overwrite identify sn/fr with 0-bytes

2017-08-16T08:06:10+00:00

The merged version of my patch "nvmet: don't report 0-bytes in serial
number" fails to remove two lines which should have been replaced,
so that the space-padded strings are overwritten again with 0-bytes.
Fix it.

Fixes: 42de82a8b544 nvmet: don't report 0-bytes in serial number
Signed-off-by: Martin Wilck 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Christoph Hellwig

nvmet: don't report 0-bytes in serial number

2017-07-20T14:41:56+00:00

The NVME standard mandates that the SN, MN, and FR fields of the Identify
Controller Data Structure be "ASCII strings".  That means that they may
not contain 0-bytes, not even string terminators.

Signed-off-by: Martin Wilck 
Reviewed-by: Hannes Reinecke 
[hch: fixed for the move of the serial field, updated description]
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

nvmet: Move serial number from controller to subsystem

2017-07-20T14:41:56+00:00

The NVMe specification defines the serial number as:

"Serial Number (SN): Contains the serial number for the NVM subsystem
that is assigned by the vendor as an ASCII string. Refer to section
7.10 for unique identifier requirements. Refer to section 1.5 for ASCII
string requirements"

So move it from the controller to the subsystem, where it belongs.

Signed-off-by: Johannes Thumshirn 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

nvmet: implement namespace identify descriptor list

2017-06-15T12:30:21+00:00

A NVMe Identify NS command with a CNS value of '3' is expecting a list
of Namespace Identification Descriptor structures to be returned to
the host for the namespace requested in the namespace identify
command.

This Namespace Identification Descriptor structure consists of the
type of the namespace identifier, the length of the identifier and the
actual identifier.

Valid types are NGUID and UUID which we have saved in our nvme_ns
structure if they have been configured via configfs. If no value has
been assigened to one of these we return an "invalid opcode" back to
the host to maintain backward compatibiliy with older implementations
without Namespace Identify Descriptor list support.

Also as the Namespace Identify Descriptor list is the only mandatory
feature change between 1.2.1 and 1.3 we can bump the advertised
version as well.

Signed-off-by: Johannes Thumshirn 
Reviewed-by: Hannes Reinecke 
Reviewed-by: Max Gurtovoy 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Christoph Hellwig