linux.git/drivers/nvme/target/admin-cmd.c, branch v4.13

nvmet: don't overwrite identify sn/fr with 0-bytes

2017-08-16T08:06:10+00:00

The merged version of my patch "nvmet: don't report 0-bytes in serial
number" fails to remove two lines which should have been replaced,
so that the space-padded strings are overwritten again with 0-bytes.
Fix it.

Fixes: 42de82a8b544 nvmet: don't report 0-bytes in serial number
Signed-off-by: Martin Wilck 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Christoph Hellwig

nvmet: don't report 0-bytes in serial number

2017-07-20T14:41:56+00:00

The NVME standard mandates that the SN, MN, and FR fields of the Identify
Controller Data Structure be "ASCII strings".  That means that they may
not contain 0-bytes, not even string terminators.

Signed-off-by: Martin Wilck 
Reviewed-by: Hannes Reinecke 
[hch: fixed for the move of the serial field, updated description]
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

nvmet: Move serial number from controller to subsystem

2017-07-20T14:41:56+00:00

The NVMe specification defines the serial number as:

"Serial Number (SN): Contains the serial number for the NVM subsystem
that is assigned by the vendor as an ASCII string. Refer to section
7.10 for unique identifier requirements. Refer to section 1.5 for ASCII
string requirements"

So move it from the controller to the subsystem, where it belongs.

Signed-off-by: Johannes Thumshirn 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

nvmet: implement namespace identify descriptor list

2017-06-15T12:30:21+00:00

A NVMe Identify NS command with a CNS value of '3' is expecting a list
of Namespace Identification Descriptor structures to be returned to
the host for the namespace requested in the namespace identify
command.

This Namespace Identification Descriptor structure consists of the
type of the namespace identifier, the length of the identifier and the
actual identifier.

Valid types are NGUID and UUID which we have saved in our nvme_ns
structure if they have been configured via configfs. If no value has
been assigened to one of these we return an "invalid opcode" back to
the host to maintain backward compatibiliy with older implementations
without Namespace Identify Descriptor list support.

Also as the Namespace Identify Descriptor list is the only mandatory
feature change between 1.2.1 and 1.3 we can bump the advertised
version as well.

Signed-off-by: Johannes Thumshirn 
Reviewed-by: Hannes Reinecke 
Reviewed-by: Max Gurtovoy 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Christoph Hellwig

nvmet: use NVME_IDENTIFY_DATA_SIZE

2017-06-15T12:30:15+00:00

Use NVME_IDENTIFY_DATA_SIZE define instead of hard coding the magic
4096 value.

Signed-off-by: Johannes Thumshirn 
Reviewed-by: Max Gurtovoy 
Reviewed-by: Sagi Grimberg 
Reviewed-by: Hannes Reinecke 
[hch: converted three more users]
Signed-off-by: Christoph Hellwig

Merge branch 'for-linus' into for-4.12/block

2017-04-07T18:45:20+00:00

We've added a considerable amount of fixes for stalls and issues
with the blk-mq scheduling in the 4.11 series since forking
off the for-4.12/block branch. We need to do improvements on
top of that for 4.12, so pull in the previous fixes to make
our lives easier going forward.

Signed-off-by: Jens Axboe

nvmet: use symbolic constants for log identifiers

2017-04-04T15:48:23+00:00

Signed-off-by: Max Gurtovoy 
Reviewed-by: Parav Pandit 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Sagi Grimberg 
Signed-off-by: Jens Axboe

nvmet: Introduced helper routine for controller status check.

2017-04-04T15:48:23+00:00

This patch introduces helper function for checking controller
status during admin and io command processing which returns u16
status. As to bring consistency on returning status, other
friend functions also now return u16 status instead of int
to match the spec.

As part of the theseerror log prints in also prints qid on
which command error occured.

Signed-off-by: Parav Pandit 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Sagi Grimberg 
Signed-off-by: Jens Axboe

nvmet: Fixed avoided printing nvmet: twice in error logs.

2017-04-04T15:48:23+00:00

This patch avoids printing "nvmet:" twice in error logs as its already
coming through pr_fmt macro.

Reviewed-by: Max Gurtovoy 
Signed-off-by: Parav Pandit 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Sagi Grimberg 
Signed-off-by: Jens Axboe

nvmet: add missing byte swap in nvmet_get_smart_log

2017-04-02T07:24:15+00:00

In this case entirely harmless as it's all-ones, but still nice to
shut up sparse.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Sagi Grimberg