linux.git/drivers/nvme/host/fc.c, branch v6.7

Revert "nvme-fc: fix race between error recovery and creating association"

2023-12-19T16:58:46+00:00

The commit was identified to might sleep in invalid context and is
blocking regression testing.

This reverts commit ee6fdc5055e916b1dd497f11260d4901c4c1e55e.

Link: https://lore.kernel.org/linux-nvme/hkhl56n665uvc6t5d6h3wtx7utkcorw4xlwi7d2t2bnonavhe6@xaan6pu43ap6/
Link: https://lists.infradead.org/pipermail/linux-nvme/2023-December/043756.html
Reported-by: Daniel Wagner 
Reported-by: Maurizio Lombardi 
Cc: Michael Liang 
Tested-by: Daniel Wagner 
Reviewed-by: Daniel Wagner 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Keith Busch

nvme: ensure reset state check ordering

2023-12-04T16:39:03+00:00

A different CPU may be setting the ctrl->state value, so ensure proper
barriers to prevent optimizing to a stale state. Normally it isn't a
problem to observe the wrong state as it is merely advisory to take a
quicker path during initialization and error recovery, but seeing an old
state can report unexpected ENETRESET errors when a reset request was in
fact successful.

Reported-by: Minh Hoang 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Keith Busch 
Signed-off-by: Hannes Reinecke

nvme: move nvme_stop_keep_alive() back to original position

2023-11-22T16:07:02+00:00

Stopping keep-alive not only stops the keep-alive workqueue,
but also needs to be synchronized with I/O termination as we
must not send a keep-alive command after all I/O had been
terminated.
So to avoid any regressions move the call to stop_keep_alive()
back to its original position and ensure that keep-alive is
correctly stopped failing to setup the admin queue.

Fixes: 4733b65d82bd ("nvme: start keep-alive after admin queue setup")
Suggested-by: Sagi Grimberg 
Signed-off-by: Hannes Reinecke 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Keith Busch

nvme: start keep-alive after admin queue setup

2023-11-06T17:16:10+00:00

Setting up I/O queues might take quite some time on larger and/or
busy setups, so KATO might expire before all I/O queues could be
set up.
Fix this by start keep alive from the ->init_ctrl_finish() callback,
and stopping it when calling nvme_cancel_admin_tagset().

Signed-off-by: Hannes Reinecke 
Tested-by: Mark O'Donovan 
[fixed nvme-fc compile error]
Signed-off-by: Keith Busch

nvme-fc: Prevent null pointer dereference in nvme_fc_io_getuuid()

2023-08-21T20:29:17+00:00

The nvme_fc_fcp_op structure describing an AEN operation is initialized with a
null request structure pointer. An FC LLDD may make a call to
nvme_fc_io_getuuid passing a pointer to an nvmefc_fcp_req for an AEN operation.

Add validation of the request structure pointer before dereference.

Signed-off-by: Nigel Kirkland 
Reviewed-by: James Smart 
Signed-off-by: Keith Busch

nvme-fc: fix race between error recovery and creating association

2023-07-12T16:29:51+00:00

There is a small race window between nvme-fc association creation and error
recovery. Fix this race condition by protecting accessing to controller
state and ASSOC_FAILED flag under nvme-fc controller lock.

Signed-off-by: Michael Liang 
Reviewed-by: Caleb Sander 
Reviewed-by: James Smart 
Signed-off-by: Keith Busch

nvme-fc: return non-zero status code when fails to create association

2023-07-12T16:29:48+00:00

Return non-zero status code(-EIO) when needed, so re-connecting or
deleting controller will be triggered properly.

Signed-off-by: Michael Liang 
Reviewed-by: Caleb Sander 
Reviewed-by: James Smart 
Signed-off-by: Keith Busch

overflow: Add struct_size_t() helper

2023-05-26T20:52:19+00:00

While struct_size() is normally used in situations where the structure
type already has a pointer instance, there are places where no variable
is available. In the past, this has been worked around by using a typed
NULL first argument, but this is a bit ugly. Add a helper to do this,
and replace the handful of instances of the code pattern with it.

Instances were found with this Coccinelle script:

@struct_size_t@
identifier STRUCT, MEMBER;
expression COUNT;
@@

-       struct_size((struct STRUCT *)\(0\|NULL\),
+       struct_size_t(struct STRUCT,
                MEMBER, COUNT)

Suggested-by: Christoph Hellwig 
Cc: Jesse Brandeburg 
Cc: Tony Nguyen 
Cc: "David S. Miller" 
Cc: Eric Dumazet 
Cc: Paolo Abeni 
Cc: James Smart 
Cc: Keith Busch 
Cc: Jens Axboe 
Cc: Sagi Grimberg 
Cc: HighPoint Linux Team 
Cc: "James E.J. Bottomley" 
Cc: "Martin K. Petersen" 
Cc: Kashyap Desai 
Cc: Sumit Saxena 
Cc: Shivasharan S 
Cc: Don Brace 
Cc: "Darrick J. Wong" 
Cc: Dave Chinner 
Cc: Guo Xuenan 
Cc: Gwan-gyeong Mun 
Cc: Nick Desaulniers 
Cc: Daniel Latypov 
Cc: kernel test robot 
Cc: intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org
Cc: linux-nvme@lists.infradead.org
Cc: linux-scsi@vger.kernel.org
Cc: megaraidlinux.pdl@broadcom.com
Cc: storagedev@microchip.com
Cc: linux-xfs@vger.kernel.org
Cc: linux-hardening@vger.kernel.org
Signed-off-by: Kees Cook 
Acked-by: Martin K. Petersen 
Reviewed-by: Darrick J. Wong 
Reviewed-by: Gustavo A. R. Silva 
Reviewed-by: Christoph Hellwig 
Acked-by: Jakub Kicinski 
Reviewed-by: Alexander Lobakin 
Link: https://lore.kernel.org/r/20230522211810.never.421-kees@kernel.org

drivers: remove struct module * setting from struct class

2023-03-17T14:16:27+00:00

There is no need to manually set the owner of a struct class, as the
registering function does it automatically, so remove all of the
explicit settings from various drivers that did so as it is unneeded.

This allows us to remove this pointer entirely from this structure going
forward.

Cc: "Rafael J. Wysocki" 
Link: https://lore.kernel.org/r/20230313181843.1207845-2-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman

nvme-fc: fix initialization order

2023-01-23T16:42:11+00:00

ctrl->ops is used by nvme_alloc_admin_tag_set() but set by
nvme_init_ctrl() so reorder the calls to avoid a NULL pointer
dereference.

Fixes: 6dfba1c09c10 ("nvme-fc: use the tagset alloc/free helpers")
Signed-off-by: Ross Lagerwall 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Christoph Hellwig