linux.git/drivers/nvme/host/fc.c, branch v6.6

nvme-fc: Prevent null pointer dereference in nvme_fc_io_getuuid()

2023-08-21T20:29:17+00:00

The nvme_fc_fcp_op structure describing an AEN operation is initialized with a
null request structure pointer. An FC LLDD may make a call to
nvme_fc_io_getuuid passing a pointer to an nvmefc_fcp_req for an AEN operation.

Add validation of the request structure pointer before dereference.

Signed-off-by: Nigel Kirkland 
Reviewed-by: James Smart 
Signed-off-by: Keith Busch

nvme-fc: fix race between error recovery and creating association

2023-07-12T16:29:51+00:00

There is a small race window between nvme-fc association creation and error
recovery. Fix this race condition by protecting accessing to controller
state and ASSOC_FAILED flag under nvme-fc controller lock.

Signed-off-by: Michael Liang 
Reviewed-by: Caleb Sander 
Reviewed-by: James Smart 
Signed-off-by: Keith Busch

nvme-fc: return non-zero status code when fails to create association

2023-07-12T16:29:48+00:00

Return non-zero status code(-EIO) when needed, so re-connecting or
deleting controller will be triggered properly.

Signed-off-by: Michael Liang 
Reviewed-by: Caleb Sander 
Reviewed-by: James Smart 
Signed-off-by: Keith Busch

overflow: Add struct_size_t() helper

2023-05-26T20:52:19+00:00

While struct_size() is normally used in situations where the structure
type already has a pointer instance, there are places where no variable
is available. In the past, this has been worked around by using a typed
NULL first argument, but this is a bit ugly. Add a helper to do this,
and replace the handful of instances of the code pattern with it.

Instances were found with this Coccinelle script:

@struct_size_t@
identifier STRUCT, MEMBER;
expression COUNT;
@@

-       struct_size((struct STRUCT *)\(0\|NULL\),
+       struct_size_t(struct STRUCT,
                MEMBER, COUNT)

Suggested-by: Christoph Hellwig 
Cc: Jesse Brandeburg 
Cc: Tony Nguyen 
Cc: "David S. Miller" 
Cc: Eric Dumazet 
Cc: Paolo Abeni 
Cc: James Smart 
Cc: Keith Busch 
Cc: Jens Axboe 
Cc: Sagi Grimberg 
Cc: HighPoint Linux Team 
Cc: "James E.J. Bottomley" 
Cc: "Martin K. Petersen" 
Cc: Kashyap Desai 
Cc: Sumit Saxena 
Cc: Shivasharan S 
Cc: Don Brace 
Cc: "Darrick J. Wong" 
Cc: Dave Chinner 
Cc: Guo Xuenan 
Cc: Gwan-gyeong Mun 
Cc: Nick Desaulniers 
Cc: Daniel Latypov 
Cc: kernel test robot 
Cc: intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org
Cc: linux-nvme@lists.infradead.org
Cc: linux-scsi@vger.kernel.org
Cc: megaraidlinux.pdl@broadcom.com
Cc: storagedev@microchip.com
Cc: linux-xfs@vger.kernel.org
Cc: linux-hardening@vger.kernel.org
Signed-off-by: Kees Cook 
Acked-by: Martin K. Petersen 
Reviewed-by: Darrick J. Wong 
Reviewed-by: Gustavo A. R. Silva 
Reviewed-by: Christoph Hellwig 
Acked-by: Jakub Kicinski 
Reviewed-by: Alexander Lobakin 
Link: https://lore.kernel.org/r/20230522211810.never.421-kees@kernel.org

drivers: remove struct module * setting from struct class

2023-03-17T14:16:27+00:00

There is no need to manually set the owner of a struct class, as the
registering function does it automatically, so remove all of the
explicit settings from various drivers that did so as it is unneeded.

This allows us to remove this pointer entirely from this structure going
forward.

Cc: "Rafael J. Wysocki" 
Link: https://lore.kernel.org/r/20230313181843.1207845-2-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman

nvme-fc: fix initialization order

2023-01-23T16:42:11+00:00

ctrl->ops is used by nvme_alloc_admin_tag_set() but set by
nvme_init_ctrl() so reorder the calls to avoid a NULL pointer
dereference.

Fixes: 6dfba1c09c10 ("nvme-fc: use the tagset alloc/free helpers")
Signed-off-by: Ross Lagerwall 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Christoph Hellwig

nvme: consolidate setting the tagset flags

2022-12-07T14:02:20+00:00

All nvme transports should be using the same flags for their tagsets,
with the exception for the blocking flag that should only be set for
transports that can block in ->queue_rq.

Add a NVME_F_BLOCKING flag to nvme_ctrl_ops to control the blocking
behavior and lift setting the flags into nvme_alloc_{admin,io}_tag_set.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Sagi Grimberg 
Reviewed-by: Chaitanya Kulkarni

nvme: pass nr_maps explicitly to nvme_alloc_io_tag_set

2022-12-07T14:02:15+00:00

Don't look at ctrl->ops as only RDMA and TCP actually support multiple
maps.

Fixes: 6dfba1c09c10 ("nvme-fc: use the tagset alloc/free helpers")
Fixes: ceee1953f923 ("nvme-loop: use the tagset alloc/free helpers")
Signed-off-by: Christoph Hellwig 
Reviewed-by: Sagi Grimberg 
Reviewed-by: Chaitanya Kulkarni

nvme: merge nvme_shutdown_ctrl into nvme_disable_ctrl

2022-12-06T13:36:54+00:00

Many of the callers decide which one to use based on a bool argument and
there is at least some code to be shared, so merge these two.  Also
move a comment specific to a single callsite to that callsite.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Keith Busch 
Reviewed-by: Sagi Grimberg 
Reviewed-by: Hector Martin

nvme-fc: move common code into helper

2022-12-06T08:27:24+00:00

Add a helper to move the duplicate code for error message
from nvme_fc_rcv_ls_req() to nvme_fc_rcv_ls_req_err_msg().

Signed-off-by: Chaitanya Kulkarni 
Reviewed-by: James Smart 
Signed-off-by: Christoph Hellwig