linux.git/drivers/ntb/hw/intel, branch v4.13

ntb_hw_intel: Style fixes: open code macros that just obfuscate code

2017-07-06T15:30:07+00:00

As per a comments in [1] by Greg Kroah-Hartman, the ndev_* macros should
be cleaned up. This makes it more clear what's actually going on when
reading the code.

[1] http://www.spinics.net/lists/linux-pci/msg56904.html

Signed-off-by: Logan Gunthorpe 
Signed-off-by: Jon Mason

NTB: Alter Scratchpads API to support multi-ports devices

2017-07-06T15:30:07+00:00

Even though there is no any real NTB hardware, which would have both more
than two ports and Scratchpad registers, it is logically correct to have
Scratchpad API accepting a peer port index as well. Intel/AMD drivers utilize
Primary and Secondary topology to split Scratchpad between connected root
devices. Since port-index API introduced, Intel/AMD NTB hardware drivers can
use device port to determine which Scratchpad registers actually belong to
local and peer devices. The same approach can be used if some potential
hardware in future will be multi-port and have some set of Scratchpads.
Here are the brief of changes in the API:
 ntb_spad_count() - return number of Scratchpads per each port
 ntb_peer_spad_addr(pidx, sidx) - address of Scratchpad register of the
peer device with pidx-index
 ntb_peer_spad_read(pidx, sidx) - read specified Scratchpad register of the
peer with pidx-index
 ntb_peer_spad_write(pidx, sidx) - write data to Scratchpad register of the
peer with pidx-index

Since there is hardware which doesn't support Scratchpad registers, the
corresponding API methods are now made optional.

Signed-off-by: Serge Semin 
Acked-by: Allen Hubbe 
Signed-off-by: Jon Mason

NTB: Alter MW API to support multi-ports devices

2017-07-06T15:30:07+00:00

Multi-port NTB devices permit to share a memory between all accessible peers.
Memory Windows API is altered to correspondingly initialize and map memory
windows for such devices:
 ntb_mw_count(pidx); - number of inbound memory windows, which can be allocated
for shared buffer with specified peer device.
 ntb_mw_get_align(pidx, widx); - get alignment and size restriction parameters
to properly allocate inbound memory region.
 ntb_peer_mw_count(); - get number of outbound memory windows.
 ntb_peer_mw_get_addr(widx); - get mapping address of an outbound memory window

If hardware supports inbound translation configured on the local ntb port:
 ntb_mw_set_trans(pidx, widx); - set translation address of allocated inbound
memory window so a peer device could access it.
 ntb_mw_clear_trans(pidx, widx); - clear the translation address of an inbound
memory window.

If hardware supports outbound translation configured on the peer ntb port:
 ntb_peer_mw_set_trans(pidx, widx); - set translation address of a memory
window retrieved from a peer device
 ntb_peer_mw_clear_trans(pidx, widx); - clear the translation address of an
outbound memory window

Signed-off-by: Serge Semin 
Acked-by: Allen Hubbe 
Signed-off-by: Jon Mason

NTB: Alter link-state API to support multi-port devices

2017-07-06T15:30:07+00:00

Multi-port devices permit the NTB connections between multiple domains,
so a local device can have NTB link being up with one peer and being
down with another. NTB link-state API is appropriately altered to return
a bitfield of the link-states between the local device and possible peers.

Signed-off-by: Serge Semin 
Acked-by: Allen Hubbe 
Signed-off-by: Jon Mason

ntb: ntb_hw_intel: Skylake doorbells should be 32bits, not 64bits

2017-06-19T18:24:41+00:00

Fixing doorbell register length to 32bits per spec. On Skylake NTB, the
doorbell registers are 32bit write only registers. The source for the
doorbell is a 64bit register that shows the interrupt bits.

Signed-off-by: Dave Jiang 
Fixes: 783dfa6cc41b ("ntb: Adding Skylake Xeon NTB support")
Acked-by: Allen Hubbe 
Signed-off-by: Jon Mason

ntb: ntb_hw_intel: link_poll isn't clearing the pending status properly

2017-02-17T04:11:26+00:00

On Skylake hardware, the link_poll isn't clearing the pending interrupt
bit.  Adding a new function for SKX that handles clearing of status bit the
right way.

Signed-off-by: Dave Jiang 
Fixes: 783dfa6c ("ntb: Adding Skylake Xeon NTB support")
Signed-off-by: Jon Mason

NTB: Fix 'request_irq()' and 'free_irq()' inconsistancy

2016-12-23T21:11:03+00:00

'request_irq()' and 'free_irq()' should have the same 'dev_id'.

Signed-off-by: Christophe JAILLET 
Acked-by: Dave Jiang 
Signed-off-by: Jon Mason

ntb: fix SKX NTB config space size register offsets

2016-12-23T21:10:54+00:00

The offsets for the SZ registers are wrong. Updated.

Signed-off-by: Dave Jiang 
Reported-by: Sandeep Mann 
Tested-by: Zachary Ross 
Signed-off-by: Jon Mason

ntb: Adding Skylake Xeon NTB support

2016-12-23T21:09:10+00:00

The Skylake Xeon NTB hardware has made some changes to the register name,
offset, and the way doorbells work. Adding driver support for the new
hardware.

Signed-off-by: Dave Jiang 
Acked-by: Allen Hubbe 
Signed-off-by: Jon Mason

ntb: ntb_hw_intel: init peer_addr in struct intel_ntb_dev

2016-11-13T21:48:29+00:00

The peer_addr member of intel_ntb_dev is not set, therefore when
acquiring ntb_peer_db and ntb_peer_spad we only get the offset rather
than the actual physical address. Adding fix to correct that.

Signed-off-by: Dave Jiang 
Acked-by: Allen Hubbe 
Signed-off-by: Jon Mason