linux.git/drivers/net, branch v3.9-rc5

bonding: remove already created master sysfs link on failure

2013-03-26T17:00:02+00:00

If slave sysfs symlink failes to be created - we end up without removing
the master sysfs symlink. Remove it in case of failure.

Signed-off-by: Veaceslav Falico 
Signed-off-by: David S. Miller

Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net

2013-03-26T16:21:31+00:00

Jeff Kirsher says:

====================
This series contains updates to ixgbevf and igb.

The ixgbevf calls to pci_disable_msix() and to free the msix_entries
memory should not occur if device open fails.  Instead they should be
called during device driver removal to balance with the call to
pci_enable_msix() and the call to allocate msix_entries memory
during the device probe and driver load.

The remaining 4 of 5 igb patches are simple 1-3 line patches to fix
several issues such as possible null pointer dereference, PHC stopping
on max frequency, make sensor info static and SR-IOV initialization
reordering.

The remaining igb patch to fix anti-spoofing config fixes a problem
in i350 where anti spoofing configuration was written into a wrong
register.
====================

Signed-off-by: David S. Miller

pch_gbe: fix ip_summed checksum reporting on rx

2013-03-26T16:20:29+00:00

skb->ip_summed should be CHECKSUM_UNNECESSARY when the driver reports that
checksums were correct and CHECKSUM_NONE in any other case. They're
currently placed vice versa, which breaks the forwarding scenario. Fix it
by placing them as described above.

Signed-off-by: Veaceslav Falico 
Signed-off-by: David S. Miller

igb: fix PHC stopping on max freq

2013-03-26T10:21:34+00:00

For 82576 MAC type, max_adj is reported as 1000000000 ppb. However, if
this value is passed to igb_ptp_adjfreq_82576, incvalue overflows out of
INCVALUE_82576_MASK, resulting in setting of zero TIMINCA.incvalue, stopping
the PHC (instead of going at twice the nominal speed).

Fix the advertised max_adj value to the largest value hardware can handle.
As there is no min_adj value available (-max_adj is used instead), this will
also prevent stopping the clock intentionally. It's probably not a big deal,
other igb MAC types don't support stopping the clock, either.

Signed-off-by: Jiri Benc 
Acked-by: Matthew Vick 
Tested-by: Aaron Brown 
Signed-off-by: Jeff Kirsher

igb: make sensor info static

2013-03-26T10:14:48+00:00

Trivial sparse warning.

Signed-off-by: Stephen Hemminger 
Tested-by: Aaron Brown 
Signed-off-by: Jeff Kirsher

igb: SR-IOV init reordering

2013-03-26T10:07:27+00:00

igb is ineffective at setting a lower total VFs because:

int pci_sriov_set_totalvfs(struct pci_dev *dev, u16 numvfs)
{
        ...
        /* Shouldn't change if VFs already enabled */
        if (dev->sriov->ctrl & PCI_SRIOV_CTRL_VFE)
                return -EBUSY;

Swap init ordering.

Signed-off-by: Alex Williamson 
Acked-by: Greg Rose 
Tested-by: Aaron Brown 
Signed-off-by: Jeff Kirsher

igb: Fix null pointer dereference

2013-03-26T10:00:32+00:00

The max_vfs= option has always been self limiting to the number of VFs
supported by the device.  fa44f2f1 added SR-IOV configuration via
sysfs, but in the process broke this self correction factor.  The
failing path is:

igb_probe
  igb_sw_init
    if (max_vfs > 7) {
        adapter->vfs_allocated_count = 7;
    ...
    igb_probe_vfs
    igb_enable_sriov(, max_vfs)
      if (num_vfs > 7) {
        err = -EPERM;
        ...

This leaves vfs_allocated_count = 7 and vf_data = NULL, so we bomb out
when igb_probe finally calls igb_reset.  It seems like a really bad
idea, and somewhat pointless, to set vfs_allocated_count separate from
vf_data, but limiting max_vfs is enough to avoid the null pointer.

Signed-off-by: Alex Williamson 
Acked-by: Greg Rose 
Tested-by: Aaron Brown 
Signed-off-by: Jeff Kirsher

igb: fix i350 anti spoofing config

2013-03-26T09:47:50+00:00

Fix a problem in i350 where anti spoofing configuration was written into a
wrong register.

Signed-off-by: Lior Levy 
Tested-by: Aaron Brown 
Signed-off-by: Jeff Kirsher

ixgbevf: don't release the soft entries

2013-03-26T09:31:48+00:00

When the ixgbevf driver is opened the request to allocate MSIX irq
vectors may fail.  In that case the driver will call ixgbevf_down()
which will call ixgbevf_irq_disable() to clear the HW interrupt
registers and calls synchronize_irq() using the msix_entries pointer in
the adapter structure.  However, when the function to request the MSIX
irq vectors failed it had already freed the msix_entries which causes
an OOPs from using the NULL pointer in synchronize_irq().

The calls to pci_disable_msix() and to free the msix_entries memory
should not occur if device open fails.  Instead they should be called
during device driver removal to balance with the call to
pci_enable_msix() and the call to allocate msix_entries memory
during the device probe and driver load.

Signed-off-by: Li Xun 
Signed-off-by: Greg Rose 
Tested-by: Sibai Li 
Signed-off-by: Jeff Kirsher

bnx2x: fix assignment of signed expression to unsigned variable

2013-03-24T21:27:28+00:00

fix for incorrect assignment of signed expression to unsigned variable.

Signed-off-by: Kumar Amit Mehta 
Acked-by: Dmitry Kravkov 
Signed-off-by: David S. Miller