linux.git/drivers/net, branch v3.13-rc4

igb: Fix for issue where values could be too high for udelay function.

2013-12-15T03:59:42+00:00

This patch changes the igb_phy_has_link function to check the value of the
parameter before deciding to use udelay or mdelay in order to be sure that
the value is not too high for udelay function.

CC: stable kernel  # 3.9+
Signed-off-by: Sunil K Pandey 
Signed-off-by: Kevin B Smith 
Signed-off-by: Carolyn Wyborny 
Tested-by: Aaron Brown 
Signed-off-by: Jeff Kirsher 
Signed-off-by: David S. Miller

i40e: fix null dereference

2013-12-15T03:59:41+00:00

If the vsi->tx_rings structure is NULL we don't want to panic.

Change-Id: Ic694f043701738c434e8ebe0caf0673f4410dc10
Signed-off-by: Jesse Brandeburg 
Tested-by: Kavindya Deegala 
Signed-off-by: Jeff Kirsher 
Signed-off-by: David S. Miller

xen-netback: fix gso_prefix check

2013-12-12T20:47:18+00:00

There is a mistake in checking the gso_prefix mask when passing large
packets to a guest. The wrong shift is applied to the bit - the raw skb
gso type is used rather then the translated one. This leads to large packets
being handed to the guest without the GSO metadata. This patch fixes the
check.

The mistake manifested as errors whilst running Microsoft HCK large packet
offload tests between a pair of Windows 8 VMs. I have verified this patch
fixes those errors.

Signed-off-by: Paul Durrant 
Cc: Wei Liu 
Cc: Ian Campbell 
Cc: David Vrabel 
Acked-by: Ian Campbell 
Signed-off-by: David S. Miller

drivers: net: cpsw: fix for cpsw crash when build as modules

2013-12-12T18:46:57+00:00

When CPSW and Davinci MDIO are build as modules, CPSW crashes when
accessing CPSW registers in CPSW probe. The same is working in built-in
as the CPSW clocks are enabled in Davindi MDIO probe, SO Enabling the
clocks before accessing the version register and moving out the other
register access to cpsw device open.

Signed-off-by: Mugunthan V N 
Signed-off-by: Felipe Balbi 
Signed-off-by: David S. Miller

xen-netback: napi: don't prematurely request a tx event

2013-12-12T18:35:38+00:00

This patch changes the RING_FINAL_CHECK_FOR_REQUESTS in
xenvif_build_tx_gops to a check for RING_HAS_UNCONSUMED_REQUESTS as the
former call has the side effect of advancing the ring event pointer and
therefore inviting another interrupt from the frontend before the napi
poll has actually finished, thereby defeating the point of napi.

The event pointer is updated by RING_FINAL_CHECK_FOR_REQUESTS in
xenvif_poll, the napi poll function, if the work done is less than the
budget i.e. when actually transitioning back to interrupt mode.

Reported-by: Malcolm Crossley 
Signed-off-by: Paul Durrant 
Cc: Wei Liu 
Cc: Ian Campbell 
Cc: David Vrabel 
Signed-off-by: David S. Miller

xen-netback: napi: fix abuse of budget

2013-12-12T18:35:38+00:00

netback seems to be somewhat confused about the napi budget parameter. The
parameter is supposed to limit the number of skbs processed in each poll,
but netback has this confused with grant operations.

This patch fixes that, properly limiting the work done in each poll. Note
that this limit makes sure we do not process any more data from the shared
ring than we intend to pass back from the poll. This is important to
prevent tx_queue potentially growing without bound.

Signed-off-by: Paul Durrant 
Cc: Wei Liu 
Cc: Ian Campbell 
Cc: David Vrabel 
Signed-off-by: David S. Miller

net:fec: remove duplicate lines in comment about errata ERR006358

2013-12-12T01:19:42+00:00

commit 031916568a1aa2ef1809f86d26f0bcfa215ff5c0 worked around
errata ERR006358, but comment contains duplicated lines, impairing
the readability.  Remove them.

Signed-off-by: Philippe De Muyter 
Signed-off-by: David S. Miller

Revert "8390 : Replace ei_debug with msg_enable/NETIF_MSG_* feature"

2013-12-11T22:20:31+00:00

This reverts commit 99023e90fe5c147ea0665bda86764ea44f08a622.

Accidently checked this into 'net' instead of 'net-next'.

Signed-off-by: David S. Miller

8390 : Replace ei_debug with msg_enable/NETIF_MSG_* feature

2013-12-11T22:11:58+00:00

Removed the shared ei_debug variable. Replaced it by adding u32 msg_enable to
the private struct ei_device. Now each 8390 ethernet instance has a per-device
logging variable.

Changed older style printk() calls to more canonical forms.

Tested on: ne, ne2k-pci, smc-ultra, and wd hardware.

V4.0
- Substituted pr_info() and pr_debug() for printk() KERN_INFO and KERN_DEBUG

V3.0
- Checked for cases where pr_cont() was most appropriate choice.
- Changed module parameter from 'debug' to 'msg_enable' because debug was
no longer the best description.

V2.0
- Changed netif_msg_(drv|probe|ifdown|rx_err|tx_err|tx_queued|intr|rx_status|hw)
to netif_(dbg|info|warn|err) where possible.

Signed-off-by: Matthew Whitehead 
Signed-off-by: David S. Miller

xen-netback: make sure skb linear area covers checksum field

2013-12-11T21:46:24+00:00

skb_partial_csum_set requires that the linear area of the skb covers the
checksum field. The checksum setup code in netback was only doing that
pullup in the case when the pseudo header checksum was being recalculated
though. This patch makes that pullup unconditional. (I pullup the whole
transport header just for simplicity; the requirement is only for the check
field but in the case of UDP this is the last field in the header and in the
case of TCP it's the last but one).

The lack of pullup manifested as failures running Microsoft HCK network
tests on a pair of Windows 8 VMs and it has been verified that this patch
fixes the problem.

Suggested-by: Jan Beulich 
Signed-off-by: Paul Durrant 
Cc: Wei Liu 
Cc: Ian Campbell 
Cc: David Vrabel 
Reviewed-by: Jan Beulich 
Signed-off-by: David S. Miller