<feed xmlns='http://www.w3.org/2005/Atom'>
<title>linux.git/drivers/net, branch v2.6.22</title>
<subtitle>Linux kernel source tree</subtitle>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/'/>
<entry>
<title>potential compiler error, irqfunc caller sites update</title>
<updated>2007-07-06T17:23:43+00:00</updated>
<author>
<name>Yoann Padioleau</name>
<email>padator@wanadoo.fr</email>
</author>
<published>2007-07-06T09:39:56+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=0da2f0f164f098bb4447c714b552ac1681b2d6e8'/>
<id>0da2f0f164f098bb4447c714b552ac1681b2d6e8</id>
<content type='text'>
In 7d12e780e003f93433d49ce78cfedf4b4c52adc5 David Howells performed
this evolution:
 "IRQ: Maintain regs pointer globally rather than passing to IRQ handlers"

He correctly updated many of the function definitions that were using this
extra regs pointer parameter but forgot to update some caller sites of
those functions.  The reason the modifications was not properly done on all
drivers is that some drivers were rarely compiled because they are for
AMIGA, or that some code sites were inside #ifdefs where the option is not
set or inside #if 0.

Here is the semantic patch that found the occurences
and fixed the problem.

@ rule1 @
identifier fn;
identifier irq, dev_id;
typedef irqreturn_t;
@@

static irqreturn_t fn(int irq, void *dev_id)
{
   ...
}

@@
identifier rule1.fn;
expression E1, E2, E3;
@@

 fn(E1, E2
-   ,E3
   )

Signed-off-by: Yoann Padioleau &lt;padator@wanadoo.fr&gt;
Cc: "David S. Miller" &lt;davem@davemloft.net&gt;
Cc: Jeff Garzik &lt;jeff@garzik.org&gt;
Cc: Greg KH &lt;greg@kroah.com&gt;
Signed-off-by: Andrew Morton &lt;akpm@linux-foundation.org&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@linux-foundation.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
In 7d12e780e003f93433d49ce78cfedf4b4c52adc5 David Howells performed
this evolution:
 "IRQ: Maintain regs pointer globally rather than passing to IRQ handlers"

He correctly updated many of the function definitions that were using this
extra regs pointer parameter but forgot to update some caller sites of
those functions.  The reason the modifications was not properly done on all
drivers is that some drivers were rarely compiled because they are for
AMIGA, or that some code sites were inside #ifdefs where the option is not
set or inside #if 0.

Here is the semantic patch that found the occurences
and fixed the problem.

@ rule1 @
identifier fn;
identifier irq, dev_id;
typedef irqreturn_t;
@@

static irqreturn_t fn(int irq, void *dev_id)
{
   ...
}

@@
identifier rule1.fn;
expression E1, E2, E3;
@@

 fn(E1, E2
-   ,E3
   )

Signed-off-by: Yoann Padioleau &lt;padator@wanadoo.fr&gt;
Cc: "David S. Miller" &lt;davem@davemloft.net&gt;
Cc: Jeff Garzik &lt;jeff@garzik.org&gt;
Cc: Greg KH &lt;greg@kroah.com&gt;
Signed-off-by: Andrew Morton &lt;akpm@linux-foundation.org&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@linux-foundation.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'merge' of git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc</title>
<updated>2007-07-05T22:55:00+00:00</updated>
<author>
<name>Linus Torvalds</name>
<email>torvalds@woody.linux-foundation.org</email>
</author>
<published>2007-07-05T22:55:00+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=0dac723e5c15ddb9bd26c1db21ee64ab71ae4925'/>
<id>0dac723e5c15ddb9bd26c1db21ee64ab71ae4925</id>
<content type='text'>
* 'merge' of git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc:
  [POWERPC] Update defconfigs
  [POWERPC] Uninline and export virq_to_hw() for the pasemi_mac driver
  [POWERPC] Fix PMI breakage in cbe_cbufreq driver
  [POWERPC] Disable old EMAC driver in arch/powerpc
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* 'merge' of git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc:
  [POWERPC] Update defconfigs
  [POWERPC] Uninline and export virq_to_hw() for the pasemi_mac driver
  [POWERPC] Fix PMI breakage in cbe_cbufreq driver
  [POWERPC] Disable old EMAC driver in arch/powerpc
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'for-linus' of master.kernel.org:/pub/scm/linux/kernel/git/roland/infiniband</title>
<updated>2007-07-03T04:05:35+00:00</updated>
<author>
<name>Linus Torvalds</name>
<email>torvalds@woody.linux-foundation.org</email>
</author>
<published>2007-07-03T04:05:35+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=52c4d73a6cca0db2927b60935e57429f98eae7c1'/>
<id>52c4d73a6cca0db2927b60935e57429f98eae7c1</id>
<content type='text'>
* 'for-linus' of master.kernel.org:/pub/scm/linux/kernel/git/roland/infiniband:
  IPoIB/cm: Partial error clean up unmaps wrong address
  mlx4_core: Add new Mellanox device IDs
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* 'for-linus' of master.kernel.org:/pub/scm/linux/kernel/git/roland/infiniband:
  IPoIB/cm: Partial error clean up unmaps wrong address
  mlx4_core: Add new Mellanox device IDs
</pre>
</div>
</content>
</entry>
<entry>
<title>mlx4_core: Add new Mellanox device IDs</title>
<updated>2007-07-03T03:41:35+00:00</updated>
<author>
<name>Jack Morgenstein</name>
<email>jackm@dev.mellanox.co.il</email>
</author>
<published>2007-07-02T14:36:18+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=786f238e4f2f0d962831ee3228f2327133eb082a'/>
<id>786f238e4f2f0d962831ee3228f2327133eb082a</id>
<content type='text'>
Add new IDs for PCIe gen2 devices.

Signed-off-by: Jack Morgenstein &lt;jackm@dev.mellanox.co.il&gt;
Signed-off-by: Roland Dreier &lt;rolandd@cisco.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Add new IDs for PCIe gen2 devices.

Signed-off-by: Jack Morgenstein &lt;jackm@dev.mellanox.co.il&gt;
Signed-off-by: Roland Dreier &lt;rolandd@cisco.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>3c589_cs: fix local_bh_enable warning</title>
<updated>2007-07-02T14:50:46+00:00</updated>
<author>
<name>Patrick McHardy</name>
<email>kaber@trash.net</email>
</author>
<published>2007-07-02T14:08:28+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=63ac9b915924d1237d2135fcb4de724e6127ca5e'/>
<id>63ac9b915924d1237d2135fcb4de724e6127ca5e</id>
<content type='text'>
Russell King wrote:
&gt; Having upgraded from 2.6.16 to 2.6.22-rc6, I'm now seeing the following.
&gt;
&gt; Looks like netfilter is calling local_bh_enable() with IRQs disabled,
&gt; which would appear to be illegal.  Thankfully, this is a warn-once
&gt; warning.
&gt;
&gt; WARNING: at /home/rmk/git/linux-2.6-rmk/kernel/softirq.c:138 local_bh_enable()
&gt; [...]
&gt; [&lt;c01447fc&gt;] (nf_conntrack_destroy+0x0/0x2c) from [&lt;c012c05c&gt;] (__kfree_skb+0xd0/0x100)
&gt; [&lt;c012bf8c&gt;] (__kfree_skb+0x0/0x100) from [&lt;c012c0d8&gt;] (kfree_skb+0x4c/0x50)
&gt;  r5:c12a3800 r4:00000300
&gt; [&lt;c012c08c&gt;] (kfree_skb+0x0/0x50) from [&lt;bf03cbb0&gt;] (el3_start_xmit+0xb8/0xd0 [3c589_cs])
&gt; [&lt;bf03caf8&gt;] (el3_start_xmit+0x0/0xd0 [3c589_cs]) from [&lt;c01324dc&gt;] (dev_hard_start_xmit+0x1a8/0x244)
&gt;  r7:c12a3800 r6:c1a9aa00 r5:c1a9aa00 r4:c12a3800
&gt; [&lt;c0132334&gt;] (dev_hard_start_xmit+0x0/0x244) from [&lt;c013fcc0&gt;] (__qdisc_run+0xb0/0x198)

Thats a bug in the 3c589_cs driver. Patch attached.

Signed-off-by: Patrick McHardy &lt;kaber@trash.net&gt;
Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Russell King wrote:
&gt; Having upgraded from 2.6.16 to 2.6.22-rc6, I'm now seeing the following.
&gt;
&gt; Looks like netfilter is calling local_bh_enable() with IRQs disabled,
&gt; which would appear to be illegal.  Thankfully, this is a warn-once
&gt; warning.
&gt;
&gt; WARNING: at /home/rmk/git/linux-2.6-rmk/kernel/softirq.c:138 local_bh_enable()
&gt; [...]
&gt; [&lt;c01447fc&gt;] (nf_conntrack_destroy+0x0/0x2c) from [&lt;c012c05c&gt;] (__kfree_skb+0xd0/0x100)
&gt; [&lt;c012bf8c&gt;] (__kfree_skb+0x0/0x100) from [&lt;c012c0d8&gt;] (kfree_skb+0x4c/0x50)
&gt;  r5:c12a3800 r4:00000300
&gt; [&lt;c012c08c&gt;] (kfree_skb+0x0/0x50) from [&lt;bf03cbb0&gt;] (el3_start_xmit+0xb8/0xd0 [3c589_cs])
&gt; [&lt;bf03caf8&gt;] (el3_start_xmit+0x0/0xd0 [3c589_cs]) from [&lt;c01324dc&gt;] (dev_hard_start_xmit+0x1a8/0x244)
&gt;  r7:c12a3800 r6:c1a9aa00 r5:c1a9aa00 r4:c12a3800
&gt; [&lt;c0132334&gt;] (dev_hard_start_xmit+0x0/0x244) from [&lt;c013fcc0&gt;] (__qdisc_run+0xb0/0x198)

Thats a bug in the 3c589_cs driver. Patch attached.

Signed-off-by: Patrick McHardy &lt;kaber@trash.net&gt;
Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>RESEND [PATCH 3/3] NetXen: Graceful teardown of interface and hardware upon module unload</title>
<updated>2007-07-02T12:24:52+00:00</updated>
<author>
<name>Dhananjay Phadke</name>
<email>dhananjay@netxen.com</email>
</author>
<published>2007-07-02T04:07:57+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=96acb6eb8effe7c2549909e2ee49f4130f2c167d'/>
<id>96acb6eb8effe7c2549909e2ee49f4130f2c167d</id>
<content type='text'>
Resending patch 3/3 only.

These changes allow driver close routine to be called during module unload,
to clean-up buffers and other software resources, flush queues etc. Also,
hardware is reset to pristine state.

Signed-off-by: Dhananjay Phadke &lt;dhananjay@netxen.com&gt;
Signed-off-by: Milan Bag &lt;mbag@netxen.com&gt;
Signed-off-by: Wen Xiong &lt;wenxiong@us.ibm.com&gt;
Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Resending patch 3/3 only.

These changes allow driver close routine to be called during module unload,
to clean-up buffers and other software resources, flush queues etc. Also,
hardware is reset to pristine state.

Signed-off-by: Dhananjay Phadke &lt;dhananjay@netxen.com&gt;
Signed-off-by: Milan Bag &lt;mbag@netxen.com&gt;
Signed-off-by: Wen Xiong &lt;wenxiong@us.ibm.com&gt;
Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>drivers/net/ns83820.c: fix a check-after-use</title>
<updated>2007-07-02T12:24:52+00:00</updated>
<author>
<name>Adrian Bunk</name>
<email>bunk@stusta.de</email>
</author>
<published>2007-07-01T20:21:10+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=d14e37e12087e98b63907518dff83a90297605d6'/>
<id>d14e37e12087e98b63907518dff83a90297605d6</id>
<content type='text'>
This patch fixes a check-after-use spotted by the Coverity checker.

Signed-off-by: Adrian Bunk &lt;bunk@stusta.de&gt;
Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This patch fixes a check-after-use spotted by the Coverity checker.

Signed-off-by: Adrian Bunk &lt;bunk@stusta.de&gt;
Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>net/usb/cdc_ether minor sparse cleanup</title>
<updated>2007-07-02T12:24:52+00:00</updated>
<author>
<name>David Brownell</name>
<email>david-b@pacbell.net</email>
</author>
<published>2007-07-01T18:47:59+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=afaee82c0aef7c2b30acff129c723031343e10c2'/>
<id>afaee82c0aef7c2b30acff129c723031343e10c2</id>
<content type='text'>
Remove an "sparse" warning about a shadowed variable name.

Signed-off-by: David Brownell &lt;dbrownell@users.sourceforge.net&gt;
Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Remove an "sparse" warning about a shadowed variable name.

Signed-off-by: David Brownell &lt;dbrownell@users.sourceforge.net&gt;
Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>RESEND [PATCH 2/3] NetXen: Support per PCI-function interrupt mask registers</title>
<updated>2007-07-02T12:24:52+00:00</updated>
<author>
<name>dhananjay.phadke@gmail.com</name>
<email>dhananjay.phadke@gmail.com</email>
</author>
<published>2007-07-01T18:56:00+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=2d1a3bbdf21d05e16703c8d608628ae4676eb3ac'/>
<id>2d1a3bbdf21d05e16703c8d608628ae4676eb3ac</id>
<content type='text'>
This patch updates the various access routines to access different
control and status settings present in different register locations.
This will fix problems related to working of different ports in
multi Port card.

Signed-off by: Dhananjay Phadke &lt;dhananjay@netxen.com&gt;
Signed-off by: Milan Bag &lt;mbag@netxen.com&gt;

Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This patch updates the various access routines to access different
control and status settings present in different register locations.
This will fix problems related to working of different ports in
multi Port card.

Signed-off by: Dhananjay Phadke &lt;dhananjay@netxen.com&gt;
Signed-off by: Milan Bag &lt;mbag@netxen.com&gt;

Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>RESEND [PATCH 1/3] NetXen: Fix issue of MSI not working correctly</title>
<updated>2007-07-02T12:24:52+00:00</updated>
<author>
<name>dhananjay.phadke@gmail.com</name>
<email>dhananjay.phadke@gmail.com</email>
</author>
<published>2007-07-01T18:55:59+00:00</published>
<link rel='alternate' type='text/html' href='https://git.tavy.me/linux.git/commit/?id=644caeefb3bbf539e74b7098648ff0bfc9e52bb3'/>
<id>644caeefb3bbf539e74b7098648ff0bfc9e52bb3</id>
<content type='text'>
NetXen driver uses PCI function 0 to provide the functionality of MSI.
The patch makes driver check the bus master bit for function 0 and
enable it after the card initialization.

Signed-off-by: Dhananjay Phadke&lt;dhananjay@netxen.com&gt;
Signed-off-by: Milan Bag &lt;mbag@netxen.com&gt;
Signed-off-by: Wen Xiong &lt;wenxiong@us.ibm.com&gt;
Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
NetXen driver uses PCI function 0 to provide the functionality of MSI.
The patch makes driver check the bus master bit for function 0 and
enable it after the card initialization.

Signed-off-by: Dhananjay Phadke&lt;dhananjay@netxen.com&gt;
Signed-off-by: Milan Bag &lt;mbag@netxen.com&gt;
Signed-off-by: Wen Xiong &lt;wenxiong@us.ibm.com&gt;
Signed-off-by: Jeff Garzik &lt;jeff@garzik.org&gt;
</pre>
</div>
</content>
</entry>
</feed>
