linux.git/drivers/net/wireless, branch v3.5-rc4

Fix typo in printed messages

2012-06-24T18:03:52+00:00

Coult -> Could

Signed-off-by: Linus Torvalds

iwlwifi: disable the buggy chain extension feature in HW

2012-06-08T17:47:07+00:00

This feature has been reported to be buggy and enabled by
default. We therefore need to disable it manually.

Cc: stable@vger.kernel.org
Signed-off-by: Emmanuel Grumbach 
Signed-off-by: Johannes Berg 
Signed-off-by: John W. Linville

iwlwifi: don't mess up the SCD when removing a key

2012-06-08T17:47:07+00:00

When we remove a key, we put a key index which was supposed
to tell the fw that we are actually removing the key. But
instead the fw took that index as a valid index and messed
up the SRAM of the device.

This memory corruption on the device mangled the data of
the SCD. The impact on the user is that SCD queue 2 got
stuck after having removed keys.
The message is the log that was printed is:

Queue 2 stuck for 10000ms

This doesn't seem to fix the higher queues that get stuck
from time to time.

Cc: stable@vger.kernel.org [2.6.27+]
Reviewed-by: Meenakshi Venkataraman 
Signed-off-by: Emmanuel Grumbach 
Signed-off-by: Johannes Berg 
Signed-off-by: John W. Linville

b43: do not call ieee80211_unregister_hw if we are not registred

2012-06-08T17:47:06+00:00

this patch fixes kernel Oops on "rmmod b43" if firmware was not loaded:

BUG: unable to handle kernel NULL pointer dereference at 0000000000000088
IP: [] drain_workqueue+0x25/0x142
PGD 153ac6067 PUD 153b82067 PMD 0
Oops: 0000 [#1] SMP

Signed-off-by: Oleksij Rempel 
Signed-off-by: John W. Linville

iwlwifi: use correct supported firmware for 6035 and 6000g2

2012-06-08T17:47:06+00:00

My patch

   iwlwifi: use correct released ucode version

did not correctly report supported firmware
for the 6035 device. This patch fixes it. The
minimum supported firmware version for 6035
is v6.

Also correct the minimum supported firmware
version for the 6000g2 series of devices.

Cc: stable@kernel.org
Signed-off-by: Meenakshi Venkataraman 
Reviewed-by: Emmanuel Grumbach 
Signed-off-by: Johannes Berg 
Signed-off-by: John W. Linville

mac80211_hwsim: Set IEEE80211_STAT_ACK flag when userspace indicates that the frame has been acknowledged.

2012-06-08T17:43:58+00:00

The station fail average is not updated correctly since the
IEEE80211_STAT_ACK flag is not set when using wmediumd with
mac80211_hwsim. Set this flag when wmediumd indicates that the frame
was successfully transmitted (eventually).

Signed-off-by: Qasim Javed 
Signed-off-by: Javier Cardona 
Signed-off-by: John W. Linville

rtl8187: ->brightness_set can not sleep

2012-06-08T17:43:57+00:00

Fix:

BUG: sleeping function called from invalid context at kernel/workqueue.c:2547
in_atomic(): 1, irqs_disabled(): 0, pid: 629, name: wpa_supplicant
2 locks held by wpa_supplicant/629:
 #0:  (rtnl_mutex){+.+.+.}, at: [] rtnl_lock+0x14/0x20
 #1:  (&trigger->leddev_list_lock){.+.?..}, at: [] led_trigger_event+0x21/0x80
Pid: 629, comm: wpa_supplicant Not tainted 3.3.0-0.rc3.git5.1.fc17.i686
Call Trace:
 [] __might_sleep+0x126/0x1d0
 [] wait_on_work+0x2c/0x1d0
 [] __cancel_work_timer+0x6a/0x120
 [] cancel_delayed_work_sync+0x10/0x20
 [] rtl8187_led_brightness_set+0x82/0xf0 [rtl8187]
 [] led_trigger_event+0x5c/0x80
 [] ieee80211_led_radio+0x1d/0x40 [mac80211]
 [] ieee80211_stop_device+0x13/0x230 [mac80211]

Removing _sync is ok, because if led_on work is currently running
it will be finished before led_off work start to perform, since
they are always queued on the same mac80211 local->workqueue.

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=795176

Signed-off-by: Stanislaw Gruszka 
Acked-by: Larry Finger 
Acked-by: Hin-Tak Leung 
Signed-off-by: John W. Linville

net/wireless: ipw2100: Fix WARN_ON occurring in wiphy_register called by ipw2100_pci_init_one

2012-06-08T17:43:57+00:00

The problem was found by Larry Finger:
http://marc.info/?l=linux-wireless&m=133702401700614&w=2

The problem is identical to the one for ipw2200 which is already fixed:
http://marc.info/?l=linux-wireless&m=133457257407196&w=2

[   17.766431] ------------[ cut here ]------------
[   17.766467] WARNING: at net/wireless/core.c:562 wiphy_register+0x34c/0x3c0 [cfg80211]()
[   17.766471] Hardware name: Latitude D600
[   17.766474] Modules linked in: ipw2100(+) libipw pcmcia cfg80211 ppdev parport_pc yenta_socket sr_mod pcmcia_rsrc parport iTCO_wdt cdrom sg rfkill pcmcia_
core lib80211 tg3 video button battery ac iTCO_vendor_support joydev shpchp pcspkr pciehp pci_hotplug autofs4 radeon ttm drm_kms_helper uhci_hcd ehci_hcd rtc
_cmos thermal drm hwmon i2c_algo_bit i2c_core processor usbcore usb_common ata_generic ata_piix ahci libahci libata
[   17.766525] Pid: 474, comm: modprobe Not tainted 3.4.0-rc7-wl+ #6
[   17.766528] Call Trace:
[   17.766541]  [] ? printk+0x28/0x2a
[   17.766552]  [] warn_slowpath_common+0x6d/0xa0
[   17.766563]  [] ? wiphy_register+0x34c/0x3c0 [cfg80211]
[   17.766573]  [] ? wiphy_register+0x34c/0x3c0 [cfg80211]
[   17.766578]  [] warn_slowpath_null+0x1d/0x20
[   17.766588]  [] wiphy_register+0x34c/0x3c0 [cfg80211]
[   17.766605]  [] ipw2100_wdev_init+0x196/0x1c0 [ipw2100]
[   17.766616]  [] ipw2100_pci_init_one+0x2b2/0x694 [ipw2100]
[   17.766632]  [] local_pci_probe+0x42/0xb0
[   17.766637]  [] pci_device_probe+0x60/0x90
[   17.766645]  [] ? sysfs_create_link+0x12/0x20
[   17.766654]  [] really_probe+0x56/0x2e0
[   17.766659]  [] ? create_dir+0x5d/0xa0
[   17.766667]  [] ? pm_runtime_barrier+0x3b/0xa0
[   17.766672]  [] driver_probe_device+0x44/0xa0
[   17.766677]  [] ? pci_match_device+0x97/0xa0
[   17.766681]  [] __driver_attach+0x89/0x90
[   17.766686]  [] ? driver_probe_device+0xa0/0xa0
[   17.766691]  [] bus_for_each_dev+0x3a/0x70
[   17.766695]  [] driver_attach+0x1c/0x30
[   17.766699]  [] ? driver_probe_device+0xa0/0xa0
[   17.766704]  [] bus_add_driver+0x187/0x280
[   17.766710]  [] ? kset_find_obj+0x2d/0x60
[   17.766715]  [] ? pci_device_probe+0x90/0x90
[   17.766719]  [] ? pci_device_probe+0x90/0x90
[   17.766724]  [] driver_register+0x65/0x110
[   17.766729]  [] __pci_register_driver+0x3d/0xa0
[   17.766738]  [] ipw2100_init+0x5c/0x1000 [ipw2100]
[   17.766743]  [] do_one_initcall+0x2f/0x170
[   17.766749]  [] ? 0xe09f6fff
[   17.766757]  [] sys_init_module+0xa8/0x210
[   17.766766]  [] syscall_call+0x7/0xb
[   17.766769] ---[ end trace 559898c6bb0d1c75 ]---
[   17.767093] ipw2100: probe of 0000:02:03.0 failed with error -5

This warning appears only if we apply Ben Hutchings' fix
http://marc.info/?l=linux-wireless&m=132720204412667&w=2
for the bug reported by Cesare Leonardi
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=656813
with cfg80211 warning during device registration
("cfg80211: failed to add phy80211 symlink to netdev!").

We separate device bring up and registration with network stack
to avoid the problem.

Signed-off-by: Stanislav Yakovlev 
Tested-by: Larry Finger 
Signed-off-by: John W. Linville

iwlwifi: unregister LEDs if mac80211 registration fails

2012-06-05T18:27:30+00:00

Otherwise the LEDs stick around and cause issues the
next time around since they're still there but not
really hooked up.

Cc: stable@kernel.org
Signed-off-by: Johannes Berg 
Signed-off-by: John W. Linville

iwlwifi: fix double free/complete in firmware loading

2012-06-05T18:27:29+00:00

Linus reported that due to mac80211 failing to register
the device (due to WoWLAN) his machine crashed etc. as
we double-freed the vmalloc() firmware area. His patch
to fix it was very similar to this one but I noticed
that there's another bug in the area: we complete the
completion before starting, so since we're running in
a work struct context stop() could be called while in
the middle of start() which will almost certainly lead
to issues.

Make a modification similar to his to avoid the double-
free but also move the completion to another spot so it
is only done after start() either finished or failed so
that stop() can have a consistent state.

Reported-by: Linus Torvalds 
Signed-off-by: Johannes Berg 
Signed-off-by: John W. Linville