linux.git/drivers/net/wireless/st, branch v5.12

cw1200: txrx: convert comma to semicolon

2020-12-10T18:49:14+00:00

Replace a comma between expression statements by a semicolon.

Signed-off-by: Zheng Yongjun 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20201209135550.2004-1-zhengyongjun3@huawei.com

cw1200: fix missing destroy_workqueue() on error in cw1200_init_common

2020-11-24T15:08:16+00:00

Add the missing destroy_workqueue() before return from
cw1200_init_common in the error handling case.

Fixes: a910e4a94f69 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN chipsets")
Reported-by: Hulk Robot 
Signed-off-by: Qinglang Miao 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20201119070842.1011-1-miaoqinglang@huawei.com

cw1200: replace a set of atomic_add()

2020-11-24T14:59:31+00:00

a set of atomic_inc() looks more readable

Signed-off-by: Yejune Deng 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/1604991491-27908-1-git-send-email-yejune.deng@gmail.com

cw1200: wsm: Remove 'dummy' variables

2020-09-01T09:02:43+00:00

They're never read, so there is no reason for them to exist.

They just cause the compiler to complain.

Fixes the following W=1 kernel build warning(s):

 drivers/net/wireless/st/cw1200/wsm.c: In function ‘wsm_ba_timeout_indication’:
 drivers/net/wireless/st/cw1200/wsm.c:1033:5: warning: variable ‘dummy2’ set but not used [-Wunused-but-set-variable]
 drivers/net/wireless/st/cw1200/wsm.c:1031:6: warning: variable ‘dummy’ set but not used [-Wunused-but-set-variable]

Cc: Solomon Peachy 
Cc: Kalle Valo 
Cc: "David S. Miller" 
Cc: Jakub Kicinski 
Cc: Dmitry Tarnyagin 
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20200819072402.3085022-14-lee.jones@linaro.org

treewide: replace '---help---' in Kconfig files with 'help'

2020-06-13T16:57:21+00:00

Since commit 84af7a6194e4 ("checkpatch: kconfig: prefer 'help' over
'---help---'"), the number of '---help---' has been gradually
decreasing, but there are still more than 2400 instances.

This commit finishes the conversion. While I touched the lines,
I also fixed the indentation.

There are a variety of indentation styles found.

  a) 4 spaces + '---help---'
  b) 7 spaces + '---help---'
  c) 8 spaces + '---help---'
  d) 1 space + 1 tab + '---help---'
  e) 1 tab + '---help---'    (correct indentation)
  f) 1 tab + 1 space + '---help---'
  g) 1 tab + 2 spaces + '---help---'

In order to convert all of them to 1 tab + 'help', I ran the
following commend:

  $ find . -name 'Kconfig*' | xargs sed -i 's/^[[:space:]]*---help---/\thelp/'

Signed-off-by: Masahiro Yamada

cw1200: Remove local sdio VENDOR and DEVICE id definitions

2020-05-29T17:15:24+00:00

They are already present in linux/mmc/sdio_ids.h.

Signed-off-by: Pali Rohár 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20200520125410.31757-1-pali@kernel.org

cw1200: make cw1200_spi_irq_unsubscribe() void

2020-04-15T08:38:26+00:00

Fix the following coccicheck warning:

drivers/net/wireless/st/cw1200/cw1200_spi.c:273:5-8: Unneeded variable:
"ret". Return "0" on line 279

Reported-by: Hulk Robot 
Signed-off-by: Jason Yan 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20200410090910.27132-1-yanaijie@huawei.com

cw1200: Replace zero-length array with flexible-array member

2020-03-23T17:14:44+00:00

The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.

Also, notice that, dynamic memory allocations won't be affected by
this change:

"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")

Signed-off-by: Gustavo A. R. Silva 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20200305111401.GA25126@embeddedor

cw1200: use true,false for bool variable

2020-01-26T15:40:43+00:00

Fixes coccicheck warning:

drivers/net/wireless/st/cw1200/txrx.c:718:6-16: WARNING: Assignment of 0/1 to bool variable

Reported-by: Hulk Robot 
Signed-off-by: zhengbin 
Signed-off-by: Kalle Valo

net/wireless: Delete unnecessary checks before the macro call “dev_kfree_skb”

2019-10-15T05:27:02+00:00

The dev_kfree_skb() function performs also input parameter validation.
Thus the test around the shown calls is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
Signed-off-by: Kalle Valo