linux.git/drivers/net/wireless/rsi, branch v6.5

wifi: rsi: Do not set MMC_PM_KEEP_POWER in shutdown

2023-06-08T16:02:14+00:00

It makes no sense to set MMC_PM_KEEP_POWER in shutdown. The flag
indicates to the MMC subsystem to keep the slot powered on during
suspend, but in shutdown the slot should actually be powered off.
Drop this call.

Fixes: 063848c3e155 ("rsi: sdio: Add WOWLAN support for S5 shutdown state")
Signed-off-by: Marek Vasut 
Reviewed-by: Simon Horman 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20230527222859.273768-1-marex@denx.de

wifi: rsi: Do not configure WoWlan in shutdown hook if not enabled

2023-06-08T16:00:39+00:00

In case WoWlan was never configured during the operation of the system,
the hw->wiphy->wowlan_config will be NULL. rsi_config_wowlan() checks
whether wowlan_config is non-NULL and if it is not, then WARNs about it.
The warning is valid, as during normal operation the rsi_config_wowlan()
should only ever be called with non-NULL wowlan_config. In shutdown this
rsi_config_wowlan() should only ever be called if WoWlan was configured
before by the user.

Add checks for non-NULL wowlan_config into the shutdown hook. While at it,
check whether the wiphy is also non-NULL before accessing wowlan_config .
Drop the single-use wowlan_config variable, just inline it into function
call.

Fixes: 16bbc3eb8372 ("rsi: fix null pointer dereference during rsi_shutdown()")
Signed-off-by: Marek Vasut 
Reviewed-by: Simon Horman 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20230527222833.273741-1-marex@denx.de

wifi: rsi: Slightly simplify rsi_set_channel()

2023-03-31T14:45:50+00:00

There is no point in allocating 'skb' and then freeing it if !channel.

Make the sanity check first to slightly simplify the code.

Signed-off-by: Christophe JAILLET 
Reviewed-by: Simon Horman 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/29bf0296bd939e3f6952272bfdcc73b22edbc374.1679328588.git.christophe.jaillet@wanadoo.fr

wifi: rsi: Avoid defines prefixed with CONFIG

2023-02-13T17:24:10+00:00

Macros prefixed with CONFIG_ are intended to be defined only by
Kconfig scripts. Here we remove the prefix from the
CONFIG_AUTO_READ_MODE define to avoid confusion when reading the code.

This causes no change to functionality.

Signed-off-by: Peter Lafreniere 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20230118185353.2422-1-peter@n8pjl.ca

wifi: rsi: Fix memory leak in rsi_coex_attach()

2022-12-14T12:19:41+00:00

The coex_cb needs to be freed when rsi_create_kthread() failed in
rsi_coex_attach().

Fixes: 2108df3c4b18 ("rsi: add coex support")
Signed-off-by: Yuan Can 
Reviewed-by: Simon Horman 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20221205061441.114632-1-yuancan@huawei.com

wifi: rsi: Fix handling of 802.3 EAPOL frames sent via control port

2022-11-08T07:41:02+00:00

When using wpa_supplicant v2.10, this driver is no longer able to
associate with any AP and fails in the EAPOL 4-way handshake while
sending the 2/4 message to the AP. The problem is not present in
wpa_supplicant v2.9 or older. The problem stems from HostAP commit
144314eaa ("wpa_supplicant: Send EAPOL frames over nl80211 where available")
which changes the way EAPOL frames are sent, from them being send
at L2 frames to them being sent via nl80211 control port.

An EAPOL frame sent as L2 frame is passed to the WiFi driver with
skb->protocol ETH_P_PAE, while EAPOL frame sent via nl80211 control
port has skb->protocol set to ETH_P_802_3 . The later happens in
ieee80211_tx_control_port(), where the EAPOL frame is encapsulated
into 802.3 frame.

The rsi_91x driver handles ETH_P_PAE EAPOL frames as high-priority
frames and sends them via highest-priority transmit queue, while
the ETH_P_802_3 frames are sent as regular frames. The EAPOL 4-way
handshake frames must be sent as highest-priority, otherwise the
4-way handshake times out.

Therefore, to fix this problem, inspect the skb control flags and
if flag IEEE80211_TX_CTRL_PORT_CTRL_PROTO is set, assume this is
an EAPOL frame and transmit the frame via high-priority queue just
like other ETH_P_PAE frames.

Fixes: 0eb42586cf87 ("rsi: data packet descriptor enhancements")
Signed-off-by: Marek Vasut 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20221104163339.227432-1-marex@denx.de

wifi: mac80211: add wake_tx_queue callback to drivers

2022-10-10T09:00:03+00:00

mac80211 is fully switching over to the internal TX queue (iTXQ)
implementation. Update all drivers not yet providing the now mandatory
wake_tx_queue() callback.

As an side effect the netdev interfaces of all updated drivers will
switch to the noqueue qdisc.

Signed-off-by: Alexander Wetzel 
[add staging drivers]
Signed-off-by: Johannes Berg

wifi: rsi: fix kernel-doc warning

2022-09-06T08:34:40+00:00

One of my previous patches here changed the function prototype,
but since it was (half?) automated, I didn't update the docs.
Fix that now.

Fixes: b3e2130bf5f6 ("wifi: mac80211: change QoS settings API to take link into account")
Signed-off-by: Johannes Berg

wifi: rsi: fix repeated words in comments

2022-07-18T12:11:53+00:00

Delete the redundant word 'the'.

Signed-off-by: Jilin Yuan 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20220710043007.33288-1-yuanjilin@cdjrlc.com

wifi: mac80211: change QoS settings API to take link into account

2022-07-15T09:43:15+00:00

Take the link into account in the QoS settings (EDCA parameters)
APIs.

Signed-off-by: Johannes Berg