linux.git/drivers/net/wireless/realtek, branch v6.11

wifi: rtlwifi: rtl8192du: Initialise value32 in _rtl92du_init_queue_reserved_page

2024-08-07T17:11:36+00:00

GCC complains:

   In file included from include/linux/ieee80211.h:21,
                    from include/net/mac80211.h:20,
                    from drivers/net/wireless/realtek/rtlwifi/rtl8192du/../wifi.h:14,
                    from drivers/net/wireless/realtek/rtlwifi/rtl8192du/hw.c:4:
   In function 'u32p_replace_bits',
       inlined from '_rtl92du_init_queue_reserved_page.isra' at drivers/net/wireless/realtek/rtlwifi/rtl8192du/hw.c:225:2:
>> include/linux/bitfield.h:189:18: warning: 'value32' is used uninitialized [-Wuninitialized]

Part of the variable is indeed left uninitialised.

Reported-by: kernel test robot 
Closes: https://lore.kernel.org/oe-kbuild-all/202408062100.DWhN0CYH-lkp@intel.com/
Fixes: e769c67105d3 ("wifi: rtlwifi: Add rtl8192du/hw.{c,h}")
Signed-off-by: Bitterblue Smith 
Acked-by: Ping-Ke Shih 
Signed-off-by: Kalle Valo 
Link: https://patch.msgid.link/2a808244-93d0-492c-b304-ae1974df5df9@gmail.com

Merge tag 'rtw-next-2024-07-05' of https://github.com/pkshih/rtw

2024-07-09T10:17:09+00:00

rtw-next patches for v6.11

Some cleanups of rtl8xxxu and rtlwifi, and some fixes of rtw88. The major
change is to develop WoWLAN and preparation of RTL8852BE-VT listed below:

rtw89:
  - preparation of RTL8852BE-VT
    * add RF calibration code
    * move shared code with RTL8852BE to common module
  - add WoWLAN for WiFi 6 chips
  - support 36-bit PCI DMA

wifi: rtw89: Fix array index mistake in rtw89_sta_info_get_iter()

2024-07-05T02:03:48+00:00

In rtw89_sta_info_get_iter() 'status->he_gi' is compared to array size.
But then 'rate->he_gi' is used as array index instead of 'status->he_gi'.
This can lead to go beyond array boundaries in case of 'rate->he_gi' is
not equal to 'status->he_gi' and is bigger than array size. Looks like
"copy-paste" mistake.

Fix this mistake by replacing 'rate->he_gi' with 'status->he_gi'.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
Signed-off-by: Aleksandr Mishin 
Signed-off-by: Ping-Ke Shih 
Link: https://patch.msgid.link/20240703210510.11089-1-amishin@t-argos.ru

wifi: rtlwifi: fix default typo

2024-07-05T01:59:46+00:00

Change 'defult' to 'default' in comments in several rtlwifi drivers.

Signed-off-by: Fredrik Lönnegren 
Acked-by: Ping-Ke Shih 
Signed-off-by: Ping-Ke Shih 
Link: https://patch.msgid.link/20240703070627.135328-1-fredrik@frelon.se

wifi: rtw89: unify the selection logic of RFK table when MCC

2024-07-05T01:51:34+00:00

Driver will notify FW the target index of RFK table to use at some
moments. When MCC (multi-channel concurrent), the correctness of the
notification is especially important.

We now unify the selection logic of RFK table as below among chips.
1. check each table if it matches target channel
2. check all tables if any is idle by iterating active channels
3. replace the first table if all are busy unexpectedly

Signed-off-by: Zong-Zhe Yang 
Signed-off-by: Ping-Ke Shih 
Link: https://patch.msgid.link/20240702124452.18747-2-pkshih@realtek.com

wifi: rtw89: mac: parse MRC C2H failure report

2024-07-05T01:50:44+00:00

MRC (multi-role concurrency) has a C2H event for status report. Newer
FW will report some kinds of failures. We parse them now and show by
debug log.

Signed-off-by: Zong-Zhe Yang 
Signed-off-by: Ping-Ke Shih 
Link: https://patch.msgid.link/20240702124452.18747-1-pkshih@realtek.com

wifi: rtw89: 8852bx: add extra handles of BTC for 8852BT in 8852b_common

2024-07-05T01:48:10+00:00

For 8852BT, the initial settings of BT-coexistence is a little bit
different, so add the extra handles.

Signed-off-by: Ping-Ke Shih 
Link: https://patch.msgid.link/20240701014619.7300-2-pkshih@realtek.com

wifi: rtw89: 8852bx: move BTC common code from 8852b to 8852b_common

2024-07-05T01:47:57+00:00

The BT coexistence part of 8852B and 8852BT are similar, so move shared
code into common module.

Don't change logic for existing RTL8852BE.

Signed-off-by: Ping-Ke Shih 
Link: https://patch.msgid.link/20240701014619.7300-1-pkshih@realtek.com

wifi: rtw88: usb: schedule rx work after everything is set up

2024-07-05T01:38:18+00:00

Right now it's possible to hit NULL pointer dereference in
rtw_rx_fill_rx_status on hw object and/or its fields because
initialization routine can start getting USB replies before
rtw_dev is fully setup.

The stack trace looks like this:

rtw_rx_fill_rx_status
rtw8821c_query_rx_desc
rtw_usb_rx_handler
...
queue_work
rtw_usb_read_port_complete
...
usb_submit_urb
rtw_usb_rx_resubmit
rtw_usb_init_rx
rtw_usb_probe

So while we do the async stuff rtw_usb_probe continues and calls
rtw_register_hw, which does all kinds of initialization (e.g.
via ieee80211_register_hw) that rtw_rx_fill_rx_status relies on.

Fix this by moving the first usb_submit_urb after everything
is set up.

For me, this bug manifested as:
[    8.893177] rtw_8821cu 1-1:1.2: band wrong, packet dropped
[    8.910904] rtw_8821cu 1-1:1.2: hw->conf.chandef.chan NULL in rtw_rx_fill_rx_status
because I'm using Larry's backport of rtw88 driver with the NULL
checks in rtw_rx_fill_rx_status.

Link: https://lore.kernel.org/linux-wireless/CA+shoWQ7P49jhQasofDcTdQhiuarPTjYEDa--NiVVx494WcuQw@mail.gmail.com/
Signed-off-by: Marcin Ślusarz 
Cc: Tim K 
Cc: Ping-Ke Shih 
Cc: Larry Finger 
Cc: Kalle Valo 
Cc: linux-wireless@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ping-Ke Shih 
Link: https://patch.msgid.link/20240528110246.477321-1-marcin.slusarz@gmail.com

wifi: rtw89: 8852bt: rfk: add RCK

2024-07-02T11:43:54+00:00

RCK is synchronize RC calibration. Driver triggers this calibration and
writes the result to registers.

Signed-off-by: Ping-Ke Shih 
Link: https://patch.msgid.link/20240627025849.25198-5-pkshih@realtek.com