linux.git/drivers/net/wireless/realtek, branch v5.8

treewide: replace '---help---' in Kconfig files with 'help'

2020-06-13T16:57:21+00:00

Since commit 84af7a6194e4 ("checkpatch: kconfig: prefer 'help' over
'---help---'"), the number of '---help---' has been gradually
decreasing, but there are still more than 2400 instances.

This commit finishes the conversion. While I touched the lines,
I also fixed the indentation.

There are a variety of indentation styles found.

  a) 4 spaces + '---help---'
  b) 7 spaces + '---help---'
  c) 8 spaces + '---help---'
  d) 1 space + 1 tab + '---help---'
  e) 1 tab + '---help---'    (correct indentation)
  f) 1 tab + 1 space + '---help---'
  g) 1 tab + 2 spaces + '---help---'

In order to convert all of them to 1 tab + 'help', I ran the
following commend:

  $ find . -name 'Kconfig*' | xargs sed -i 's/^[[:space:]]*---help---/\thelp/'

Signed-off-by: Masahiro Yamada

rtw88: 8822c: remove CCK TX setting when switch channel

2020-05-29T17:37:10+00:00

The CCK TX setting when switch channel will fix the CCK to
path A only, so if the antenna is configured to path B
(e.g. iw phy set antenna 0x2 0x3 "TX B/RX AB"), then the CCK
packets can never be delivered to the air if only path B is
connected with an antenna (it can possibly be transmitted
through path A, but as path B is configured, the expected
behavior is incorrect).

This can also solve the racing issue of CCK TX setting between
driver and firmware. The CCK TX setting in driver should be
removed. Otherwise, the CCK TX setting would be wrong when the
racing occurs.

Fixes: 297bcf8222f2 ("rtw88: add support for set/get antennas")
Signed-off-by: Chien-Hsun Liao 
Signed-off-by: Yan-Hsuan Chuang 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20200522091234.24495-1-yhchuang@realtek.com

rtw88: 8822c: fix missing brace warning for old compilers

2020-05-29T17:36:41+00:00

For older versions of gcc, the array = {0}; will cause warnings:

drivers/net/wireless/realtek/rtw88/rtw8822c.c: In function 'rtw8822c_power_trim':
>> drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning:
>> missing braces around initializer [-Wmissing-braces]
s8 bb_gain[2][8] = {0};
^
drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning: (near
initialization for 'bb_gain[0]') [-Wmissing-braces]

Fixes: 5ad4d8957b69 ("rtw88: set power trim according to efuse PG values")
Reported-by: kbuild test robot 
Signed-off-by: Yan-Hsuan Chuang 
Acked-by: Sebastian Andrzej Siewior 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20200522035521.12295-1-yhchuang@realtek.com

rtw88: fix EAPOL 4-way failure by finish IQK earlier

2020-05-29T17:36:05+00:00

Connecting to an AP with WPA2 security may fail. The IQK
and the EAPOL 4-way handshake may overlap because the
driver does IQK right after assoc success.

For 802.11n devices, the IQK is done in the driver and it
could require more than 100ms to complete. During IQK, any
TX/RX events are paused. So if the EAPOL 4-way handshake
started before IQK finished, then the 1/4 and 2/4 part of
the handshake could be dropped. The AP will then issue
deauth with reason IEEE8021X_FAILED (23).

To resolve this, move IQK routine into managed TX prepare
(ieee80211_ops::mgd_prepare_tx()). The callback is called
before the managed frames (auth/assoc) are sent. This will
make sure that the IQK is completed before the handshake
starts. But don't do IQK during scanning because doing it
on each channel will take too long.

For 802.11ac devices, the IQK is done in firmware and it
takes less time to complete. Therefore we don't see a
failure during the EAPOL 4-way handshake. But it is still
worth moving the IQK into ieee80211_ops::mgd_prepare_tx().

Fixes: f5df1a8b4376 ("rtw88: 8723d: Add 8723DE to Kconfig and Makefile")
Tested-by: You-Sheng Yang 
Signed-off-by: Ping-Ke Shih 
Signed-off-by: Yan-Hsuan Chuang 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20200529025009.2468-4-yhchuang@realtek.com

rtw88: coex: 8723d: handle BT inquiry cases

2020-05-29T17:36:04+00:00

Coex mechanism used to make BT have higher priority and more time to
transfer data when BT inquiry-page, which leads to poor WiFi performance.
Should take WiFi traffic into consideration. If the WiFi is having heavy
traffic, use another parameter to make sure WiFi has more chance to TX/RX,
while guarantee the priority of BT for inquiry. If the WiFi isn't busy
(connected or not), set proper parameter to fix originals.

Fixes: f5df1a8b4376 ("rtw88: 8723d: Add 8723DE to Kconfig and Makefile")
Tested-by: You-Sheng Yang 
Signed-off-by: Ping-Ke Shih 
Signed-off-by: Yan-Hsuan Chuang 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20200529025009.2468-3-yhchuang@realtek.com

rtw88: coex: 8723d: set antanna control owner

2020-05-29T17:36:02+00:00

Without setting antenna control owner, the WiFi could be disconnected if
the BT has traffic. Because the antenna is switched to BT side for its
traffic, and the WiFi will have no chance to transfer data. Set control
owner to prevent WiFi disconnect issue.

Fixes: f5df1a8b4376 ("rtw88: 8723d: Add 8723DE to Kconfig and Makefile")
Tested-by: You-Sheng Yang 
Signed-off-by: Ping-Ke Shih 
Signed-off-by: Yan-Hsuan Chuang 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20200529025009.2468-2-yhchuang@realtek.com

Revert "rtw88: no need to set registers for SDIO"

2020-05-29T17:11:06+00:00

This reverts commit 07d0f5534935e2daf63a4e1012af13d68e089fed.

For rtw88 driver, the SDIO is going to be supported, so there is
no need to remove the SDIO related power sequence settings. And
while the power sequence parser will pass in the mask of the HCI,
the SDIO part will not be used to set registers accordingly.

Moreover, the power sequence table is released as a whole package,
so the next time if we are going to update, the SDIO settings will
be overwritten. So, revert this now.

Signed-off-by: Yan-Hsuan Chuang 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20200520055350.23328-1-yhchuang@realtek.com

rtlwifi: rtl8192ee: remove redundant for-loop

2020-05-18T12:19:17+00:00

The for-loop seems to be redundant, the assignments for indexes
0..2 are being over-written by the last index 3 in the loop. Remove
the loop and use index 3 instead.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20200515102226.29819-1-colin.king@canonical.com

rtw88: no need to set registers for SDIO

2020-05-18T12:17:58+00:00

There's no need to set SDIO related registers when powering up/down the chip.

Signed-off-by: Kevin Lo 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20200515061153.GA15714@ns.kevlo.org

rtw88: 8723d: fix incorrect setting of ldo_pwr

2020-05-18T12:17:26+00:00

Currently ldo_pwr has the LDO25 voltage bits set to zero and then
it is overwritten with the new voltage setting. The assignment
looks incorrect, it should be bit-wise or'ing in the new voltage
setting rather than a direct assignment.

Addresses-Coverity: ("Unused value")
Fixes: 1afb5eb7a00d ("rtw88: 8723d: Add cfg_ldo25 to control LDO25")
Signed-off-by: Colin Ian King 
Acked-by: Ping-Ke Shih 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20200514181329.16292-1-colin.king@canonical.com