linux.git/drivers/net/wireless/realtek, branch v4.9

rtlwifi: Fix regression caused by commit d86e64768859

2016-10-13T10:22:13+00:00

In commit d86e64768859 ("rtlwifi: rtl818x: constify local structures"),
the configuration struct for most of the drivers was changed to be
constant. The problem is that five of the modified drivers need to be
able to update the firmware name based on the exact model of the card.
As the file names were stored in one of the members of that struct,
these drivers would fail with a kernel BUG splat when they tried to
update the firmware name.

Rather than reverting the previous commit, I used a suggestion by
Johannes Berg and made the firmware file name pointers be local to
the routines that update the software variables.

The configuration struct of rtl8192cu, which was not touched in the
previous patch, is now constantfied.

Fixes: d86e64768859 ("rtlwifi: rtl818x: constify local structures")
Suggested-by: Johannes Berg 
Signed-off-by: Larry Finger 
Cc: Stable  # 4.8
Cc: Julia Lawall 
Signed-off-by: Kalle Valo

rtl8xxxu: Fix rtl8192eu driver reload issue

2016-10-07T11:24:20+00:00

The 8192eu suffered from two issues when reloading the driver.

The same problems as with the 8723bu where REG_RX_WAIT_CCA bits 22 and
23 didn't get set in rtl8192e_enable_rf().

In addition it also seems prone to issues when setting REG_RF_CTRL to
0 intead of just disabling the RF_ENABLE bit. Similar to what was
causing issues with the 8188eu.

With this patch I can successfully reload the driver and reassociate
to an APi with an 8192eu dongle.

Signed-off-by: Jes Sorensen 
Cc: stable@vger.kernel.org # 4.8+
Signed-off-by: Kalle Valo

rtl8xxxu: Fix rtl8723bu driver reload issue

2016-10-07T11:23:50+00:00

The generic disable_rf() function clears bits 22 and 23 in
REG_RX_WAIT_CCA, however we did not re-enable them again in
rtl8723b_enable_rf()

This resolves the problem for me with 8723bu devices not working again
after reloading the driver.

Signed-off-by: Jes Sorensen 
Cc: stable@vger.kernel.org # 4.7+
Signed-off-by: Kalle Valo

rtl8xxxu: Fix big-endian problem reporting mactime

2016-10-07T11:22:35+00:00

The full RX descriptor is converted so converting tsfl again would
return it to it's original endian value.

Signed-off-by: Jes Sorensen 
Cc: stable@vger.kernel.org # 4.8+
Signed-off-by: Kalle Valo

rtl8xxxu: Fix memory leak in handling rxdesc16 packets

2016-10-07T11:22:15+00:00

A device running without RX package aggregation could return more data
in the USB packet than the actual network packet. In this case we
could would clone the skb but then determine that that there was no
packet to handle and exit without freeing the cloned skb first.

This has so far only been observed with 8188eu devices, but could
affect others.

Signed-off-by: Jes Sorensen 
Cc: stable@vger.kernel.org # 4.8+
Signed-off-by: Kalle Valo

rtlwifi: Add explicit values to hw_variables enum

2016-09-27T15:46:03+00:00

The entries in this enum may be referenced in debug output. Adding explicit
values simplifies the lookup.

Signed-off-by: Larry Finger 
Signed-off-by: Kalle Valo

rtlwifi: Add HAL_DEF_WOWLAN case to *_get_hw() routines

2016-09-27T15:46:03+00:00

Only rtl8821ae implements WOWLAN; however, the other drivers may receive
a call requesting information about this mode. The other drivers need to
ignore the request rather than logging that the default branch of the
switch statement has been reached.

Reported by: Jean Delvare 
Signed-off-by: Larry Finger 
Signed-off-by: Kalle Valo

rtlwifi: Add switch variable to 'switch case not processed' messages

2016-09-27T15:44:19+00:00

Help along debugging by showing what switch/case variable is not
being processed in these messages.

Signed-off-by: Joe Perches 
Acked-by: Larry Finger 
Signed-off-by: Kalle Valo

rtl8xxxu: Stop log spam from each successful interrupt

2016-09-26T17:41:37+00:00

As soon as debugging is turned on, the logs are filled with messages
reporting the interrupt status. As this quantity is usually zero, this
output is not needed. In fact, there will be a report if the status is
not zero, thus the debug line in question could probably be deleted.
Rather than taking that action, I have changed it to only be printed
when the newly added RTL8XXXU_DEBUG_INTERRUPT bit is set in the debug
mask.

Signed-off-by: Larry Finger 
Signed-off-by: Jes Sorensen 
Signed-off-by: Kalle Valo

rtl8xxxu: Use a struct rtl8xxxu_fileops * in rtl8xxxu_init_device()

2016-09-26T17:41:36+00:00

This saves some 217, or about, derefences of priv->fops.

Signed-off-by: Jes Sorensen 
Signed-off-by: Kalle Valo