linux.git/drivers/net/wireless/realtek/rtlwifi/debug.c, branch vsnprintf

wifi: rtlwifi: fix incorrect error codes in rtl_debugfs_set_write_reg()

2023-03-31T14:51:33+00:00

If there is a failure during copy_from_user or user-provided data buffer is
invalid, rtl_debugfs_set_write_reg should return negative error code instead
of a positive value count.

Fix this bug by returning correct error code. Moreover, the check of buffer
against null is removed since it will be handled by copy_from_user.

Fixes: 610247f46feb ("rtlwifi: Improve debugging by using debugfs")
Signed-off-by: Wei Chen 
Reviewed-by: Simon Horman 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20230326054217.93492-1-harperchen1110@gmail.com

wifi: rtlwifi: fix incorrect error codes in rtl_debugfs_set_write_rfreg()

2023-03-31T14:51:02+00:00

If there is a failure during copy_from_user or user-provided data buffer
is invalid, rtl_debugfs_set_write_rfreg should return negative error code
instead of a positive value count.

Fix this bug by returning correct error code. Moreover, the check of buffer
against null is removed since it will be handled by copy_from_user.

Fixes: 610247f46feb ("rtlwifi: Improve debugging by using debugfs")
Signed-off-by: Wei Chen 
Reviewed-by: Simon Horman 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20230326053138.91338-1-harperchen1110@gmail.com

wifi: rtlwifi: fix error codes in rtl_debugfs_set_write_h2c()

2022-05-30T11:17:26+00:00

If the copy_from_user() fails or the user gives invalid date then the
correct thing to do is to return a negative error code.  (Currently it
returns success).

I made a copy additional related cleanups:
1) There is no need to check "buffer" for NULL.  That's handled by
copy_from_user().
2) The "h2c_len" variable cannot be negative because it is unsigned
and because sscanf() does not return negative error codes.

Fixes: 610247f46feb ("rtlwifi: Improve debugging by using debugfs")
Signed-off-by: Dan Carpenter 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/YoOLnDkHgVltyXK7@kili

net: rtlwifi: Remove in_interrupt() from debug macro

2020-09-29T21:02:55+00:00

The usage of in_interrupt() in drivers in is phased out.

rtl_dbg() a printk based debug aid is using in_interrupt() in the
underlying C function _rtl_dbg_out() which is almost identical to
_rtl_dbg_print(). The only difference is the printout of in_interrupt().

The decoding of in_interrupt() as hexvalue is non-trivial and aside of
being phased out for driver usage the return value is just by chance the
masked preempt count value and not a boolean.

These home brewn printk debug aids are tedious to work with and provide
only minimal context.  They should be replaced by trace_printk() or a debug
tracepoint which automatically records all context information.

To make progress on the in_interrupt() cleanup, make rtl_dbg() use
_rtl_dbg_print() and remove _rtl_dbg_out().

Signed-off-by: Sebastian Andrzej Siewior 
Signed-off-by: Thomas Gleixner 
Acked-by: Kalle Valo 
Signed-off-by: David S. Miller

rtlwifi: Remove temporary definition of RT_TRACE

2020-09-02T09:03:47+00:00

A definition of this macro was kept until all drivers had been converted.
It can now be deleted.

This change also renames _rtl_dbg_trace() to _rtl_dbg_out().

Signed-off-by: Larry Finger 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20200831185046.30307-1-Larry.Finger@lwfinger.net

rtlwifi: Replace RT_TRACE with rtl_dbg

2020-08-31T15:25:43+00:00

The macro name RT_TRACE makes it seem that it is used for tracing, when
is actually used for debugging. Change the name to rtl_dbg. Any Sparse
errors exposed by this change were also fixed.

Signed-off-by: Larry Finger 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20200723204244.24457-3-Larry.Finger@lwfinger.net

rtlwifi: Fix file release memory leak

2019-09-06T14:11:36+00:00

When using single_open() for opening, single_release() should be
used instead of seq_release(), otherwise there is a memory leak.

This is detected by Coccinelle semantic patch.

Fixes: 610247f46feb ("rtlwifi: Improve debugging by using debugfs")
Signed-off-by: Wei Yongjun 
Signed-off-by: Kalle Valo

rtlwifi: Replace old-style license information

2019-02-19T14:59:43+00:00

The traditional license information is replaced by the SPDX form. There
are no code changes.

Signed-off-by: Larry Finger 
Signed-off-by: Kalle Valo

rtlwifi: no need to check return value of debugfs_create functions

2019-02-01T12:33:13+00:00

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Ping-Ke Shih 
Cc: Kalle Valo 
Cc: linux-wireless@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman 
Acked-by: Larry Finger 
Signed-off-by: Kalle Valo

rtlwifi: Improve debugging by using debugfs

2018-01-08T17:07:45+00:00

Use debugfs to dump register and btcoex status, and also write registers
and h2c.

We create topdir in /sys/kernel/debug/rtlwifi/, and use the MAC address
as subdirectory with several entries to dump mac_reg, bb_reg, rf_reg etc.
An example is
    /sys/kernel/debug/rtlwifi/00-11-22-33-44-55-66/mac_0

This change permits examination of device registers in a dynamic manner,
a feature not available with the current debug mechanism.

Signed-off-by: Ping-Ke Shih 
Signed-off-by: Kalle Valo