linux.git/drivers/net/wireless/ray_cs.c, branch v5.8

ray_cs: use true,false for bool variable

2020-05-06T08:33:23+00:00

Fix the following coccicheck warning:

drivers/net/wireless/ray_cs.c:2797:5-14: WARNING: Comparison of 0/1 to
bool variable
drivers/net/wireless/ray_cs.c:2798:2-11: WARNING: Assignment of 0/1 to
bool variable

Signed-off-by: Jason Yan 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20200426103709.6730-1-yanaijie@huawei.com

proc: convert everything to "struct proc_ops"

2020-02-04T03:05:26+00:00

The most notable change is DEFINE_SHOW_ATTRIBUTE macro split in
seq_file.h.

Conversion rule is:

	llseek		=> proc_lseek
	unlocked_ioctl	=> proc_ioctl

	xxx		=> proc_xxx

	delete ".owner = THIS_MODULE" line

[akpm@linux-foundation.org: fix drivers/isdn/capi/kcapi_proc.c]
[sfr@canb.auug.org.au: fix kernel/sched/psi.c]
  Link: http://lkml.kernel.org/r/20200122180545.36222f50@canb.auug.org.au
Link: http://lkml.kernel.org/r/20191225172546.GB13378@avx2
Signed-off-by: Alexey Dobriyan 
Signed-off-by: Stephen Rothwell 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 416

2019-06-05T15:37:15+00:00

Based on 1 normalized pattern(s):

  this driver is free software you can redistribute it and or modify
  it under the terms of version 2 only of the gnu general public
  license as published by the free software foundation it is
  distributed in the hope that it will be useful but without any
  warranty without even the implied warranty of merchantability or
  fitness for a particular purpose see the gnu general public license
  for more details you should have received a copy of the gnu general
  public license along with this program if not see http www gnu org
  licenses

extracted by the scancode license scanner the SPDX license identifier

  GPL-2.0-only

has been chosen to replace the boilerplate/reference in 1 file(s).

Signed-off-by: Thomas Gleixner 
Reviewed-by: Allison Randal 
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190531190113.237458590@linutronix.de
Signed-off-by: Greg Kroah-Hartman

ray_cs: use remove_proc_subtree to simplify procfs code

2019-04-25T16:38:52+00:00

Use remove_proc_subtree to remove the whole subtree

Signed-off-by: YueHaibing 
Signed-off-by: Kalle Valo

ray_cs: Check return value of pcmcia_register_driver

2019-04-25T16:38:26+00:00

init_ray_cs does not check value of pcmcia_register_driver,
if it fails, there maybe cause a NULL pointer dereference in
exit_ray_cs.

Signed-off-by: YueHaibing 
Signed-off-by: Kalle Valo

wireless: remove unneeded semicolon

2019-02-01T12:25:41+00:00

remove unneeded semicolon

Signed-off-by: YueHaibing 
Acked-by: Ping-Ke Shih 
Acked-by: Steve deRosier 
Acked-by: Arend van Spriel 
Signed-off-by: Kalle Valo

ray_cs: fix array out-of-bounds access

2019-01-10T11:32:40+00:00

Currently array element org[3] is being accessed, however the array is
only 3 elements in size, so this looks like an off-by-one out-of-bounds
error. Fix this by using org[2], which I believe was the original
intent.

This issue has existed in the driver back in the pre-git days, so no
idea when it was introduced.

Detected by CoverityScan, CID#711344 ("Out-of-bounds read")
Signed-off-by: Colin Ian King 
Signed-off-by: Kalle Valo

ray_cs: mark expected switch fall-throughs

2018-11-06T17:00:01+00:00

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 114948 ("Missing break in switch")
Addresses-Coverity-ID: 114949 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva 
Signed-off-by: Kalle Valo

ray_cs: remove redundant pointer 'p'

2018-07-31T07:19:50+00:00

Pointer 'p' is being assigned but is never used hence it is
redundant and can be removed. Also re-work if statement to remove
redundant assignment of p.

Cleans up clang warning:
warning: variable 'p' set but not used [-Wunused-but-set-variable]

Signed-off-by: Colin Ian King 
Signed-off-by: Kalle Valo

proc: introduce proc_create_single{,_data}

2018-05-16T05:23:35+00:00

Variants of proc_create{,_data} that directly take a seq_file show
callback and drastically reduces the boilerplate code in the callers.

All trivial callers converted over.

Signed-off-by: Christoph Hellwig